From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gjIQ319Q; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 081265A0265 for ; Tue, 24 Feb 2026 10:32:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771925578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQugd/S94hMZLrsMf89Q8QCiE7USPMApXsZ6xbA+GmQ=; b=gjIQ319QgjT05LwlWtTxa5D5nVGNMUWIl9we0eBb4DlLBmYx5Bs0zwI99i44Qomk225dDo kSEu4ZXkfp5TlsYV+ONj3hhim+4O71nvTnd0wEGOArkw2Tlj62blW+PN5fLv5/uOFDBxQC 1MbgI/5EdJj7QIjwr1SM9EqVZEYpQJo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-g4cxhu7LP-uXQr7bKQI1Zw-1; Tue, 24 Feb 2026 04:32:57 -0500 X-MC-Unique: g4cxhu7LP-uXQr7bKQI1Zw-1 X-Mimecast-MFC-AGG-ID: g4cxhu7LP-uXQr7bKQI1Zw_1771925576 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4398ad5d81dso119510f8f.0 for ; Tue, 24 Feb 2026 01:32:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771925576; x=1772530376; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k/UNDG6BPmlEsv0mHxQ29WYrXFYPQonxxqrZPEYxV5E=; b=mD+FQIOBmRC0SLrpaMljqaS9hp/Ng/uv2/caLJ+FDdjdSPWS19AP/Y9hfdnKNdTXSh Q8mKPQhOr3LBl2gKUqmuA4tVNdrcFjJ48ZYt1KlaWdt6F8BVhT7YacWi+5YH6bTvWHqA ZakqNLGj4s5FHFJhkxgTvB7pdmXzCOshCFrPba1kAMOj715LBuBw+GsHIqkVXYTZP7K1 Yq4RmKa0aq2voHcMHEJSLFBmC4OhQ6ZcUOBdzx8Yvr9EdVjZZYLf4QPgOrwadzThiltl AU/yqSWQ4qVde0yFzGAr7NXrbrn4gTT+FtE1rFQpvXRSeay3XSasR+dNOE05eoLf7w0x cPfw== X-Forwarded-Encrypted: i=1; AJvYcCUEGjNbdZw6o4+IMn7zBmcWfQ4rQ8pyk7D7glzhXhic2cle+Wfx2d6p4lbQQuFZCDxq+y7TGpL1+QU=@passt.top X-Gm-Message-State: AOJu0YzVTPwr/Jp29UjJcsBBSFXXeaSSqRQ6o/cdhapUfv9d7R361vwv 0p3+AGK4XIpUIRZsLRCHy8pDQjisNV5cDIRqc7/40dCQrUfTzoFI6oMIi1ppWxbmRLLGn09Cr+M d/ynVanySYSj4xjo7pOosHJxscCjObKGb8dYzEtuWgHCb+2yuGds6NQ== X-Gm-Gg: ATEYQzz8mKPe4WGGSyJNVQDoGub8XGFFOJqVbWtIoIBwcK2If9GF40o+EJLIpgtIQXr Xd3AVpRzyPxwIGJLDzDmk3TFbRMwHu6Uvghch9Um3gVUvRiOFWKgP5XfTMAHRyXX96YMMi+XbyC 7ToYsVyMs4KvsXPbQft1PR5FejRPMzlzyUtpceNbN3t3ZmfpR8fshHdvJve1zbTvzMNNaR9gMfY oUaoTUs3DkQbGO9H2XoeTSEU4BwceNHhaEYsaPIrBpLhaMOevlB7BjgxPVzZhy+09TeR/XRbCgt rLfYEGcLmKJiu3gEiPuzWNTS4xnQ735pAMw6k5UGc2x+QfYAvA3YLweDfjqCfCXJiz66u8yFbcf vP3RGtxL4mb18yfhqrQmpDmyy/F0aWM/1/guX+bifmFaCm4mDUg== X-Received: by 2002:a05:6000:24c2:b0:432:8504:a383 with SMTP id ffacd0b85a97d-4396f18554cmr20208877f8f.45.1771925575941; Tue, 24 Feb 2026 01:32:55 -0800 (PST) X-Received: by 2002:a05:6000:24c2:b0:432:8504:a383 with SMTP id ffacd0b85a97d-4396f18554cmr20208828f8f.45.1771925575409; Tue, 24 Feb 2026 01:32:55 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d4c60bsm25095626f8f.27.2026.02.24.01.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 01:32:54 -0800 (PST) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260224103253.3a633773@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> <20260223183530.2c040c94@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 24 Feb 2026 10:32:54 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: c5JsTO2_f-GngVHBzMlH1Gm0oYxSeUO7Sjt6RV4WVOM_1771925576 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5KPYFQXTWZKRZVKKYYWNFOYHX5HUHGMK X-Message-ID-Hash: 5KPYFQXTWZKRZVKKYYWNFOYHX5HUHGMK X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Peter Foley , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 24 Feb 2026 16:43:13 +1100 David Gibson wrote: > On Mon, Feb 23, 2026 at 01:08:07PM -0500, Peter Foley wrote: > > On Mon, Feb 23, 2026 at 12:35=E2=80=AFPM Stefano Brivio wrote: > > =20 > > > By the way, we already run clang-tidy tests ('make clang-tidy') as pa= rt > > > of our tests (test/build/static_checkers.sh). > > > > > > Would it be just a matter of enabling the misc-include-cleaner in the > > > list of tests we give clang-tidy from the Makefile: > > > > > > https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner= .html > > > > > > ? I haven't tried. > > > =20 > >=20 > > It appears so, a local change to pass -checks=3Dmisc-include-cleaner to > > clang-tidy resulted in a ton of errors like: > > /usr/local/google/home/pefoley/passt/vu_common.c:277:2: error: no heade= r > > providing "iov_from_buf" is directly included > > [misc-include-cleaner,-warnings-as-errors] > > 277 | iov_from_buf(in_sg, elem_cnt, VNET_HLEN, buf, total); > > | ^ > > /usr/local/google/home/pefoley/passt/vu_common.c:301:15: error: no head= er > > providing "ETH_ZLEN" is directly included > > [misc-include-cleaner,-warnings-as-errors] > > 9 | if (l2len >=3D ETH_ZLEN) > > | ^ > > /usr/local/google/home/pefoley/passt/vu_common.c:304:2: error: no heade= r > > providing "memset" is directly included > > [misc-include-cleaner,-warnings-as-errors] > > 9 | memset((char *)iov->iov_base + iov->iov_len, 0, ETH_ZLE= N - > > l2len); =20 >=20 > Unfortunately, I suspect this isn't going to work out. It may do some > of the checks we want here, but unfortunately it makes some very silly > warnings in relation to the standard library, which is why we disabled > it in the first place. See commit > 3be9e0010ea7329ae0f3707f67ac4cf0bac13d54 Ouch, right, I had forgotten about that. > I guess we should retry and see if the latest LLVM is better about > this, though. I guess: https://github.com/pefoley2/passt/commit/6ae0bcb2bbdc10384346dda547db60f8= 0c8a9676 makes that mostly pass with a recent LLVM version? If we need a dozen of suppressions (maybe even 20-30?) I would say it's sustainable, but more than that and it will start looking messy. --=20 Stefano