From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH trivial] tcp_vu, udp_vu: Fix comment headers for header length functions
Date: Tue, 24 Feb 2026 13:22:27 +0100 [thread overview]
Message-ID: <20260224122227.437310-1-lvivier@redhat.com> (raw)
The comment headers for tcp_vu_hdrlen() and udp_vu_hdrlen() described
the return value as "the size of the header in level 2 frame", but
these functions also include the virtio net header, which is not part
of the L2 frame.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tcp_vu.c | 4 ++--
udp_vu.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tcp_vu.c b/tcp_vu.c
index 94169c21f700..8908d376a7dd 100644
--- a/tcp_vu.c
+++ b/tcp_vu.c
@@ -40,10 +40,10 @@ static struct vu_virtq_element elem[VIRTQUEUE_MAX_SIZE];
static int head[VIRTQUEUE_MAX_SIZE + 1];
/**
- * tcp_vu_hdrlen() - return the size of the header in level 2 frame (TCP)
+ * tcp_vu_hdrlen() - Return the size of virtio net and L2 headers (TCP)
* @v6: Set for IPv6 packet
*
- * Return: return the size of the header
+ * Return: total size of virtio net header, Ethernet, IP and TCP headers
*/
static size_t tcp_vu_hdrlen(bool v6)
{
diff --git a/udp_vu.c b/udp_vu.c
index d190fef82d49..dd3f8e9272ff 100644
--- a/udp_vu.c
+++ b/udp_vu.c
@@ -37,10 +37,10 @@ static struct iovec iov_vu [VIRTQUEUE_MAX_SIZE];
static struct vu_virtq_element elem [VIRTQUEUE_MAX_SIZE];
/**
- * udp_vu_hdrlen() - return the size of the header in level 2 frame (UDP)
+ * udp_vu_hdrlen() - Return the size of virtio net and L2 headers (UDP)
* @v6: Set for IPv6 packet
*
- * Return: return the size of the header
+ * Return: total size of virtio net header, Ethernet, IP and UDP headers
*/
static size_t udp_vu_hdrlen(bool v6)
{
--
2.53.0
next reply other threads:[~2026-02-24 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 12:22 Laurent Vivier [this message]
2026-02-24 15:24 ` Stefano Brivio
2026-02-24 15:26 ` Laurent Vivier
2026-02-24 17:57 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224122227.437310-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).