From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M/+PsHzd; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 4B0C05A0265 for ; Tue, 24 Feb 2026 18:53:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771955630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZOXa1h2S+oZhAVL9g/HaU6wqNERcnUhL6gYh18Itvs=; b=M/+PsHzdBwTHO0WpQCM8T/iiK5fKAoLcEZkZE483af8Fedmc3QSjF/dgBBF5PhcVFrPBQw 6g5kEGauobKA1ViRxpR/UxEmaZXG2SuUoV/mMVWhRcW2dvsDnTpBxLwe/oRHZZQ/SLwK45 cjlushhS+4nedJdWr4ijTDPtwdu8Ofc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-GaPMo8ZUPQGkYAVtFwtXxw-1; Tue, 24 Feb 2026 12:53:48 -0500 X-MC-Unique: GaPMo8ZUPQGkYAVtFwtXxw-1 X-Mimecast-MFC-AGG-ID: GaPMo8ZUPQGkYAVtFwtXxw_1771955627 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4837246211bso61735205e9.0 for ; Tue, 24 Feb 2026 09:53:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771955627; x=1772560427; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CVKhBAzQWdvbhvc73MHuw2RoQb6yRKJqyxUx8yeT9wA=; b=CV/7d3Z0X5CibPBufwpZHZ0hEBisivc3hiPY8y1oM9YGNxYPm+bgeVszGk4QcHaVz5 9axacOnN7k12UB8dTsvnHvhQQJXwhmv+Alq81pkTp/sLB9/gJ4dgdJn6t2YblaXLxzsU 1CywWn+Vv0mFZ2ym3C/dxH6s+YiRlWEK7oFWOe/w1/tffp9xYvD0D9rKbTkfURg/7gCI BdcEQOUTsNN5oFL9Kxl4eIwLk8pIxoOH5XxWT7XQRNGZhs1vMshJ50edfMMJYr3yQjmm CB3ABCvzyA2onSOG655BAyBYnIBalT2EbozOMS5o4xiNXT6aRk3s6/gpADTaER3nYBYw 2lWw== X-Forwarded-Encrypted: i=1; AJvYcCV1/T7gTjqfS5PFfFfMkZmDPQWgeCD1NqPSJU9m6L83Ne97ln4w0+Ij2YSVJoAUk4PrBsD5nSFUo7I=@passt.top X-Gm-Message-State: AOJu0YzGwUNGha50ewuI5BGbmKTErNcU6D8AdfhrTnJf2oR5LKLn90sG dfkvhoRTBaKMWQmeJL3/FpSehvk61dBzXFchIcAg6obQMLppf6rY2NUU8Kf1vcbBOu4Ly1nEObl 83c0TMurB/QzdEzUk7GTFY1V868MZBpv1PMs3osSfy67uEKH972JqEw== X-Gm-Gg: AZuq6aItYM+S+Lb5H8t1dgw1m2+gxO8RAsbcga+Dmuivecpdmijgg461dUfc3BHT2TL fE5vS4S2nrLPbqTnIkPebcA0PliLSrAMvXSBpOoxw4SGTdAmR+PzuPr4OPGrZ36FBez7Vizic4w im4chaj1BxDb0kS9Xo81s+k8G+FpMEURVt+hoh/lyrmOPrU37kB56FVAxYjLxv4HqLstzEqMGDH ey/GSR/OPsVsO0XrBW9SBrz9bGrYvCBN5mdl3YKKW8kq3ef0xMUPr3onsj4W8hkudpD8KbIi4Ug Z6uQSpFxeWHuKXQc0IdY1Q4Fw+8zUpAqpvtkQgOawNQW8QmR5J1+h68QHzuv7sJ2exFhRN7EjDK EMtEjB/ZTaFCta+MXGssfVjf0Ia3xFhnj X-Received: by 2002:a05:600c:450c:b0:47d:73a4:45a7 with SMTP id 5b1f17b1804b1-483a96377b1mr212384065e9.24.1771955626903; Tue, 24 Feb 2026 09:53:46 -0800 (PST) X-Received: by 2002:a05:600c:450c:b0:47d:73a4:45a7 with SMTP id 5b1f17b1804b1-483a96377b1mr212383775e9.24.1771955626415; Tue, 24 Feb 2026 09:53:46 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd6854c7sm40945645e9.0.2026.02.24.09.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 09:53:45 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260224185343.249a499a@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> <20260223183530.2c040c94@elisabeth> <20260224103253.3a633773@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 24 Feb 2026 18:53:45 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F7mQnnBmHahRHjE3OtksoNW4Wp_EepPJnbJ0a9xEn6I_1771955627 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KM27T6HJAIACRGU62K5UATS5E3GDRA54 X-Message-ID-Hash: KM27T6HJAIACRGU62K5UATS5E3GDRA54 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 24 Feb 2026 11:49:13 -0500 Peter Foley wrote: > On Tue, Feb 24, 2026 at 4:33=E2=80=AFAM Stefano Brivio wrote: >=20 > > I guess: > > > > > > https://github.com/pefoley2/passt/commit/6ae0bcb2bbdc10384346dda547db60= f80c8a9676 > > > > makes that mostly pass with a recent LLVM version? If we need a dozen > > of suppressions (maybe even 20-30?) I would say it's sustainable, but > > more than that and it will start looking messy. > > Ideally glibc would add the necessary annotations to their bits/ headers = =20 > to make include-cleaner do the right thing, > but I'm not sure whether they'd want to do that in the first place. > And even if they did, it would take a while for a "fixed" version to roll > out. > Let alone other libc implementations like musl. >=20 > I suppose another track would be to add special-case logic to clang-tidy = to > not recommend bits headers, > but I don't know if the LLVM maintainers would like that either. Right, none of the options above look like reasonable short-term goals. What I was suggesting was to sprinkle the code with beauties such as: =09/* NOLINTNEXTLINE(misc-include-cleaner) */ before each "offending" include line... assuming it works, and assuming we need perhaps 20-30 of them. But if it's a lot more, then that's not a reasonable option either. --=20 Stefano