From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FDirFebr; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 6FE3B5A0265 for ; Tue, 24 Feb 2026 21:03:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771963404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hFLdeaAzD//jCJ3soOqP/wEa50iAbJ83eWpi02iAXEU=; b=FDirFebr+TEMZCyCnLK2QRv+T6zyxhas+qEE9xG7q6ng7c9AZQPrXqetlMwerbWBsaqacd oQIgkcJhSZJbi5JPVL7mS64hf+NzTi+gcvKB4W39qq07EZkDd8eGGP5S9wffJxY21J5FYO VDZ/0C5ZN1q4zcAu0eYV6t7Krc7/VmY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-zqE4jOSAMtGTEmhiyjogjQ-1; Tue, 24 Feb 2026 15:03:21 -0500 X-MC-Unique: zqE4jOSAMtGTEmhiyjogjQ-1 X-Mimecast-MFC-AGG-ID: zqE4jOSAMtGTEmhiyjogjQ_1771963400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-483a2db68caso46214145e9.0 for ; Tue, 24 Feb 2026 12:03:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771963400; x=1772568200; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hFLdeaAzD//jCJ3soOqP/wEa50iAbJ83eWpi02iAXEU=; b=roZyebvTDBByd1L/N9qhGMeqIWNqJUatc+az3eQi/zYM6A6wfbQ04xf0x+sFd/DiA6 FdI0NVZH/PKkTenGWnoghjpJjpe769evxuFTbUZEEFgxoJE3+mRRjeqVTI1YwPMdnE7x C/AHHUGn3eCYyIBXBHueVUpFYEU0xLP6To9mJUZMcLy+Y0qny13xZLeccCmsMXM2fT0p KKAV2ZGD4cY/VKRqdErDW9HUkVyFwgXaOCONZiG1Z8nnQA2FQAOnWWKAFiydFx+P79HL v2es+i6xYWMUr+T8vbEGNAVYdDyjo/KNTc0n4Yysxjp9Bt6uWlYMDbhUri3YRb3Qd9RD YM+w== X-Forwarded-Encrypted: i=1; AJvYcCUyTgoQfG0dePu8FTNG17dWsS6BKvU2ESlA1GyyLMDfRPNGtWOf9TxBWVwHpwvzek3vB6GJ1Vqr1oE=@passt.top X-Gm-Message-State: AOJu0YzQbNpt3qtprIfPnLubOrAdmwKA3FCs6Itataym93eM3mG02P6X FAQURMHlhWa1tGya26EJ8jLMSpjkonnPrBFmse4aeCol902wT6PcofB6/wNWthnwYdaZrcbDsvV yOYoglsVBCqI8Hv39+e8AxOAW03as4k5+GsQtpkvxNEnMxtQ17L0qQA== X-Gm-Gg: AZuq6aJooLK1PBQLnspX9ARGkeNHl9Wv3NTJBkPQ/ZBulSJkyRx6heovII9ozRj0eGh VcTnSB+mHAqDxCBQTrLEPngJ/7nQuJIBMH5/2skopTWKHkSIvkRhs/tV5LEOSj0LnYXKy6Rn5sJ PL/VU2PYCSTs0xde8KjbwwgynE+LUVdqYVDzzSt0n2nZcc+60Qzm2n53FYy7TXRA20kz6pZ4eYX sH/jwq8gcNHyK1CMHd/ZqEd+dL4JUAuLzuh3+V7zeWXkPhX88tghXlZlnfl/joKBmqjKoQK2Q80 JSqIe+ssYHMdNLpvP0iKS0sVyOh11l1boKBE0dExC1PiIZsMVm5Nj8laN1khNXtwxhUtqaux2fo nAq1CTiW+DZAIuhvVPfdlCtM/gu1nM92LsQxSzV82pQPM6SaP1g== X-Received: by 2002:a05:600c:1d19:b0:477:abea:9028 with SMTP id 5b1f17b1804b1-483a95a9d86mr219841655e9.6.1771963399977; Tue, 24 Feb 2026 12:03:19 -0800 (PST) X-Received: by 2002:a05:600c:1d19:b0:477:abea:9028 with SMTP id 5b1f17b1804b1-483a95a9d86mr219841335e9.6.1771963399571; Tue, 24 Feb 2026 12:03:19 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd7010a0sm15970335e9.5.2026.02.24.12.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 12:03:19 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260224210317.585fe9e8@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> <20260223183530.2c040c94@elisabeth> <20260224103253.3a633773@elisabeth> <20260224185343.249a499a@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 24 Feb 2026 21:03:18 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vI1guL-zpCESvjvQeManpqLNbc37_6UECQBAsmoNod4_1771963400 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: K4RLYW464DJGDM3MFGA7QVKF35DIHWSN X-Message-ID-Hash: K4RLYW464DJGDM3MFGA7QVKF35DIHWSN X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 24 Feb 2026 13:52:04 -0500 Peter Foley wrote: > On Tue, Feb 24, 2026 at 12:53=E2=80=AFPM Stefano Brivio wrote: >=20 > > > > What I was suggesting was to sprinkle the code with beauties such as: > > > > /* NOLINTNEXTLINE(misc-include-cleaner) */ > > =20 >=20 > Unfortunatly it needs to go before the usage, not the include. Ah, right, of course. > > before each "offending" include line... assuming it works, and > > assuming we need perhaps 20-30 of them. But if it's a lot more, then > > that's not a reasonable option either. >=20 > I get "72 warnings treated as errors" when running clang-tidy with my > current set of patches. Ugh. Yet another alternative could be to enable misc-include-cleaner for headers only, which would probably need a separate invocation of clang-tidy. I'm not sure if that will work at all though. If it doesn't, I'm out of ideas... maybe we should simply go back to your original patch, in that case, and you'll just get to "fix" things as they break (hopefully infrequently) in the future. --=20 Stefano