From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hpsTaKGa; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 6B7395A0265 for ; Tue, 24 Feb 2026 22:18:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771967907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q0KgAQrR4PsvzfeBwuL07qFqgp9yTnvsUqi7GHFhmjc=; b=hpsTaKGardkWAR8V1EIxxd82v0USwAkRDKHiiJBpHdcw+8VRewlCVouZOxuBiKQTRpbWKN Tne5Mskmpk1mBDu5AFOgzhe2bZZF8f29kjQWkYH1ySSqHmn4v2KGCxxiKkpJ6xgvTvP61T b1SfgkW1qxwVwyxp8NiGVbjAG1SD9E4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-gxtNLeNnMLib9V0lrilxtA-1; Tue, 24 Feb 2026 16:18:25 -0500 X-MC-Unique: gxtNLeNnMLib9V0lrilxtA-1 X-Mimecast-MFC-AGG-ID: gxtNLeNnMLib9V0lrilxtA_1771967904 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4836abfc742so40796305e9.0 for ; Tue, 24 Feb 2026 13:18:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771967904; x=1772572704; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KCbZIi5l+HgAKRBS1QXsmJKm0M2ZLxli1MVXlx17N1s=; b=o/JsM3l+h3lAcn3vs5/3zDf+TlXvU/9gHRpD5SJhCcIo/FzTFexLl5Ywvy0qp1/o3Y 0FVwhyDU7eJSDpJFtjlQ/8HN6o065si1B7ZbQUQt0R2Nq1f+aD8cXsi5cu29mrP7ggUY qSL2ZXIpnMyBt0DP9bmnr2HrQRZMwUV7eLq08tdsy6sp6GbhF1DROTS/1Cy++8s9s1St rmS0oswhO3gKMTPqHBZNjx8qGmIoFuWnhoTfpb8OGntbft/+bSg4qgYRKtchCPHivrjN H4RBXsuvMFFC9SiOrLNYj/j59s8iotGV4otiymk0GprVozrR4SRtvH6o2L/j5Frn0hgQ 5/IQ== X-Forwarded-Encrypted: i=1; AJvYcCW8xoB1y0sb3kcV1Hw7w31toul3AaiUn7tzZSNXE645tHGKy41QDyV9JcNCFryfocdCRvNHDhqFS90=@passt.top X-Gm-Message-State: AOJu0YxDDxlFw6iYTDAvcTbXyiu+/xQLAy5NlIbhxCyxPFPhgtTJVgDs qN7b5eYtwb0GS7+FvRUvWQtRiB6h0a1qVJaxkcgR3Wu/nljMZZB68oZSu1nhdKFp+zNmI9nGcNG EYSI3gPRo7ZajtDsaCcJW3xpejgkX4GmmDft8B6y1ZSbyC0CBft57AQ== X-Gm-Gg: AZuq6aLTb65AkatNzq+JHcr4MmqcThEXYt3avSIt0mePJJjPGfl0TeKQa95IZho7ofh 6/l2ZEQgl2RxcMMK+S/+HNhFseHY0F/faSGUisOJxdBeKWxrZ8wl2P/hkA1KRHyDf+4+05fxXst pb/FKk80jwXBvNpCEs5194GBeT8LRYCnFJ/T6kZis8Q63W+MQlN/REI7bQnSFMwgWgrq7RqDkji yiigFKcnEKS/VmYiyzQavkvWADF6R3/HhM+dD6B8s207kRJL3CBtT9kF5mYg2BZe3wxIJhHqlcw 8xiclgoPKwyEUxeqvaLCfGY9eZE7g5vODR96eCLcyzv2qYGwawNxEsacGhc0iEL10yDV7euVqHH PmOKTM99BaTKPIni3QbY5BkXrowPiaQLauo4M70NOzzqLzdggEw== X-Received: by 2002:a05:600c:3b94:b0:47a:814c:eea1 with SMTP id 5b1f17b1804b1-483bef6411bmr3357045e9.35.1771967903958; Tue, 24 Feb 2026 13:18:23 -0800 (PST) X-Received: by 2002:a05:600c:3b94:b0:47a:814c:eea1 with SMTP id 5b1f17b1804b1-483bef6411bmr3356585e9.35.1771967903396; Tue, 24 Feb 2026 13:18:23 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bedcf376sm1404975e9.17.2026.02.24.13.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 13:18:22 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260224221821.1d8ef7c1@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> <20260223183530.2c040c94@elisabeth> <20260224103253.3a633773@elisabeth> <20260224185343.249a499a@elisabeth> <20260224210317.585fe9e8@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 24 Feb 2026 22:18:22 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _BiUA8UMjnSnWtctAY01_apEKaN0cB47JJ1nS6jZl3M_1771967904 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ARMH5OMKV5N4MQYDKSWZDKZYOZ4M66SJ X-Message-ID-Hash: ARMH5OMKV5N4MQYDKSWZDKZYOZ4M66SJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 24 Feb 2026 15:24:57 -0500 Peter Foley wrote: > On Tue, Feb 24, 2026 at 3:03=E2=80=AFPM Stefano Brivio wrote: >=20 > > Ugh. Yet another alternative could be to enable misc-include-cleaner fo= r > > headers only, which would probably need a separate invocation of > > clang-tidy. > > > > I'm not sure if that will work at all though. If it doesn't, I'm out of > > ideas... maybe we should simply go back to your original patch, in that > > case, and you'll just get to "fix" things as they break (hopefully > > infrequently) in the future. > > I tried that, it didn't go well either: =20 > /usr/local/google/home/pefoley/passt/util.h:140:5: error: no header > providing "__BYTE_ORDER" is directly included > [misc-include-cleaner,-warnings-as-errors] >=20 > 9 | #if __BYTE_ORDER =3D=3D __BIG_ENDIAN >=20 >=20 >=20 > | ^ >=20 > /usr/local/google/home/pefoley/passt/util.h:140:21: error: no header > providing "__BIG_ENDIAN" is directly included > [misc-include-cleaner,-warnings-as-errors] >=20 > 140 | #if __BYTE_ORDER =3D=3D __BIG_ENDIAN >=20 >=20 >=20 > | ^ >=20 > /usr/local/google/home/pefoley/passt/util.h:241:42: error: no header > providing "iovec" is directly included > [misc-include-cleaner,-warnings-as-errors] >=20 > 9 | int write_remainder(int fd, const struct iovec *iov, size_t iovcn= t, > size_t skip); > | ^ >=20 >=20 >=20 > /usr/local/google/home/pefoley/passt/util.h:254:35: error: no header > providing "sa_family_t" is directly included > [misc-include-cleaner,-warnings-as-errors] >=20 > 9 | static inline const char *af_name(sa_family_t af) Oh... fun. > I'm inclined to forget about trying to fix everything and just do the > minimal set of changes to make the tooling happy with parsing the headers= . Yeah, at this point I'd totally support that. --=20 Stefano