From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UQOMZsBq; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id CA4DC5A026D for ; Wed, 25 Feb 2026 07:15:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772000149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ngw9bb4+/bSnznnSzPpaHoasUTbYO4UogkkJlZnRv3Q=; b=UQOMZsBqD79BWXIRC9F7T70+nIPhc6OSztLYT+ABU6dVcuzh7q0JESqQzVZrkuaw1cOI/3 6deO+Cmk+aaEGww3730JpSpY7H14zBM8Gc0/UC2JpE8FKGjg2wRjq0AHvB6zbXB+0smqGN oHZmwh8uqeW0YTNFuLFU8HDcGVqEmJo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-170-fC-dFqCjNOCPcr8qDTvzVw-1; Wed, 25 Feb 2026 01:15:47 -0500 X-MC-Unique: fC-dFqCjNOCPcr8qDTvzVw-1 X-Mimecast-MFC-AGG-ID: fC-dFqCjNOCPcr8qDTvzVw_1772000146 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4837b6f6b93so46272255e9.3 for ; Tue, 24 Feb 2026 22:15:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772000146; x=1772604946; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ngw9bb4+/bSnznnSzPpaHoasUTbYO4UogkkJlZnRv3Q=; b=S2KIOOHpdE/iKjcVj+Ri1HChHpdxlK9DpYYiAP2urNznEwBFZEzVGFt0XarWU6k3U9 rT0/dxDB2+dsOazHJKfY6fg6RZABs0nsmO+FFCexNtnysTnsX7gu/fnE2JkVGR6t8ZZ6 +sHjarLKOdgf00UhtBZC53f8r8zOlvlbvnEgq3xCQPBXQnOwwBC4ef9rrG7jVy2THG9W CGctodQZBrasl0mWesq+eXCnlfWOA9ksJEiARXQ2UXbOJYVYgSvfnJ/1k9heUvjhMeqD jrGwJ+n7AorULnS8XzsOyTNUXP7dEXwjn3C8vttKKyGgqjMX3OJXXZdAwKFEFtBF5cwn mVDg== X-Gm-Message-State: AOJu0YzWjXD/7uIUKBGVN8KlaN4Xb3uVYQ7QohfVB+px7C6sr2b+o7t+ 6soOn+JZ+WMuSOOIfDJw0I2PcEA8y2YPArVcw9BE4fhNOx+TsgG+46nPISSYfjeobeXzJ4j+3dA rdN0ZtAacnxCndbo4NoNr25W4rTHJpYEgN58NlVYYsmOlI1F3/iXNGw== X-Gm-Gg: ATEYQzw5MOq5owLXeCq1RbLS0l/Gp5D0g6AOoZdku+KwbTgAmKpHjVeCdTog5f5btKL wrTu8/6PbwVJwrlOhuGMICGDtUvfS3Sh5FR08SbV9wGROq2F5BCeyNH5tjXlbPeJAFHHxmAM7Da jDLkLIRcxahsMSrFF8Vn6+EqxwfCnqTAyuv5MZCuU5trFQbyUP3zSof2lJ6nusc98tNfHFralTI oLPmr2y7Vfhsd/kBbZmHPOHFW3Lc7+oyVYXXv1+4UhxsX7LtWSSJkxA+msyeOOImkJmClVAQ7hS fya9u2SI/yEmktqr7lRyC0bRjprRx2W5WZHBySFOIH6MFvbsK1s0I9ic/RrDeMgfnWjf++mlmoT zl8WqMr7gK2gNpNCvd8K0545Cm+v4omEE X-Received: by 2002:a05:600c:6087:b0:477:7b16:5f9f with SMTP id 5b1f17b1804b1-483bef62741mr23446475e9.31.1772000146371; Tue, 24 Feb 2026 22:15:46 -0800 (PST) X-Received: by 2002:a05:600c:6087:b0:477:7b16:5f9f with SMTP id 5b1f17b1804b1-483bef62741mr23446085e9.31.1772000145922; Tue, 24 Feb 2026 22:15:45 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd702e7bsm52032685e9.5.2026.02.24.22.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:15:45 -0800 (PST) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/4] Reworks and improvements to TCP activity timers Message-ID: <20260225071544.2c4b6de5@elisabeth> In-Reply-To: <20260206061739.33648-1-david@gibson.dropbear.id.au> References: <20260206061739.33648-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 25 Feb 2026 07:15:45 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LB3vzcrksyAc1jtZPGCkMIc7hnQk3-iztZb04feOF1M_1772000146 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: AOZ7MQROANIHPWEHPEBSULAQTPDQBTHC X-Message-ID-Hash: AOZ7MQROANIHPWEHPEBSULAQTPDQBTHC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 6 Feb 2026 17:17:35 +1100 David Gibson wrote: > Here's a bunch of patches aimed at fixing bug 179, and reworking the > currently broken inactivity timer along the way. > > I believe patches 1..2/4 are ready to go - I've tested them, and I'm > happy with how they're behaving. Patches 3..4/4 I think are correct, > but I've been getting bogged down in details trying to test them in > the specific FIN_WAIT_2 situation that occurs in bug 179. I just tested things manually by cycling guest interfaces and checking that keepalives come and eventually cause connection resets, as well as that the activity timeout (shortened via define) triggers after the expected time. It's not great but I couldn't figure out a way to simulate the issue with a single namespace test (without any connecting interface that can be brought down), and simulating this with multiple namespaces connected via veth looks doable, but not easy to integrate with the existing tests. Meanwhile the reporter of https://bugs.passt.top/show_bug.cgi?id=179 confirms this series solves the issue, and delaying this further doesn't sound like a good idea, so I went ahead and finally applied this, fixing a trivial conflict with 812cdb802c6e ("tcp: Move tap header update out of tcp_fill_headers()") on the way. -- Stefano