public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH 09/12] vu_common: Accept explicit iovec counts in vu_set_element()
Date: Fri, 27 Feb 2026 15:03:27 +0100	[thread overview]
Message-ID: <20260227140330.2216753-10-lvivier@redhat.com> (raw)
In-Reply-To: <20260227140330.2216753-1-lvivier@redhat.com>

Previously, vu_set_element() derived the number of iovec entries from
whether the pointer was NULL or not (using !!out_sg and !!in_sg). This
implicitly limited each virtqueue element to at most one iovec per
direction.

Change the function signature to accept explicit out_num and in_num
parameters, allowing callers to specify multiple iovec entries per
element when needed. Update all existing call sites to pass the
equivalent values (0 for NULL pointers, 1 for valid pointers).

No functional change.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 tcp_vu.c    |  4 ++--
 vu_common.c |  5 +++--
 vu_common.h | 13 ++++++++-----
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/tcp_vu.c b/tcp_vu.c
index 92667507ac9b..77d6e75496a0 100644
--- a/tcp_vu.c
+++ b/tcp_vu.c
@@ -87,7 +87,7 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags)
 
 	hdrlen = tcp_vu_hdrlen(CONN_V6(conn));
 
-	vu_set_element(&flags_elem[0], NULL, &flags_iov[0]);
+	vu_set_element(&flags_elem[0], 0, NULL, 1, &flags_iov[0]);
 
 	elem_cnt = vu_collect(vdev, vq, &flags_elem[0], 1,
 			      MAX(hdrlen + sizeof(*opts), ETH_ZLEN + VNET_HLEN), NULL);
@@ -149,7 +149,7 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags)
 	nb_ack = 1;
 
 	if (flags & DUP_ACK) {
-		vu_set_element(&flags_elem[1], NULL, &flags_iov[1]);
+		vu_set_element(&flags_elem[1], 0, NULL, 1, &flags_iov[1]);
 
 		elem_cnt = vu_collect(vdev, vq, &flags_elem[1], 1,
 				      flags_elem[0].in_sg[0].iov_len, NULL);
diff --git a/vu_common.c b/vu_common.c
index a8d5fcdaea83..b6753a556049 100644
--- a/vu_common.c
+++ b/vu_common.c
@@ -59,12 +59,13 @@ int vu_packet_check_range(struct vdev_memory *memory,
  * @iov:	Array of iovec to assign to virtqueue element
  * @elem_cnt:	Number of virtqueue element
  */
-void vu_init_elem(struct vu_virtq_element *elem, struct iovec *iov, int elem_cnt)
+void vu_init_elem(struct vu_virtq_element *elem, struct iovec *iov,
+		  int elem_cnt)
 {
 	int i;
 
 	for (i = 0; i < elem_cnt; i++)
-		vu_set_element(&elem[i], NULL, &iov[i]);
+		vu_set_element(&elem[i], 0, NULL, 1, &iov[i]);
 }
 
 /**
diff --git a/vu_common.h b/vu_common.h
index 41cf18936300..c1d2ce888f12 100644
--- a/vu_common.h
+++ b/vu_common.h
@@ -32,15 +32,18 @@ static inline void *vu_payloadv6(void *base)
 /**
  * vu_set_element() - Initialize a vu_virtq_element
  * @elem:	Element to initialize
- * @out_sg:	One out iovec entry to set in elem
- * @in_sg:	One in iovec entry to set in elem
+ * @out_num:	Number of outgoing iovec buffers
+ * @out_sg:	Out iovec entry to set in elem
+ * @in_num:	Number of incoming iovec buffers
+ * @in_sg:	In iovec entry to set in elem
  */
 static inline void vu_set_element(struct vu_virtq_element *elem,
-				  struct iovec *out_sg, struct iovec *in_sg)
+				  unsigned int out_num, struct iovec *out_sg,
+				  unsigned int in_num, struct iovec *in_sg)
 {
-	elem->out_num = !!out_sg;
+	elem->out_num = out_num;
 	elem->out_sg = out_sg;
-	elem->in_num = !!in_sg;
+	elem->in_num = in_num;
 	elem->in_sg = in_sg;
 }
 
-- 
2.53.0


  parent reply	other threads:[~2026-02-27 14:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 14:03 [PATCH 00/12] vhost-user,udp: Handle multiple iovec entries per virtqueue element Laurent Vivier
2026-02-27 14:03 ` [PATCH 01/12] iov: Add iov_tail_truncate() and iov_tail_zero_end() Laurent Vivier
2026-03-01 23:47   ` David Gibson
2026-02-27 14:03 ` [PATCH 02/12] vhost-user: Use ARRAY_SIZE(elem) instead of VIRTQUEUE_MAX_SIZE Laurent Vivier
2026-03-01 23:48   ` David Gibson
2026-02-27 14:03 ` [PATCH 03/12] udp_vu: Use iov_tail to manage virtqueue buffers Laurent Vivier
2026-03-02  0:03   ` David Gibson
2026-02-27 14:03 ` [PATCH 04/12] udp_vu: Move virtqueue management from udp_vu_sock_recv() to its caller Laurent Vivier
2026-03-02  0:05   ` David Gibson
2026-02-27 14:03 ` [PATCH 05/12] iov: Add IOV_PUT_HEADER() to write header data back to iov_tail Laurent Vivier
2026-03-02  0:08   ` David Gibson
2026-02-27 14:03 ` [PATCH 06/12] udp: Pass iov_tail to udp_update_hdr4()/udp_update_hdr6() Laurent Vivier
2026-03-02  0:13   ` David Gibson
2026-02-27 14:03 ` [PATCH 07/12] udp_vu: Use iov_tail in udp_vu_prepare() Laurent Vivier
2026-03-02  0:24   ` David Gibson
2026-02-27 14:03 ` [PATCH 08/12] vu_common: Pass iov_tail to vu_set_vnethdr() Laurent Vivier
2026-03-02  0:51   ` David Gibson
2026-02-27 14:03 ` Laurent Vivier [this message]
2026-03-02  0:54   ` [PATCH 09/12] vu_common: Accept explicit iovec counts in vu_set_element() David Gibson
2026-02-27 14:03 ` [PATCH 10/12] vu_common: Accept explicit iovec count per element in vu_init_elem() Laurent Vivier
2026-03-02  0:55   ` David Gibson
2026-02-27 14:03 ` [PATCH 11/12] vu_common: Prepare to use multibuffer with guest RX Laurent Vivier
2026-03-02  0:59   ` David Gibson
2026-02-27 14:03 ` [PATCH 12/12] vhost-user,udp: Use 2 iovec entries per element Laurent Vivier
2026-03-02  1:03   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227140330.2216753-10-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).