From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Fz67Uu+C; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 947A85A0262 for ; Tue, 03 Mar 2026 20:11:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772565097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXlnSTfkFf5hec2qsQ81xEroY1eAfg4JVukUSWo9H2Q=; b=Fz67Uu+Cgs4NnuNqor6nhNl4jR5FK2Jn1pyBLvxU3DmtBauUlK1MnIj8XDPhQ3+zEMt3Qw sDJ3au5gABxTwd/jAl38qawNoxj1vSfm8yU4C8FL4GUatAOJaGj0Zr2C9ONItzdspptBFj T8tG0yW2FK2cDoP4yHeCD7GQ1pNp8kc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-gqcrI9AWNYevsbqi488T0A-1; Tue, 03 Mar 2026 14:11:36 -0500 X-MC-Unique: gqcrI9AWNYevsbqi488T0A-1 X-Mimecast-MFC-AGG-ID: gqcrI9AWNYevsbqi488T0A_1772565095 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48379489438so57699555e9.2 for ; Tue, 03 Mar 2026 11:11:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772565094; x=1773169894; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IXlnSTfkFf5hec2qsQ81xEroY1eAfg4JVukUSWo9H2Q=; b=vQ153iw3t1ZTiVVAzjY7YYDXWHbBQ/S4An+o6aGmQvQCqonuSpqD1k7oyivjYHwo7g 7Jd9jwtpqJ1XUKhZQFZA0/E6Y4KfoLsF77TB9j9mAmjUWF5RE6d/ULvlvb3AS2L3qXH4 9ndf1ZXBei+NSUGdfCMoaC8ZugTLHQJ2ffUaWTzonTzzXaXQnlv7LtAz9lwUxY8MAkFh XMBYRD6ACsBIBrtwuVS/kZd9rOD84HodUoEr5GvArlVZZbL3nFYZxef2kheSqsv8mjTp Ky5gwrt1mWvW1Rx6dBIJyQYlCAildF8SW7IH4FLdZrb/X7GMWB2JXDg8RzGwSbT7Xc18 F0Ow== X-Gm-Message-State: AOJu0YyuUOaBGIcJ5OO2S+rshQmba0sHEe3DWTMMBRqL6+VvLbPtJbNY puOqxaodQxdHhRwUtuqnaH699AuulyFukfHRQLAoWfQp8oNustNeH4Kq5RWF1gfRyLeyN/E8jHJ EgefRhbC0PXzF0AN0xVOY7IArci5ruSd0Ts9IcDU+XVK/sNvojJStQsnB66fY8UKbWCgOdTbdeJ mnKrmlUb0MCODfsKzpGWHGY1qgPyDkw851+68j X-Gm-Gg: ATEYQzx/bQKa7OYFiKlyZyvOSVtLoYEXCUbELOkaKlrITj6aKpUS+iwxPSMT7Y9rZGz UJPX+CbeQz8R6OBJFcfj6aWTXZ5XtQZ9tC4tQpONSq3ty9tjbH8FzC/+0NNEU6Q+s7uhLVH63Lk UL3vm13RhzanuyK5us5zDA3gtbsxwB/e/9c16ebkryRiKf/2ccD8XLBSB5eaIUgMYHfs4NtCDiT eMuejCr9X6SCiMxSC5BlNkZ4FZLQqr7+xv6XaKcAXWem88RdYImIXRUqBkuUf/7gXSoorolZfN2 Thudj3GiR58gFCYe/gi3dPYl5VkzD91BAkGGg45qDMviGb2EpHWohv4cgoo/b28uvzuwBiIsrPJ b+myQfIf29mBsRfgIi3l7Q07QxE5Ql0+n17sW6TNVaaQkRc5okg== X-Received: by 2002:a05:600c:b86:b0:480:4a90:1b06 with SMTP id 5b1f17b1804b1-483c9c196a5mr280387345e9.34.1772565094361; Tue, 03 Mar 2026 11:11:34 -0800 (PST) X-Received: by 2002:a05:600c:b86:b0:480:4a90:1b06 with SMTP id 5b1f17b1804b1-483c9c196a5mr280386845e9.34.1772565093798; Tue, 03 Mar 2026 11:11:33 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485135cfa25sm25671875e9.27.2026.03.03.11.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 11:11:33 -0800 (PST) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH trivial] checksum: fix clang-tidy error Message-ID: <20260303201131.2cf8b06c@elisabeth> In-Reply-To: <20260226162451.1717333-1-lvivier@redhat.com> References: <20260226162451.1717333-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 03 Mar 2026 20:11:32 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mid9M-rntsM12GC9tCgfVNFE0tAURPdBYWxkEsETSkk_1772565095 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GP4CO3ZWOALZBLQHLFRKNUMS6UVGU2E6 X-Message-ID-Hash: GP4CO3ZWOALZBLQHLFRKNUMS6UVGU2E6 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jfiusdq@proton.me X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 26 Feb 2026 17:24:51 +0100 Laurent Vivier wrote: > Fix the following error reported by clang-tidy > > $ make clang-tidy > ... > checksum.c:284:2: error: preprocessor condition can be written more concisely using '#ifdef' [readability-use-concise-preprocessor-directives,-warnings-as-errors] > 284 | #if defined(__AVX2__) > | ^~ ~~~~~~~~~~~~~~~~~ > | ifdef __AVX2__ > > Fixes: 036fb8770cc2 ("checksum: add VSX fast path for POWER8/POWER9") > Cc: jfiusdq@proton.me > Signed-off-by: Laurent Vivier > --- > checksum.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/checksum.c b/checksum.c > index 828f9ecc9c02..bfba6f78b293 100644 > --- a/checksum.c > +++ b/checksum.c > @@ -281,7 +281,7 @@ void csum_icmp6(struct icmp6hdr *icmp6hr, > icmp6hr->icmp6_cksum = csum(payload, dlen, psum); > } > > -#if defined(__AVX2__) > +#ifdef __AVX2__ > #include > > /** This (conceptually) conflicts with a newer patch: [PATCH 3/3] clang-tidy: Don't insist on #ifdef over #if defined() https://archives.passt.top/passt-dev/20260302043135.800803-4-david@gibson.dropbear.id.au/ which, Laurent mentioned offline, is preferable to this in his view. So I'm going to drop this (while carrying the Fixes: tag and adding a Reported-by:) in favour of that one. -- Stefano