Re: [PATCH] Avoid clang warnings in fwd.h

[Stefano Brivio <sbrivio@redhat.com>]

On Mon, 23 Feb 2026 12:29:20 -0500
Peter Foley <pefoley@google.com> wrote:

> e.g.
> ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions]
>    65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> 
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
>  fwd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fwd.h b/fwd.h
> index 1607011..7d299b6 100644
> --- a/fwd.h
> +++ b/fwd.h
> @@ -62,7 +62,7 @@ union fwd_listen_ref {
>  	};
>  	uint32_t u32;
>  };
> -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), "");
>  
>  enum fwd_ports_mode {
>  	FWD_UNSET = 0,

Peter, unless you see a problem with that, this patch would be
superseded by:

  [PATCH 2/3] fwd, pif: Replace with pif_sock_l4() with pif_listen()
  https://archives.passt.top/passt-dev/20260302043135.800803-3-david@gibson.dropbear.id.au/

as it avoids the need for this static_assert() altogether. So I would
drop this patch (carrying a Reported-by: tag) in favour of that one.

-- 
Stefano