From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MSZ7dIuj; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 664055A0265 for ; Tue, 03 Mar 2026 20:11:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772565109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnpyclFcOzElRocXPDTKCjTP/KclQDEpCzT3+T/aAKE=; b=MSZ7dIujvD+0SG68XAJE/R0dId4fMRoszgx/VkDntKXhPq8PQj8pNF0sMH2pVlitrllGhA UYGpnXKY38M8gjN4GEo9SSLHsh5FHxDOfmNPthiCOM9lOLu1Ozmh2N09P+OrEMQaFiljQx UUMkLlhG8UsTeKzLWIuBfh7V6VyTKFs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-9jJpyROxNEeyfriZLp7LIw-1; Tue, 03 Mar 2026 14:11:47 -0500 X-MC-Unique: 9jJpyROxNEeyfriZLp7LIw-1 X-Mimecast-MFC-AGG-ID: 9jJpyROxNEeyfriZLp7LIw_1772565107 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4806cfffca6so58537135e9.2 for ; Tue, 03 Mar 2026 11:11:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772565106; x=1773169906; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SnpyclFcOzElRocXPDTKCjTP/KclQDEpCzT3+T/aAKE=; b=Cb5EjDd7JGJPusPsN6PYbr2R/m+CaehaLzc2AAKue7phcECA7FfWeaFOeAbTrLLcHW RnTWL+Tzsh3YJXGd1RWCF9wME3ujTSnaxnbW1LUI3aJxbDlQ7HBrTcV9dfUyDyNMNZlo 6WqvkAAniDrD9KHttiOe0Cw1rXJcv8zMvvnze4BLQuho1TjaZj5RjflwM1n98J3zpTZk 5BslT7F1lDEFIgaQb88AfoE3N8CProMt3YCb4kiMERcB5iXSvxvspm3mMJ97pYF7CaXJ /e7xEXtYBnbBY1EIDT5tOl1K3Wu5FhKYxP8V5bIO3lI2+KE7vvHxOhHJxmT0L+Mi9yvo MPwg== X-Gm-Message-State: AOJu0Yx5G1s2Lh58HOov6JFb9+USKnDZtTrHnylZqAPLs7DzAz/kuyhg 5ZxoryGH11N5NYZlABCSVUBawVNFEze4PogHZXfe9ncJOTC4jh++v5xWbDeTr5reEmrFrwH8DOC XEpfVJh1WEPgWXL7/h76/mT5NY26zYKzqatZiMZPlpiABvX8cubwB12FgRU9zRw== X-Gm-Gg: ATEYQzyX3KD+DqZ15UJzgJzqPlTDFi6sfI0rO/gbFnMcmykV7nce7bBYCzPBXES5NLH ZcbxeieDT7LhMv66d0OXZ4Kn74nG7gbDEZhzaVTQoopK2WI9WHJEeYkZuNfbHBcxatQ1GVVcuJz 34Sc+O8qxTbm6YTLDrBsS17MnyQNsm2uhgS6rbDxnkFJljVZZ5U6gm6HotkhMIZQOomWlR7b9VV KgiK/Q2+4ndC951B56MA0ZZLBm/ovclbHEPzm3HfkztOSKcjw0EmQhHDK0390HsB/49lD/VgmBp rZ1uUBS2LigR7BNHG7XM7LWKP0huVCJP88CWpgcIwSOraptzN8B9xiC9FSm8GsEt/eMPoC9EpmM DqMpS8PxYbID659GczwnVI7h7qsd+cn/fg57s95MvrPLhiifctw== X-Received: by 2002:a05:600c:c167:b0:47d:5e02:14e5 with SMTP id 5b1f17b1804b1-483c9bb660amr287814965e9.5.1772565106074; Tue, 03 Mar 2026 11:11:46 -0800 (PST) X-Received: by 2002:a05:600c:c167:b0:47d:5e02:14e5 with SMTP id 5b1f17b1804b1-483c9bb660amr287814515e9.5.1772565105546; Tue, 03 Mar 2026 11:11:45 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483c3b4410bsm383027465e9.6.2026.03.03.11.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 11:11:45 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Avoid clang warnings in fwd.h Message-ID: <20260303201143.1d3aac40@elisabeth> In-Reply-To: <20260223172920.146057-1-pefoley@google.com> References: <20260223172920.146057-1-pefoley@google.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 03 Mar 2026 20:11:44 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mezAAtk1IeF7X5Ofz71wd2g8MiobkrTyXrMJbcu-sDw_1772565107 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PSBKHKQ7VBBEK6ZYJ4NTYUL47FOLFN2N X-Message-ID-Hash: PSBKHKQ7VBBEK6ZYJ4NTYUL47FOLFN2N X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 23 Feb 2026 12:29:20 -0500 Peter Foley wrote: > e.g. > ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions] > 65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t)); > > Signed-off-by: Peter Foley > --- > fwd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fwd.h b/fwd.h > index 1607011..7d299b6 100644 > --- a/fwd.h > +++ b/fwd.h > @@ -62,7 +62,7 @@ union fwd_listen_ref { > }; > uint32_t u32; > }; > -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t)); > +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), ""); > > enum fwd_ports_mode { > FWD_UNSET = 0, Peter, unless you see a problem with that, this patch would be superseded by: [PATCH 2/3] fwd, pif: Replace with pif_sock_l4() with pif_listen() https://archives.passt.top/passt-dev/20260302043135.800803-3-david@gibson.dropbear.id.au/ as it avoids the need for this static_assert() altogether. So I would drop this patch (carrying a Reported-by: tag) in favour of that one. -- Stefano