From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YXB5Royh; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 8AFAB5A0269 for ; Thu, 05 Mar 2026 01:38:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772671113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tppJGlIkxoekDV817wyANNImacRRrxRVK5GJSuKUMEM=; b=YXB5RoyhMLG/uWWr0SakfItVP5GiGz7vnEbpV88X/OOrrMceg0xVleFfwUquYzebzDfU8d 0R9YTbtIbvssB48f2bIcTvpA6LJlgI4RR0YVZZ9I7WofXXM2Bb5gio9QUSIHj4dpdza7+C obtq1lGgaXYKba3+70/cFaUXVOX7J2I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-Z47GF9PKPDmpXbRS4qNeew-1; Wed, 04 Mar 2026 19:38:31 -0500 X-MC-Unique: Z47GF9PKPDmpXbRS4qNeew-1 X-Mimecast-MFC-AGG-ID: Z47GF9PKPDmpXbRS4qNeew_1772671110 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-439ca6a7506so958294f8f.3 for ; Wed, 04 Mar 2026 16:38:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772671110; x=1773275910; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tppJGlIkxoekDV817wyANNImacRRrxRVK5GJSuKUMEM=; b=key9Kw5adG1eZxvXnE7vajyfJ63eQQp4bXA+o+6o1WxMNF+jA4qdeDm3Dd/QdYdtG/ 6jRqywY/554fRUrUm2I96KU7uBKj7VphPyIuiS/RoEExK+85ECXSMqF6FM0zs+U3fvGc /c3JbF8mrqsb/36ZsouoU7ccGomSDQ++TCZJD3+lZDaMQBB74gR++BFU+AdTbah545Wc zAC2n5IZYfr9aO5JGavBQskE4YobxJVnhqlfC5CHOSgPTABcq/LjL1nSnmOOf5O2qHvP dlKc0lLZ6lNeblpx+Xmlh3s+XpUbJFOij/6ObkiqX5HlkIu5wkKVKmG/Vqk0PJqC05z/ lJ4Q== X-Gm-Message-State: AOJu0YzOY4lrR0KMnHBpmEM5QrVuprdNPLZW0JEmRA21wIletci6Mgie 3WdK11/zPYBSTVG0LAZyzbYV9viA6o6mtxjm4i40SYDn9mNX2E5B+kflP25PZXnTeQfwFmlm6VE xj4CNVyfxRsMnB6orqyGTrG8etmqCSSbLgTjQhSYDBuadsUaM77tbpQ== X-Gm-Gg: ATEYQzwxc9dyHVX9I/EGWO2fsuIpRK3RDY9EoQf6eeeR20stFPm00UW/RryY6q0o9NH i7tB3cAuoEB61GXvJPMK+cPLkYVUumqBejzcn+zz8XntLljfvC04l8Vdzp9gfoGogBJCC6CkUq7 VLwinA1+sJfeqa/oRKTVOWwcT/uApS4HGelL/DYIZ+61mIT5Aka2g1fEW8eRjuUVxai3rAUP1rN QzoBxwu0Y1HMlKEOtiMGjYYLdQAtro4c2wFBHh0KNBqUCfwMPM3tPIiV5CeOZXC4MJRk6jm6gKe oIYkfwoxs+eWEZgXRoHFfYJTQK6SmAA3oVsSaZzklKFO4GxxZM9VOSgxKq3GP6wzHDXYB7vza33 gL6gfDOnL4asv7S1yUzI8TkJ5dkF2mp2s X-Received: by 2002:a05:6000:4011:b0:439:afd8:622f with SMTP id ffacd0b85a97d-439c7f98010mr7529779f8f.3.1772671109611; Wed, 04 Mar 2026 16:38:29 -0800 (PST) X-Received: by 2002:a05:6000:4011:b0:439:afd8:622f with SMTP id ffacd0b85a97d-439c7f98010mr7529755f8f.3.1772671108998; Wed, 04 Mar 2026 16:38:28 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b55df68dsm27238991f8f.26.2026.03.04.16.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 16:38:28 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH v2] Add missing includes to headers Message-ID: <20260305013827.491003dc@elisabeth> In-Reply-To: <20260223181119.179746-1-pefoley@google.com> References: <20260223181119.179746-1-pefoley@google.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Thu, 05 Mar 2026 01:38:28 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rwRhdwpt-MrOzxkzl5Pl41wBuT5q2YMi84nYF2a-W3o_1772671110 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3RCYUC5BP4FR6IO7BDWE5CCYGZDRQDVL X-Message-ID-Hash: 3RCYUC5BP4FR6IO7BDWE5CCYGZDRQDVL X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 23 Feb 2026 13:11:19 -0500 Peter Foley wrote: > Support build systems like bazel that check that headers are > self-contained. > > Also update includes so that clang-include-cleaner succeeds. > > Tested with: > clang-include-cleaner-19 --extra-arg=-D_GNU_SOURCE --extra-arg=-DPAGE_SIZE=4096 --extra-arg=-DVERSION=\"git\" --extra-arg=-DHAS_GETRANDOM *.h *.c > > Signed-off-by: Peter Foley Tested some more (especially with musl), and applied, thanks. At this point, with David's series applied as well, things should build cleanly for you. -- Stefano