From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3] iov: Add iov_truncate() helper and use it in vu handlers
Date: Fri, 06 Mar 2026 12:01:37 +0100 (CET) [thread overview]
Message-ID: <20260306120136.2fa55241@elisabeth> (raw)
In-Reply-To: <f4ef9a02-36aa-43c5-be3d-658780388bbd@redhat.com>
On Fri, 6 Mar 2026 11:56:30 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
> On 3/6/26 11:52, Stefano Brivio wrote:
> >> This seems to fix the problem for me.
> >>
> >> Do you want a separate patch or to merge with this one?
> > A separate patch would be nice, so that I don't have to convert spaces
> > back to tabs myself, and I guess it might deserve a new review anyway...
>
> I'm not sure to understand...
>
> My question was in fact: do I merge the fix inside this patch or do I send two separate
> patches in a series (this one, keep v3, and another patch to fix the issue reported by
> coverity).
Oh gosh sorry, by separate patch I meant (not really obvious!) a single
v4 with everything, that can be reviewed stand-alone.
Even if the issue was not reported earlier but pre-existing (I'm not
sure), I think fixing it in the same patch that triggers the report
would be entirely reasonable.
I meant I wouldn't merge your subsequent changes while applying v3
myself.
--
Stefano
prev parent reply other threads:[~2026-03-06 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 12:56 Laurent Vivier
2026-03-06 0:05 ` David Gibson
2026-03-06 7:35 ` Stefano Brivio
2026-03-06 8:17 ` Laurent Vivier
2026-03-06 8:25 ` Stefano Brivio
2026-03-06 8:51 ` Laurent Vivier
2026-03-06 10:41 ` Laurent Vivier
2026-03-06 10:52 ` Stefano Brivio
2026-03-06 10:56 ` Laurent Vivier
2026-03-06 11:01 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306120136.2fa55241@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).