public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au,
	passt-dev@passt.top, Paul Holzinger <pholzing@redhat.com>
Subject: Re: [PATCH v3] netlink: Return prefix length for IPv6 addresses in nl_addr_get()
Date: Mon, 09 Mar 2026 23:11:24 +0100 (CET)	[thread overview]
Message-ID: <20260309231123.0ef586b2@elisabeth> (raw)
In-Reply-To: <20260309105606.20a31e16@elisabeth>

On Mon, 9 Mar 2026 10:56:06 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:

> [...]
>
> The reason why the original code skipped IPv6 link-local addresses and
> not IPv4 link-local ones is that copying a IPv6 link-local address
> clearly makes no sense and breaks things.
> 
> For IPv4 I wasn't quite sure, and it seemed to work just like other
> addresses, so I never took care of excluding them.
> 
> I tend to think it's correct to exclude them, also for consistency with
> IPv6, but I'm not quite sure if we risk breaking something. I have some
> vague recollection of link-local addresses being used in some cloud
> (probably Google Computing Platform), at least for some Podman tests.
> I'll try to find some pointers to it.

Paul found this, from a GCE environment used in Podman's CI:

https://api.cirrus-ci.com/v1/task/5902961064280064/logs/journal.log (look
for "Route IPv4 info"):

Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: +++++++++++++++++++++++++++++++Route IPv4 info++++++++++++++++++++++++++++++++
Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: +-------+-----------------+------------+-----------------+-----------+-------+
Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: | Route |   Destination   |  Gateway   |     Genmask     | Interface | Flags |
Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: +-------+-----------------+------------+-----------------+-----------+-------+
Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: |   0   |     0.0.0.0     | 10.128.0.1 |     0.0.0.0     |    ens4   |   UG  |
Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: |   1   |    10.128.0.1   |  0.0.0.0   | 255.255.255.255 |    ens4   |   UH  |
Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: |   2   | 169.254.169.254 | 10.128.0.1 | 255.255.255.255 |    ens4   |  UGH  |
Mar 09 16:58:37 cirrus-task-5902961064280064 cloud-init[573]: ci-info: +-------+-----------------+------------+-----------------+-----------+-------+

...so there's a route to a link-local address, because that happens to
be the DNS server. The host doesn't have a link-local IPv4 address
though, so nothing we would risk missing with this kind of change.

In any case, as agreed, better to leave that out as you did in v4,
because it's not a trivial task to exclude that we're going to break
something at this point.

-- 
Stefano


      parent reply	other threads:[~2026-03-09 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 18:41 Jon Maloy
2026-03-09  9:47 ` David Gibson
2026-03-09 17:58   ` Jon Maloy
2026-03-09  9:56 ` Stefano Brivio
2026-03-09 18:04   ` Jon Maloy
2026-03-10  1:54     ` David Gibson
2026-03-09 22:11   ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309231123.0ef586b2@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgibson@redhat.com \
    --cc=jmaloy@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).