From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, passt-dev@passt.top
Subject: Re: [PATCH v4] netlink: Return prefix length for IPv6 addresses in nl_addr_get()
Date: Tue, 10 Mar 2026 16:11:32 +0100 (CET) [thread overview]
Message-ID: <20260310161131.281332cf@elisabeth> (raw)
In-Reply-To: <20260309195233.2162459-1-jmaloy@redhat.com>
On Mon, 9 Mar 2026 15:52:33 -0400
Jon Maloy <jmaloy@redhat.com> wrote:
> nl_addr_get() was not setting the prefix_len output parameter for
> IPv6 addresses, only for IPv4. This meant callers always got 0 for
> IPv6, forcing them to use a hardcoded default (64).
>
> Fix by assigning *prefix_len even in the IPv6 case.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
>
> ---
> v2: - Simplified according to feedback from S. Brivio
> - Added test for AF_INET link local property
> v3: - Corrected claim about convention for IPv4 link local address
> scope in commit log.
> v4: - Reverted from the IPv4 link local exclusion change
Applied.
--
Stefano
prev parent reply other threads:[~2026-03-10 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 19:52 Jon Maloy
2026-03-10 1:24 ` David Gibson
2026-03-10 15:11 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310161131.281332cf@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).