From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GjhzrFmj; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id DC8BD5A026D for ; Tue, 10 Mar 2026 16:11:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773155498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dmQCST5AqxYQQ3CxP+AL8dgrQVD68HnF+zaAmLQ2e7c=; b=GjhzrFmje7S1goiQ/5dMGF45dCHW2pSVY+WdUTXtUxEuBFrkWXbUhQ89mbzX1gf6UuWqwT 8iEWMTdIgRFEwYWG5RuFxkOBAUFSnTmP1/XHaP5/VfUrlS+dMgyf2hKP0Q5ilqG4lbgPo3 RyLODsfAM4bxa8uyh23cFJ0g803LdGk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-Q4in5KNfN3uGyWaqFzyxlQ-1; Tue, 10 Mar 2026 11:11:37 -0400 X-MC-Unique: Q4in5KNfN3uGyWaqFzyxlQ-1 X-Mimecast-MFC-AGG-ID: Q4in5KNfN3uGyWaqFzyxlQ_1773155495 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48539bda3dcso22686555e9.2 for ; Tue, 10 Mar 2026 08:11:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773155494; x=1773760294; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dmQCST5AqxYQQ3CxP+AL8dgrQVD68HnF+zaAmLQ2e7c=; b=iWKZjU7Qfm1eBdiHlZUjEMzjcgNQJ7/liq2qjiOZSAGaYZPecHs4Oy4KLmFspOHBU9 gS7fqOD0C7Uh9T5kfKuA+tALCuRWzZLpLJDPkZ3GkvHg38mivLRxER5mXxQfU97fhjC4 UWXIGi/eECmMYjINY+AyKLtNfFJBeWUYW8zbLj10BlWs7zSeXRyS9h86Yr559LmoxKry n9eFjfJrrTJ0GOZXUH3sSKDiD6Ec3wLiC6onNN8BuYSM+KDTezYhe/ER3PAHuvuYMzC3 K9U2HgrMCkXGkxzsO+yinAHpm0X1dKWFhT44XNklvYlH76WWE5aHECl3q6FMSJVE4YPq vifA== X-Forwarded-Encrypted: i=1; AJvYcCXt1g5elsos9LdglHKa691yo9Be08QmyWSWLC2VcN8iVHrlNU+iKMaBFO6mZBZOwBnhVCxuSo55lNk=@passt.top X-Gm-Message-State: AOJu0Yxb4AD/15J0evcWMLp+Kzp9U4/1alibkgsS3AOucLmkhf0PJL5H ENP8sdWT3nm64WB3jV/MI2byLqOyVjdCX5eatvsJNiZU/j5D8pe45SrZZ8pi2h6mVjUEAczFeSw 4hPHZDgsWcOl7A3s2yOuA9dtOB86zRnRE1P/LWvEl8GhqsKPYFMavxcGUJ4YxnUEV X-Gm-Gg: ATEYQzyAaSGkuiwSR+PFvIWXvMfvaDct5+7SmwH28KV3nCjemHUd2xYULllvI/iqNun VIffXi1CNiAi1YnNYjpJS6SJUKLS4yqEKqnahgb13TcvkEVqzj3Vx8JX1i3hxVdf+GujAEtZ4Xn FPpxfjpLeu8pr8j6LCG7tn+Tr5LlEJN6mXZBQ4jayf1UJW41GlO/kKBCaKGI/jJwXOGH3ceTr7b uuc0gcfz1jg562GDpXleipN5naDpkj+V/hYBnD4ylfswRMCbz+sWB6G2kLywUjyxde/JGyhAczX w7F1JEvqospR8w00qpXxy5ViLn5MMucsL+00517+Vvd3G89lLWoYKwinqgsYDgDdaSib0MaK1Uk jDOksBmuOOIl82Nx4fZZcsFWONCKo09bh X-Received: by 2002:a05:600c:4752:b0:483:b505:9db7 with SMTP id 5b1f17b1804b1-48526976a4cmr228809265e9.32.1773155494524; Tue, 10 Mar 2026 08:11:34 -0700 (PDT) X-Received: by 2002:a05:600c:4752:b0:483:b505:9db7 with SMTP id 5b1f17b1804b1-48526976a4cmr228808685e9.32.1773155494072; Tue, 10 Mar 2026 08:11:34 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541b7f3cdsm92494775e9.14.2026.03.10.08.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 08:11:32 -0700 (PDT) From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v4] netlink: Return prefix length for IPv6 addresses in nl_addr_get() Message-ID: <20260310161131.281332cf@elisabeth> In-Reply-To: <20260309195233.2162459-1-jmaloy@redhat.com> References: <20260309195233.2162459-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 10 Mar 2026 16:11:32 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j24aVqPGnNstuG3ai5LgHrXywM8RnQAAXUQO9B4PEos_1773155495 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: FHCVD5MA53XBWO3D4MMVNZJFRM6SJI4J X-Message-ID-Hash: FHCVD5MA53XBWO3D4MMVNZJFRM6SJI4J X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: dgibson@redhat.com, david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 9 Mar 2026 15:52:33 -0400 Jon Maloy wrote: > nl_addr_get() was not setting the prefix_len output parameter for > IPv6 addresses, only for IPv4. This meant callers always got 0 for > IPv6, forcing them to use a hardcoded default (64). > > Fix by assigning *prefix_len even in the IPv6 case. > > Signed-off-by: Jon Maloy > > --- > v2: - Simplified according to feedback from S. Brivio > - Added test for AF_INET link local property > v3: - Corrected claim about convention for IPv4 link local address > scope in commit log. > v4: - Reverted from the IPv4 link local exclusion change Applied. -- Stefano