From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=dpOvzbCx; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id ED72A5A0269 for ; Wed, 11 Mar 2026 05:14:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1773202440; bh=oIX2BTKue3I7nz4jHeCjJ8TiCb/ioMg4iLpLaRdOj2A=; h=From:To:Cc:Subject:Date:From; b=dpOvzbCxRzd9Nu3iD2vxgSdL1HeitN/IWW8FCG6XkMFV8G2UKm9rOEqqsp1i/tG4j N+HRau9mRvt0bedE6FuMVpbcQtJYrXXsKqVDmsnKhll3gOC3sQqoVyIiDApI2ubG+M 4Q7JxDkn5T7XS79YMY+4OvVV8eV4zN1MMmqvdL5J91Lq1yXE13A4AQyQLMxIx62PK7 ETLLAl2zfFKr3xrBmdkHk3IoD5sISg0Oe8HwDhkNkIY9BO1rdQKqLR0Wck8ElgXELV 7ohFku4J9XBQkPF3W39cKJjRw1jCiBEq2jT2Vz/f9zvoNlIMqcsqfJjl6+RyDf8ixc vzVdbrBosLfPg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fVy6w2sDGz4wCY; Wed, 11 Mar 2026 15:14:00 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH] netlink: Allow NULL to be passed as addr parameter to nl_addr_get (again) Date: Wed, 11 Mar 2026 15:13:57 +1100 Message-ID: <20260311041357.2371853-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: E5DDDFS4IXKEFXHJTZ32B42GDKPABFPY X-Message-ID-Hash: E5DDDFS4IXKEFXHJTZ32B42GDKPABFPY X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A recent fix to nl_addr_get() unfortunately introduced a different problem. 251e676bd0bf removed a test if @addr was non-NULL. conf_ip6() relied on being able to pass NULL in order to update the link-local address without updating the main address (because it was already set by the user). This means that 'pasta -a 2001:db8::1' will SEGV. Reverse the incorrect part of the change to fix this. Fixes: 251e676bd0bf ("netlink: Return prefix length for IPv6 addresses in nl_addr_get()") Signed-off-by: David Gibson --- netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlink.c b/netlink.c index ee9a6b16..e07b47f4 100644 --- a/netlink.c +++ b/netlink.c @@ -788,7 +788,7 @@ int nl_addr_get(int s, unsigned int ifi, sa_family_t af, (af == AF_INET6 && rta->rta_type != IFA_ADDRESS)) continue; - if (ifa->ifa_prefixlen > prefix_max && + if (ifa->ifa_prefixlen > prefix_max && addr && (af == AF_INET || ifa->ifa_scope < RT_SCOPE_LINK)) { memcpy(addr, RTA_DATA(rta), RTA_PAYLOAD(rta)); -- 2.53.0