From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Jon Maloy <jmaloy@redhat.com>
Subject: Re: [PATCH] netlink: Allow NULL to be passed as addr parameter to nl_addr_get (again)
Date: Wed, 11 Mar 2026 22:12:26 +0100 (CET) [thread overview]
Message-ID: <20260311221225.4f3d3f8d@elisabeth> (raw)
In-Reply-To: <20260311041357.2371853-1-david@gibson.dropbear.id.au>
On Wed, 11 Mar 2026 15:13:57 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> A recent fix to nl_addr_get() unfortunately introduced a different problem.
> 251e676bd0bf removed a test if @addr was non-NULL. conf_ip6() relied on
> being able to pass NULL in order to update the link-local address without
> updating the main address (because it was already set by the user).
>
> This means that 'pasta -a 2001:db8::1' will SEGV. Reverse the incorrect
> part of the change to fix this.
Ouch, sorry. I totally misinterpreted the check on 'addr' (my own
check, by the way) and suggested to Jon that it could be skipped.
> Fixes: 251e676bd0bf ("netlink: Return prefix length for IPv6 addresses in nl_addr_get()")
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
prev parent reply other threads:[~2026-03-11 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 4:13 David Gibson
2026-03-11 21:12 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311221225.4f3d3f8d@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).