From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SO+L0sPf; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 868A85A0262 for ; Wed, 11 Mar 2026 22:12:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773263552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pzYosjd7LVd2l+A70qnhCl0nellLAWUOFKS9bvifRww=; b=SO+L0sPfwr2faFfWL3lhhCAGzym/MU9B6YkuyvqRHaNhvzMuZC7frl8Y00/Z7S5NXTM42k VepVmv/iHAsVytMABwBnETGp1TV+ScXZnr2VceuoUYvz7F+NBjqwBhlIDg08YD7VYSqZDF 5r7Amh0KHozPkYJkPqP7CrLFntEsjLc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-xvifyfDhOam8ZMNOz0hYSg-1; Wed, 11 Mar 2026 17:12:30 -0400 X-MC-Unique: xvifyfDhOam8ZMNOz0hYSg-1 X-Mimecast-MFC-AGG-ID: xvifyfDhOam8ZMNOz0hYSg_1773263549 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-483786a09b1so2236015e9.3 for ; Wed, 11 Mar 2026 14:12:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773263549; x=1773868349; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pzYosjd7LVd2l+A70qnhCl0nellLAWUOFKS9bvifRww=; b=GSJqQFvpdNM3kGdvlxNSszHWbtoqkqqluxZ3cwFFEPP73MGPvBXyMd/7XZD7zmj9Mk xg9Ciek74gtYxlaE6fAy959mOZTqFyRS2eGKIUGzxFGgGss+q8gi4xvUsLwYCFI5sqi4 v3IPA8oSoaHc2sHpKmQ7uVUdCB9jTr5nUqYu4kEjL2RgACWgE/GNaLRUlOZiD3VrONL8 clMslNJR3z9M4OykDcNCRauppwBOWnQGPfWrXInbzpuXAf5TwAKW3HbSzlBpKsIk2so+ dxO+MhoCPu/mahPkPMIrD/uWA2xcdgjuj5fNjsE94BuGUnlVmZ5M/djbbMA6tWEU7w8V ApMw== X-Gm-Message-State: AOJu0YzK4zOSsUAsc2Efb1iZKKk6fO31+WDuYdIvC3CNyfbpVjsxEhwy OG2yOUffSu6IRF8J3kURpMXwhumnYAPJWTn1850eAK/vIIG3/El7LdrJ/0vQnWizQ4lauV56qc6 jG0AqLycvSrIG7wOwcj/uqCXjnYmKGWbstsOiGM++LTxZ9jV/ErrWsw== X-Gm-Gg: ATEYQzzt72nINT+BzRr4pwq1g1GWtOASmm3ZMbWFHpduwWWHgFVy31Pn6zopOf9nQgX fXcMtxBfamIN85qqtO19Lmb+nycrrwtJ2cm5UgCzsx/v1+pOYhXGaTp4zjgv2Uifuk+hMH4ZdjX 1MuoKTxtOrtei3drIpwz10j523rzjeXGL+RvKWZ5IbrcrQ3uWKhdPQtghlQAdS2Vw93UdZUqhRk clI1r8JVDFKy4QFrDQf7+Nn+GjInUgaC3jnGFpFmEOvbJZEaUo+GKAJSF9eMc0LcdQi7Ym9/i2+ AaLFFmUjbiPMaYIIEksHN8x7LNhyIu86WNkPRuIgFpEvmQ1Yd/2msrj5i191ObGMtiJhM7bo+Al JCblO+3Ps4n1W6DW6GGDEjqa0+eziWXLT X-Received: by 2002:a05:600c:8b31:b0:485:3812:36da with SMTP id 5b1f17b1804b1-4854b0afc13mr69550535e9.9.1773263548940; Wed, 11 Mar 2026 14:12:28 -0700 (PDT) X-Received: by 2002:a05:600c:8b31:b0:485:3812:36da with SMTP id 5b1f17b1804b1-4854b0afc13mr69550105e9.9.1773263548407; Wed, 11 Mar 2026 14:12:28 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854ad5416bsm68228845e9.1.2026.03.11.14.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 14:12:27 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] netlink: Allow NULL to be passed as addr parameter to nl_addr_get (again) Message-ID: <20260311221225.4f3d3f8d@elisabeth> In-Reply-To: <20260311041357.2371853-1-david@gibson.dropbear.id.au> References: <20260311041357.2371853-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 11 Mar 2026 22:12:26 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QfDE-pr05K2KcnU36VhJritpvnx_DTD4u5Bb3uM_-TE_1773263549 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QCBJ4I3TQ2OQRYVLRO7I3UAT5DEPLKTL X-Message-ID-Hash: QCBJ4I3TQ2OQRYVLRO7I3UAT5DEPLKTL X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 11 Mar 2026 15:13:57 +1100 David Gibson wrote: > A recent fix to nl_addr_get() unfortunately introduced a different problem. > 251e676bd0bf removed a test if @addr was non-NULL. conf_ip6() relied on > being able to pass NULL in order to update the link-local address without > updating the main address (because it was already set by the user). > > This means that 'pasta -a 2001:db8::1' will SEGV. Reverse the incorrect > part of the change to fix this. Ouch, sorry. I totally misinterpreted the check on 'addr' (my own check, by the way) and suggested to Jon that it could be skipped. > Fixes: 251e676bd0bf ("netlink: Return prefix length for IPv6 addresses in nl_addr_get()") > Signed-off-by: David Gibson Applied. -- Stefano