public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH 2/3] vu_handle_tx: Pass actual remaining out_sg capacity to vu_queue_pop()
Date: Fri, 13 Mar 2026 08:21:35 +0100	[thread overview]
Message-ID: <20260313072136.4075535-3-lvivier@redhat.com> (raw)
In-Reply-To: <20260313072136.4075535-1-lvivier@redhat.com>

In vu_handle_tx(), pass the actual remaining iovec capacity
(ARRAY_SIZE(out_sg) - out_sg_count) to vu_queue_pop() rather than a
fixed VU_MAX_TX_BUFFER_NB.

This enables dynamic allocation of iovec entries to each element rather
than reserving a fixed number of slots per descriptor.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 vu_common.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/vu_common.c b/vu_common.c
index 4d809ac38a4b..ed0033d6bb11 100644
--- a/vu_common.c
+++ b/vu_common.c
@@ -20,8 +20,6 @@
 #include "migrate.h"
 #include "epoll_ctl.h"
 
-#define VU_MAX_TX_BUFFER_NB	2
-
 /**
  * vu_packet_check_range() - Check if a given memory zone is contained in
  * 			     a mapped guest memory region
@@ -177,13 +175,14 @@ static void vu_handle_tx(struct vu_dev *vdev, int index,
 
 	count = 0;
 	out_sg_count = 0;
-	while (count < VIRTQUEUE_MAX_SIZE &&
-	       out_sg_count + VU_MAX_TX_BUFFER_NB <= VIRTQUEUE_MAX_SIZE) {
-		int ret;
+	while (count < ARRAY_SIZE(elem) &&
+	       out_sg_count < ARRAY_SIZE(out_sg)) {
 		struct iov_tail data;
+		int ret;
 
 		ret = vu_queue_pop(vdev, vq, &elem[count], NULL, 0,
-				   &out_sg[out_sg_count], VU_MAX_TX_BUFFER_NB);
+				   &out_sg[out_sg_count],
+				   ARRAY_SIZE(out_sg) - out_sg_count);
 		if (ret < 0)
 			break;
 		out_sg_count += elem[count].out_num;
-- 
2.53.0


  parent reply	other threads:[~2026-03-13  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  7:21 [PATCH 0/3] Decouple iovec management from virtqueue elements Laurent Vivier
2026-03-13  7:21 ` [PATCH 1/3] virtio: Pass iovec arrays as separate parameters to vu_queue_pop() Laurent Vivier
2026-03-13  7:21 ` Laurent Vivier [this message]
2026-03-13  7:21 ` [PATCH 3/3] vu_common: Move iovec management into vu_collect() Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260313072136.4075535-3-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).