From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH trivial 3/3] tcp_vu: Remove redundant th->doff and th->ack in tcp_vu_send_flag()
Date: Fri, 20 Mar 2026 14:51:16 +0100 [thread overview]
Message-ID: <20260320135116.575416-4-lvivier@redhat.com> (raw)
In-Reply-To: <20260320135116.575416-1-lvivier@redhat.com>
tcp_prepare_flags() unconditionally sets th->doff and th->ack, so
setting them right after the memset() is redundant.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tcp_vu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tcp_vu.c b/tcp_vu.c
index 9c4e916b1b8d..7a348eb01248 100644
--- a/tcp_vu.c
+++ b/tcp_vu.c
@@ -115,8 +115,6 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags)
}
memset(th, 0, sizeof(*th));
- th->doff = sizeof(*th) / 4;
- th->ack = 1;
seq = conn->seq_to_tap;
opts = (struct tcp_syn_opts *)(th + 1);
--
2.53.0
prev parent reply other threads:[~2026-03-20 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 13:51 [PATCH trivial 0/3] tcp_vu: Remove redundant header field assignments Laurent Vivier
2026-03-20 13:51 ` [PATCH trivial 1/3] tcp_vu: Remove redundant eh->h_proto assignments Laurent Vivier
2026-03-20 13:51 ` [PATCH trivial 2/3] tcp_vu: Remove redundant eh->h_source assignment in tcp_vu_send_flag() Laurent Vivier
2026-03-20 13:51 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320135116.575416-4-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).