From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Oega35xJ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 5BD925A0262 for ; Fri, 20 Mar 2026 21:58:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774040325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EtZ/iLj81j6cv9gWSxiB5m/PF05mC+9j5KTF+JzrANc=; b=Oega35xJfzwawrvk6v/FEMkLNol+fKGgKd6s4upRFbFsZd6XNrCWsPji/SjDsW6UIGI7b4 nmbOxNH2vbXybduQQr38ddFW0xOHYX9J/OsZDqjLgMEnUXCs+EZ9YNI+0LUD4ffA9vgygs qgSt4jr2IgvuSwMpAIKgUcjCERs2vSA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-pBsq7L1fOcGelNTvPVBerQ-1; Fri, 20 Mar 2026 16:58:43 -0400 X-MC-Unique: pBsq7L1fOcGelNTvPVBerQ-1 X-Mimecast-MFC-AGG-ID: pBsq7L1fOcGelNTvPVBerQ_1774040323 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso8681325e9.1 for ; Fri, 20 Mar 2026 13:58:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774040323; x=1774645123; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EtZ/iLj81j6cv9gWSxiB5m/PF05mC+9j5KTF+JzrANc=; b=MfzHz8qejFOdXZta91Tc+ZPQ8jfxsbJmn/Cjxk4KqJHACkOpaM493HFCSmffwvY/sU ZXLt+YXcy52AsckysQ27CvP7dUWB75R6NPdYXsscpArA6fbejpWthbDRg5qHBZe3qrqv u0BuE9gZqCLxza0bU6Ad5vJxefQyXas8nlylNlunCeBkeS2aoyAJvqVaEPGfW7ozhLHE 4OBjV9b+oVNSJza776nRfxmO5A/NjgalllPT0cTWYFOWEGtdjmBwHOnmzyx3ySTidwR+ +D0k6xfo0JSv2hJnVqzNvaZnHVqs+0KEZb3tc1hNyrM3w51i26YlhbZS2aBQBrB9eFBH vGWQ== X-Gm-Message-State: AOJu0YwRGjy3A1HRE8qIEJVEf7xTLG64DIQcdaK/YoAH8ll2yMLG7/iy Flujp39b8/HtjmMeeCi4xcJo8+sHUsl7sSqEQdq3xX32B+/pxlYwhCL1RW8VH/wwEnwUHrR+cze ePYDqNUkHsEFzSzffibflQoV3UwXbHgH6CMlI1Lz6QNJnIXl4KSegMg== X-Gm-Gg: ATEYQzwWUJ+7VBV4r7Z3f7H9swzxr4rTm/tGacULY/vpuyz1WZCxKJa+ckjO+jD4ziV nX9a+UwnmbY8GLE91XTSTLcnjgfHd5m2WWKym4JIIyab9dR8I0slriD01k8b0BcatCciLuqs6Ly yoPpU7SRUcEsMKN5JhT+d3F/TaT+PjxQBle+2EwrChZSH2hgyJNm4RG86FqGSgdGQ8VIomWYpDU M4wjUgK4m+HpYGQ8fJd5FsEr+/D21gWr/CufleIogpIs+6Z0/C7GTuIAG1dI1Pz/SPHzFksG6sm gHF6u7vKTkqNVDiUSYKocoa3hKufrGk9h7Q1zZLT1RUMWvYTF92qdXO4TViIFzzKD4cYVuphKOP YV6Y343xdIMq7VmuV0xfZkT/1Ao7wnnua X-Received: by 2002:a05:6000:2502:b0:43b:4989:869d with SMTP id ffacd0b85a97d-43b64263f27mr7709630f8f.33.1774040322584; Fri, 20 Mar 2026 13:58:42 -0700 (PDT) X-Received: by 2002:a05:6000:2502:b0:43b:4989:869d with SMTP id ffacd0b85a97d-43b64263f27mr7709616f8f.33.1774040322133; Fri, 20 Mar 2026 13:58:42 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470c239sm8816829f8f.27.2026.03.20.13.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 13:58:41 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 01/15] treewide: Spell ASSERT() as assert() Message-ID: <20260320215840.155c9f87@elisabeth> In-Reply-To: <20260319061157.1983818-2-david@gibson.dropbear.id.au> References: <20260319061157.1983818-1-david@gibson.dropbear.id.au> <20260319061157.1983818-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 20 Mar 2026 21:58:41 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cXcMdN-sdH93vyFViu22YvLO_sC-7JtogMF8bV1sU5M_1774040323 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 76FFH4SAET4CQJUNO4TP6XR6K5HRJG5J X-Message-ID-Hash: 76FFH4SAET4CQJUNO4TP6XR6K5HRJG5J X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 19 Mar 2026 17:11:43 +1100 David Gibson wrote: > The standard library assert(3), at least with glibc, hits our seccomp > filter and dies with SIGSYS before it's able to print a message, making it > near useless. Therefore, since 7a8ed9459dfe ("Make assertions actually > useful") we've instead used our own implementation, named ASSERT(). > > This makes our code look slightly odd though - ASSERT() has the same > overall effect as assert(), it's just a different implementation. More > importantly this makes it awkward to share code between passt/pasta proper > and things that compile in a more typical environment. We're going to want > that for our upcoming dynamic configuration tool. > > Address this by overriding the standard library's assert() implementation > with our own, instead of giving ours its own name. > > The standard assert() is supposed to be omitted if NDEBUG is defined, > which ours doesn't do. Implement that as well, so ours doesn't > unexpectedly differ. For the -DNDEBUG case we do this by *not* overriding > assert(), since it will be a no-op anyway. This requires a few places to > add a #include to let us compile (albeit with warnings) when > -DNDEBUG. > > Signed-off-by: David Gibson Applied (just this patch). I fixed up some (expected) trivial conflicts in tcp_vu.c and udp_vu.c with "vu_common: Move iovec management into vu_collect()". -- Stefano