From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=acUe0+ud; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 974F15A0265 for ; Wed, 25 Mar 2026 01:54:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774400078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J8Wggl5tDhrbZS8kgA4wVlQmza0vDDFuFTDyN2TZfgk=; b=acUe0+udUNzPBEBpQcxID0LQXNPPXxZdU3kpl5rYjz+xncVCcDKZZ9eSZkznRkGARvW1bF RyNg8DHshI+gAjb5a0yq44cdreSrJIJcaNfCHPKmB+HfacOvo5cTeoSQuED2OhgsXC5fGJ PJkLHt1+5ySluEMqDfQsagnR9XYGThc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-Zj4T96YGN4ybi5AZas9jig-1; Tue, 24 Mar 2026 20:54:36 -0400 X-MC-Unique: Zj4T96YGN4ybi5AZas9jig-1 X-Mimecast-MFC-AGG-ID: Zj4T96YGN4ybi5AZas9jig_1774400076 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48535f4d5e1so22635335e9.0 for ; Tue, 24 Mar 2026 17:54:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774400075; x=1775004875; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J8Wggl5tDhrbZS8kgA4wVlQmza0vDDFuFTDyN2TZfgk=; b=NG8XXl9SJzZjGAFd6njvwLlwo42hLJvffYNO6WcBQJ7FM4Znne4cAAi385il1b781A F2A7LADpNLwM4dJU4sdKSlIiY5EfifR9MN+t7QghSl4D5M9n82C74coFCTu5DVi7oLqg HshQ5Hqa1OKP0sBXWI04pJYINwmITwVxGrMKGp4tUEU2i/eGLRLLsOXV82ea/MbvPYiv BiPg+5zufaux0L2SbmVz8gvzFFrgzZs7OOpYAQKBPdxufWYL6Or7Ih0xW5MEUrjmzMy4 9+7+OL8LtfkJs/5YWK8zCPLb0Pg/xcJAVPPrpBdO9Q0iYYq3LKs5R3ZdexAYRj3DybaY AWQg== X-Gm-Message-State: AOJu0YwotBkMNRwDQ4szyncyUM3Khwgd6YmbL2SGjdMnDpREI7cNuCG2 UTm9k6fDuUyvrLkK9dXZDzIeU2dSTJ5yRVyfCAtxWuwHYLbErXW+AZckTmPc/PIsog9QJORqAad Yc7KltG2YIdCC/TH0NnFjDTSASSNqJmgjpVcZ94aahiK+od7u9KI8DkTtYQ0joBW8 X-Gm-Gg: ATEYQzzJPofpOiU0uNPWWFPS53YWltzvJcePxDa5LhP0RFkk9KNQVKdg0eQQwHXijjy uRqU9G/ksyop8aItsKzxsWrsphuP8MNw1xsu5YTWN4kPDh3WsP4Y9cwrfIwqwo6XtBgkbwhp48J d6xdvlSlt6ouWnVN22xqUTdtTsJvpwIjKaG8KS3Ux03bXPOYneMmDG19HJ809ypcpJOwix85fa1 tSiWq7wvP3i62O9+83lmqng8urMxlNR5F9plO/C1RDkdZYBBcIbqlga3TlzGJHt7eEreOrvYGDC PK5Mp347/nr+9FAe4dePHv/nOxI87SkaVDn/Ufyyr3vhmpLZTevdAZONfPYpi9qSCm+YvcfgG3U iLGv2Wh6MHKo6/TcOxQUwAT1elX2C2cSP X-Received: by 2002:a05:600c:45d5:b0:485:3b34:2f62 with SMTP id 5b1f17b1804b1-48715fead8bmr23931875e9.14.1774400074716; Tue, 24 Mar 2026 17:54:34 -0700 (PDT) X-Received: by 2002:a05:600c:45d5:b0:485:3b34:2f62 with SMTP id 5b1f17b1804b1-48715fead8bmr23931545e9.14.1774400074171; Tue, 24 Mar 2026 17:54:34 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487116939b8sm136396905e9.3.2026.03.24.17.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 17:54:33 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 08/25] fwd: Allow FWD_DUAL_STACK_ANY flag to be passed directly to fwd_rule_add() Message-ID: <20260325015432.365f9a6b@elisabeth> In-Reply-To: <20260323073732.3158468-9-david@gibson.dropbear.id.au> References: <20260323073732.3158468-1-david@gibson.dropbear.id.au> <20260323073732.3158468-9-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 25 Mar 2026 01:54:33 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oI07IMU_p0MT5A0L0gp_XQ_V5Ra8qZwPsExSxAM00RE_1774400076 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GZX26BIIOXYVADG5L6VDN4PTWMKMA7AW X-Message-ID-Hash: GZX26BIIOXYVADG5L6VDN4PTWMKMA7AW X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Nits: On Mon, 23 Mar 2026 18:37:15 +1100 David Gibson wrote: > fwd_rule_add() takes a flags parameter, but it only allows the FWD_WEAK > and FWD_SCAN flags to be specified there. It doesn't allow the > FWD_DUAL_STACK_ANY flag to be set, instead expecting a [*] address to be > indicated by passing NULL as @addr. > > However, for upcoming dynamic rule updates, it's more convenient to be able > to explicitly pass FWD_DUAL_STACK_ANY along with an address of ::. Allow > that mode of calling. > > Signed-off-by: David Gibson > --- > fwd.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fwd.c b/fwd.c > index 3395a28e..d73b7ca7 100644 > --- a/fwd.c > +++ b/fwd.c > @@ -362,18 +362,21 @@ void fwd_rule_add(struct fwd_table *fwd, uint8_t proto, uint8_t flags, > in_port_t first, in_port_t last, in_port_t to) > { > /* Flags which can be set from the caller */ > - const uint8_t allowed_flags = FWD_WEAK | FWD_SCAN; > + const uint8_t allowed_flags = FWD_WEAK | FWD_SCAN | FWD_DUAL_STACK_ANY; > unsigned num = (unsigned)last - first + 1; > struct fwd_rule *new; > unsigned i, port; > > assert(!(flags & ~allowed_flags)); > - Spurious change, I think? The extra newline here looks good for readability. Maybe we should group the second assert with this one? > if (fwd->count >= ARRAY_SIZE(fwd->rules)) > die("Too many port forwarding ranges"); > if ((fwd->sock_count + num) > ARRAY_SIZE(fwd->socks)) > die("Too many listening sockets"); > > + /* Passing a non-wildcard address with DUAL_STACK_ANY is a bug */ Extra whitespace after DUAL_STACK_ANY. > + assert(!(flags & FWD_DUAL_STACK_ANY) || !addr || > + inany_equals(addr, &inany_any6)); > + > /* Check for any conflicting entries */ > for (i = 0; i < fwd->count; i++) { > char newstr[INANY_ADDRSTRLEN], rulestr[INANY_ADDRSTRLEN]; -- Stefano