From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=L8sSdZzh; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 69B6B5A061A for ; Fri, 27 Mar 2026 05:34:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1774586072; bh=O7ouTz7SyqKnB86Q2Zgwc0k8IF4IjmfMLnAssjR94Qg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L8sSdZzhyc+uAb+8e0Vwu8EXZY37RN0d7zbCDtjnb1+Uy+LRAYRGyhH8/OD5LEl1H iv6T4XrBNj0Kkv5ucS4gf7Lviky7vGq9JOs+aO/PinGTwpfPXbTpqqtqgOvqwg2zAb PLMJmTpoktAyhT9IzlGTs+RzF+e4gByN/qqPoVptbbIAPOZ+FTiCSY6cRhRuua1qVi WSBx0iGXqMy4oC+u/3wiD1ZeeM1zQIzOpehHGCT9BRGBACfhJemnHAxhMMFkLGPEmM HrID+tfXvbWIEiAWEeuJccnUBtkdAUlUtVGogATgSTWT9JLYsCADenO05CFbwt6xiu IGPr1T8U6EDqg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fhnqD5zTzz4wT9; Fri, 27 Mar 2026 15:34:32 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 14/18] conf: Remove redundant warning when SO_BINDTODEVICE is unavailable Date: Fri, 27 Mar 2026 15:34:26 +1100 Message-ID: <20260327043430.1785787-15-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260327043430.1785787-1-david@gibson.dropbear.id.au> References: <20260327043430.1785787-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: HCQJBY6FVEZDWU4T2KBMSGAUYLEIWIPM X-Message-ID-Hash: HCQJBY6FVEZDWU4T2KBMSGAUYLEIWIPM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: conf_ports() has logic to warn if -[TU] auto is specified but we can't use SO_BINDTODEVICE. However, this is redundant with similar logic in conf_ports_range_except(). The latter will be triggered both for an explicit -[TU] auto and when it's invoked as a default option, so keep that one and drop the one in conf_ports(). Signed-off-by: David Gibson --- conf.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/conf.c b/conf.c index d4c2a013..5639ef03 100644 --- a/conf.c +++ b/conf.c @@ -249,12 +249,6 @@ static void conf_ports(const struct ctx *c, char optname, const char *optarg, if (c->mode != MODE_PASTA) die("'auto' port forwarding is only allowed for pasta"); - if ((optname == 'T' || optname == 'U') && c->no_bindtodevice) { - warn( -"'-%c auto' enabled without unprivileged SO_BINDTODEVICE", optname); - warn( -"Forwarding from addresses other than 127.0.0.1 will not work"); - } *mode = FWD_MODE_AUTO; return; } -- 2.53.0