Re: [PATCH v2] tap, tcp, udp: Use rate-limited logging

[Stefano Brivio <sbrivio@redhat.com>]

On Mon,  6 Apr 2026 13:35:56 +0530
Anshu Kumari <anskuma@redhat.com> wrote:

> Now that rate-limited logging macros are available, promote several
> debug messages to higher severity levels.  These messages were
> previously kept at debug to prevent guests from flooding host
> logs, but with rate limiting they can safely be made visible in
> normal operation.
> 
> In tap.c, refactor tap4_is_fragment() to use warn_ratelimit() instead
> of its ad-hoc rate limiting, and promote the guest MAC address change
> message to info level.
> 
> In tcp.c, promote the invalid TCP SYN endpoint message to warn level.
> 
> In udp.c and udp_flow.c, promote flow allocation failures and dropped
> datagram messages to warn level, and rate-limit the unrecoverable
> socket error message.
> 
> Link: https://bugs.passt.top/show_bug.cgi?id=134
> Signed-off-by: Anshu Kumari <anskuma@redhat.com>
> ---
> v2:
>   - removed #define FRAGMENT_MSG_RATE
>   - fixed the indentation for "Invalid endpoint in TCP SYN" log.

Sorry, I replied to v1 a couple minutes before getting your v2. Note
that you didn't really address some of the pending comments (about
indentation), see my reply for more details.

I would suggest anyway to wait one day or so before posting a new
version, thanks.

-- 
Stefano