From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fyloIKT5; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 13D865A0262 for ; Mon, 06 Apr 2026 10:17:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775463419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eX1VUM4R3UCe051/PIEHhFhNxiueE/D2uNtY3bMIqcU=; b=fyloIKT5/BvakPMslUMyUGvZyDdmPXAY9RVmIeF7gLdLS0554gKddrvRK79o2hiQjIrYxb UUKhsD6OfJNb8T7H4iXwHmJQE0/aSfmVxsyj7LENP7serUQowe3brBAWVLwVWkpQ70aTQ9 f/AjoqkxvNYpvJ47ZjF3SWHc/da6YOY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-pBc4My_zNia-WIiLKVtahQ-1; Mon, 06 Apr 2026 04:16:58 -0400 X-MC-Unique: pBc4My_zNia-WIiLKVtahQ-1 X-Mimecast-MFC-AGG-ID: pBc4My_zNia-WIiLKVtahQ_1775463418 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4836abfc742so32571345e9.0 for ; Mon, 06 Apr 2026 01:16:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775463417; x=1776068217; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eX1VUM4R3UCe051/PIEHhFhNxiueE/D2uNtY3bMIqcU=; b=AJEODjT6EygCeQEpLS33SGp5/PdCTuBwKY8FBxY22A/pK1nB87t2bD6kZDJ4xe+N1O dgJo05XDPg9HE9kakr/Ukq7qxtLC8jVS8m7wWzL+7rh/TSYePBXzZPjNYnrMmHNfuMn/ PFsU4n91bnUKjttO2rlVdy+j/O0y7bsi0oRhBaB6HLillLAJqu6X7NToE8gfKJSiraJq 85oFzVCMM/P5xOJ3mI5h+bCMXFVrBLUaxQVpsKajZZ2xvYn9YynXC+4RF1ERIaDz5ofI OMtoFKMkWKq+r6DN/4NGweau0vFTl7SRmnSxB3iwYKVTMkUowkXFJzcz6ayAh+r8rKj6 IAmg== X-Gm-Message-State: AOJu0Yxk9WsaKmdk+ETQ5UF3PB97aFJ1jk7TtE2EiUNDR/Z5K6dz51Rv S+Fzr28QVMcT40tDLsqcU+L2Y64DK8CHdT0K1HiRcpzuuvP2jY3zKEp4fwmoGE5etEylvccgnrA a4+rT/EyVBQP/hvhET+BQCcjTEMvAYky/HkFzrVen0PbqwtNbQkpmZA== X-Gm-Gg: AeBDiev70EaI84mCQdb6YOwWk74oSjwMBwq31NB3gSCpc8gHlGLwSeAqDinmn1zQz/5 Dv8krqkDN8SmAyYabbQtI34A8IJ8GRFdj1AEWvE8RnY4Dmt35EbCz0LPQL8NeYJOx753sBASBKp Me7qN77QjIX4iK6TPWUxZiSZRFhpC1ldI02y1iMBD7c1I3t+0LcT+1ZISSFcIJ0836CTbxCc9eB bXFv8BIGbBTGfj7C93DOutRhL8dKktjxhp+zUCQzFr4ovpTrOqTHW+iZuLgOAQf7ULB7h4hvHwn oU4+PwhwcnZm05Hs1maVzivVFOcYeSm+RJRhewQVyb2VMm9UktjRIlLHBLYEn1TuvH4vw0shkqn gRJqORWU1LvE8YyoxBLC4kjA89kdeX42VzDekWU46WRhx3T170A== X-Received: by 2002:a05:600c:1d1d:b0:488:7ebd:78 with SMTP id 5b1f17b1804b1-4889977cbb7mr166428605e9.14.1775463417486; Mon, 06 Apr 2026 01:16:57 -0700 (PDT) X-Received: by 2002:a05:600c:1d1d:b0:488:7ebd:78 with SMTP id 5b1f17b1804b1-4889977cbb7mr166428205e9.14.1775463416993; Mon, 06 Apr 2026 01:16:56 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e83e906sm529778805e9.8.2026.04.06.01.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 01:16:56 -0700 (PDT) From: Stefano Brivio To: Anshu Kumari Subject: Re: [PATCH v2] tap, tcp, udp: Use rate-limited logging Message-ID: <20260406101655.376a7b13@elisabeth> In-Reply-To: <20260406080557.858577-1-anskuma@redhat.com> References: <20260406080557.858577-1-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Mon, 06 Apr 2026 10:16:56 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5ssRw-SlnWfS-Ri1bPtG289fiz3373-2rly5fOod-IM_1775463418 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 6O4DRNFWCSQ52LOQAGCOVPI5VLJVGDSC X-Message-ID-Hash: 6O4DRNFWCSQ52LOQAGCOVPI5VLJVGDSC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 6 Apr 2026 13:35:56 +0530 Anshu Kumari wrote: > Now that rate-limited logging macros are available, promote several > debug messages to higher severity levels. These messages were > previously kept at debug to prevent guests from flooding host > logs, but with rate limiting they can safely be made visible in > normal operation. > > In tap.c, refactor tap4_is_fragment() to use warn_ratelimit() instead > of its ad-hoc rate limiting, and promote the guest MAC address change > message to info level. > > In tcp.c, promote the invalid TCP SYN endpoint message to warn level. > > In udp.c and udp_flow.c, promote flow allocation failures and dropped > datagram messages to warn level, and rate-limit the unrecoverable > socket error message. > > Link: https://bugs.passt.top/show_bug.cgi?id=134 > Signed-off-by: Anshu Kumari > --- > v2: > - removed #define FRAGMENT_MSG_RATE > - fixed the indentation for "Invalid endpoint in TCP SYN" log. Sorry, I replied to v1 a couple minutes before getting your v2. Note that you didn't really address some of the pending comments (about indentation), see my reply for more details. I would suggest anyway to wait one day or so before posting a new version, thanks. -- Stefano