Re: [PATCH 14/18] conf: Rework checking for garbage after a range

David Gibson
2026-04-09T00:48:05Z

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

On Wed, Apr 08, 2026 at 11:40:27PM +0200, Stefano Brivio wrote:
> On Tue, 7 Apr 2026 13:16:26 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > After parsing port ranges conf_ports_spec() checks if we've reached a
> > chunk delimiter (',') to verify that there isn't extra garbage there.
> > Rework how we do this to use the recently introduces chunk-end pointer.
>
> Nit: introduced
>
> > This has two advantages:
> >
> > 1) Small, but practical: we don't need to repeat what the valid delimiters
> > are, that's already handled in the chunk splitting code.
> >
> > 2) Large, if theoretical: this will also given an error if port parsing
> > overruns a chunk boundary. We don't really expect that to happen, but
> > it would give very confusing behaviour if it did. strtoul(3), on which
> > parse_port_range() is based does say it may accept thousands separators
> > based on locale which means can't entirely be sure it will only accept
>
> Nit: we can't

Both fixed. Plus a few more errors fixed and some edits for brevity.

--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]