Re: [PATCH 11/18] fwd: Improve error handling in fwd_rule_add()

David Gibson
2026-04-09T00:48:05Z

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Wed, Apr 08, 2026 at 11:40:07PM +0200, Stefano Brivio wrote:
> On Tue, 7 Apr 2026 13:16:23 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > fwd_rule_add() sanity checks the given rule, however all errors are fatal:
> > either they're assert()s in the case of things that callers should have
> > already verified, or die()s if we run out of space for the new rule.
> >
> > This won't suffice any more when we allow rule updates from a configuraiton
>
> Nit, as I guess you'll respin: configuration.

Oops, fixed.

>
> --
> Stefano
>

--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]