From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BqXXL2xP; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 315A95A0265 for ; Wed, 08 Apr 2026 23:40:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775684412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YTIRmVJjr0cKdp3JQQeDtfUkm95ofylhRL8UtFjFzB0=; b=BqXXL2xPSwNHvmFj3WlsewO/ntCO+qcUZ3G+AWSE6zXm7fHTBoejzJvY/F2+W+RxsEYb1i qnWo7PcY7UaQ0kw2k2PJsxxDAoxfbUjzbVFtKWVVnfKqRiJh/EWlN1Adch+m5CKRhe9ONT JTN/Pysq9BCK7NsnijHIgTwDlgK9xDg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-Q3nbkhrSPJaIy6jsv8w4Sg-1; Wed, 08 Apr 2026 17:40:11 -0400 X-MC-Unique: Q3nbkhrSPJaIy6jsv8w4Sg-1 X-Mimecast-MFC-AGG-ID: Q3nbkhrSPJaIy6jsv8w4Sg_1775684410 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4836abfc742so976045e9.0 for ; Wed, 08 Apr 2026 14:40:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775684409; x=1776289209; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YTIRmVJjr0cKdp3JQQeDtfUkm95ofylhRL8UtFjFzB0=; b=m1TKo5eEXFjCE9mST0a6xzxBWcHJz0m+A83mdssi5oqZIwRvjb5Ri0+uq07cygXWw7 cibu3HQKLcECpK6OQhTPlB8DISC4ttSdVLpq6gdcJOhV3wo9kQdA4Nv97OM3QH75voGk aQReYEuBCCO4PBgSPVZ9eiyj+lfK/4f1BSsFx36NIGTrVLFYjVUvL1D7PYXtZJbhjbD3 wXr98VaL7kXKJe2yXrsIbhWwwt2MBjAjXFAHuSWoTyHvGMYDqYndc1XkN8/gVqoDYNsG ZbaxbiFXEAx/O9LcZlwII1Z3mN2RFBfnzcrg/BSDYyN8jYrorouFVmpehravKoQWii9Q pDYA== X-Gm-Message-State: AOJu0YzSZXcJPAtoLBb9NYA5IwD5damQrNG5DKt4yOknXKMXTAypsBl4 noVtxv/nf1mE5U4uM7a+Sc+DA+haIUCzS4N3rIQE5DaoKitNRqIwq/mk/NrikUGkuZRX4H/1ZwQ AlAsDesN2foXRylD7Az406ZgjqpplEAkWfMV+V2ugYvj3c59T20aKTmPjqzY71Q== X-Gm-Gg: AeBDievU2orMBtpIOy1hNcW+p2Hrpw7/cBWZJ8p4H8NhU/j78ke25tcrhRm1bV9zP4g mQzgEJ/Qvfu/XS+dx/A4bIPfQJLDV39tr43CMsqNR9jPQ1Op8D+0i2mCyT1AEvCaNS9V13O5kcX MCSiZlS2tRo7ypu6De71YDpCKw5kAa0xv1/AibMNZefM12qqxNhkyYHceMH7P7PRV4b+Aabuhja 5NGE00eu5JaNJihOqIivsLDF+olrgfp5GxIMSNohqsxUKTnUqjVT2pOJwLpZe3BoVlM5Kf83iMR boQ1I1cNfCqOijOsbP1FJcAA6p7q2CiOoB0k+Iynk3IcE05emyCE2nHDXBCB49eWHChaG2FXSGo 8AKrBBkS7bAWVx9afBz1534nz8XM+yLoE X-Received: by 2002:a05:600c:8b0a:b0:488:a2ac:a337 with SMTP id 5b1f17b1804b1-488ccffa903mr18149145e9.21.1775684409101; Wed, 08 Apr 2026 14:40:09 -0700 (PDT) X-Received: by 2002:a05:600c:8b0a:b0:488:a2ac:a337 with SMTP id 5b1f17b1804b1-488ccffa903mr18148955e9.21.1775684408682; Wed, 08 Apr 2026 14:40:08 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cf9f3e4fsm1512635e9.7.2026.04.08.14.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 14:40:07 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 11/18] fwd: Improve error handling in fwd_rule_add() Message-ID: <20260408234006.45f6365e@elisabeth> In-Reply-To: <20260407031630.2457081-12-david@gibson.dropbear.id.au> References: <20260407031630.2457081-1-david@gibson.dropbear.id.au> <20260407031630.2457081-12-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 08 Apr 2026 23:40:07 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qxSbfH8Ysv69hfSDE3xaBYCEK2DOR1ZDxyjN3gB8pPk_1775684410 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GKONQBNSGLHDT4UY7QTXO3F63XA2QXNX X-Message-ID-Hash: GKONQBNSGLHDT4UY7QTXO3F63XA2QXNX X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 7 Apr 2026 13:16:23 +1000 David Gibson wrote: > fwd_rule_add() sanity checks the given rule, however all errors are fatal: > either they're assert()s in the case of things that callers should have > already verified, or die()s if we run out of space for the new rule. > > This won't suffice any more when we allow rule updates from a configuraiton Nit, as I guess you'll respin: configuration. -- Stefano