From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iUemao5M; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id A9EC85A0271 for ; Thu, 09 Apr 2026 09:40:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775720449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYbO0VagQg3JZI1CObOFwfvFOaSsD++v7oGls3GHCjE=; b=iUemao5MWSpau50PNcbIJe7XRW5+j9fI5Q3tRY3pJyZz7jOEHF6IgUD4q43y3yFgAjPmTY wJA7CFRr9L0642GZIx92EmpLkYVKd9WInsDZBSZeJhgQA/7ffExmdli13Q3IKHmevVo7MT rDp0/oibgDRveOVLTb0Dn/5wnMMJooM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-hqIeW70HP_iJBbZ8lUgq9Q-1; Thu, 09 Apr 2026 03:40:47 -0400 X-MC-Unique: hqIeW70HP_iJBbZ8lUgq9Q-1 X-Mimecast-MFC-AGG-ID: hqIeW70HP_iJBbZ8lUgq9Q_1775720446 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488b966e9dbso4228435e9.3 for ; Thu, 09 Apr 2026 00:40:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775720446; x=1776325246; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iYbO0VagQg3JZI1CObOFwfvFOaSsD++v7oGls3GHCjE=; b=tRgbc1nssJISfheG7ctrOS/Dq4V7AF0OLzc+gjHZ0rZzKzgkz+Pc+vqXMohxKBQd4U 5/+mG96Pq8JAVbOpAQCWsRqLkUKPNsi7vpUxR5KxkeH03r9pbTNL2mgTRn1oGuUCGplP BZH78Oac12wZnNwnvpDzB2FZ+S5G4FrY36P1sZxTXVa/KuOlovTUVwvNvC/2B1LHrCuL RNWzneyj+ZSloVb+yTAftwWhk5tGwewK6QM/CJpBpN8+0ECd1W84u7N1JSelF+u7wwSL 6ceBtQOnCfLhRNyj6b0XsoUIivWbbcC/UF2BraPd+Y1LFihZGaYUWyldlgOU+egYdzVz 3nVQ== X-Gm-Message-State: AOJu0YwhapMD0DT8gFlylRQKnv4z+KFvzrI/FNNoDj+AhCBpJxnFL6Ha DPnLnkTyv0kuIo4E1fyts6NNzGe/6ebYB4PXwNyhPSjV1o05X6VEfV0rAWf9q/JtW4ynNr9flHD OjnAl5I+szKp6vw2RqvzXp9q4p4w/SwBhuhFg65N3d5SxLrIyyuyQcw== X-Gm-Gg: AeBDieslv6GaC1fk2LaH+EGiDRpg9cKOzjrtUouTVsfVJfxrp33uToI/dWPasjhOy+d 0xePdwpfY+QONj08JnhuWosJS8n2FYc5QIRhOlWnYZZ84cgUTehpoKoU6/JyCnVbT+BANmJXWr1 54R+JLeIbpAiC8RabtGIK/qOYuRtbYPV8M9vHmtKanQ/8vHLTio2xNC3qRkcOrarzD67YLQQF6o gYUWOr7Tt1YJR9wLvGEwAROkJ3pt2yIz0SVHsRljgsgw3K+FVcSsC2jA0ygIOLSa6NTBGFQP81n 0THWknPvR9C1drBI2eisbEzOWfTYOKl/W4pLwmp+LUrLMZOfE3IasNl8q8bpaVv142uvekkv4BN jf1hO1TDA+UV7zznJVQ3C59jmutaGomarwlEeCuQSuJNSn+KDYg== X-Received: by 2002:a05:600c:3f08:b0:485:40db:d40c with SMTP id 5b1f17b1804b1-488996d2323mr396989365e9.3.1775720446422; Thu, 09 Apr 2026 00:40:46 -0700 (PDT) X-Received: by 2002:a05:600c:3f08:b0:485:40db:d40c with SMTP id 5b1f17b1804b1-488996d2323mr396988625e9.3.1775720445783; Thu, 09 Apr 2026 00:40:45 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cd1a8393sm51927285e9.5.2026.04.09.00.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 00:40:45 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 12/18] conf: Don't be strict about exclusivity of forwarding mode Message-ID: <20260409094043.16d67825@elisabeth> In-Reply-To: References: <20260407031630.2457081-1-david@gibson.dropbear.id.au> <20260407031630.2457081-13-david@gibson.dropbear.id.au> <20260408234015.242166e9@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Thu, 09 Apr 2026 09:40:44 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eYfHs_d2AHybAQ0HxjWeY1AB-VbM0_nJBKzEWv7zk0Y_1775720446 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PEF5RQ6Z3B2VJM5D5CJ2RLBWRDUSBOU5 X-Message-ID-Hash: PEF5RQ6Z3B2VJM5D5CJ2RLBWRDUSBOU5 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 9 Apr 2026 10:12:07 +1000 David Gibson wrote: > On Wed, Apr 08, 2026 at 11:40:16PM +0200, Stefano Brivio wrote: > > On Tue, 7 Apr 2026 13:16:24 +1000 > > David Gibson wrote: > > > > > Currently as well as building the forwarding tables, conf() maintains a > > > "forwarding mode" value for each protocol and direction. This prevents, > > > for example "-t all" and "-t 40000" being given on the same command line. > > > > > > This restriction predates the forwarding table and is no longer really > > > necessary. Remove the restriction, instead doing our best to apply all the > > > given options simultaneously. > > > > > > * Many combinations previously disallowed will still be disallowed because > > > of conflicts between the specific generated rules, e.g. > > > -t all -t 8888 > > > (because -t all already listens on port 8888) > > > * Some new combinations are now allowed and will work, e.g. > > > -t all -t 40000 > > > because 'all' excludes ephemeral ports (which includes 40000 on default > > > Linux configurations). > > > > This is slightly confusing though: > > > > $ ./pasta -t auto -t 31337 > > Forwarding configuration conflict: TCP [*]:31337 => 31337 versus TCP [*]:1-32767 => 1-32767 (best effort) (auto-scan) > > You mean because the single port rule is redundant, but doesn't do > something different, so not strictly speaking conflicting? Right, yes. One might want to say something like "map all ports automatically, but 31337 always", and that's not (much?) more conflicting than "-t all -t 8888"... maybe. > > but I don't see a practical way to "fix" it for the moment being, and > > overall I'd say the new behaviour is better than the original one, so I > > don't really care. > > Ok. -- Stefano