From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aljaTI6B; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 254305A0265 for ; Wed, 15 Apr 2026 21:38:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776281904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n6YmcuKxrguGYJVLKpiM/abaaYA1rPpX+TTf7rqmBgc=; b=aljaTI6BVChDZqc/ZB4WEEbsu/4i1bhwqYcV5pRSiU2tIBYoImR97RezOUCxSfVTkBt4yw lmHFjWdm/0yZ+Ydfbd0zIjJPnQNVRehen2c6ssjOisL29SJrXNff8o8MYQWSWxOq5c+TCP oa068f7V3AdA2l7sECInk4LjC2v9Z8w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-iJGuWnm2PgiRgV8xCg4Vng-1; Wed, 15 Apr 2026 15:38:23 -0400 X-MC-Unique: iJGuWnm2PgiRgV8xCg4Vng-1 X-Mimecast-MFC-AGG-ID: iJGuWnm2PgiRgV8xCg4Vng_1776281902 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-488d9e1e61aso38951075e9.0 for ; Wed, 15 Apr 2026 12:38:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776281902; x=1776886702; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n6YmcuKxrguGYJVLKpiM/abaaYA1rPpX+TTf7rqmBgc=; b=s1sEPBIp4OyuvGno8bqPgDwld0peXrFGI+lM73t8WLNdXQYCbI2hmbfMW2V7DDyVVI RMb4pLHIqIauaiI1t/qvCJlc4GgILBKwZolUe2PC8eRqlP/GJMJTgduQR3d2O8rh7ZXj DpUTWP+tZkw+lFGsK4ddU2q8bvmvutv5S4iIV2QHmJWP6q5djkMzINPHuIXWkpOyIRJD BFrwPxXXbw3XuvYJJ8Vvlpo9Z6w6Jv7Lkx561IuEdvpeO5TQNdYCtF85K0TTJHFVPyxK ntGrXSO1upr7kJB+fvtSh3neSCuXjqdonCQOwRCQOWhAB6ltfaI5DTdX7oZ5WjBAOCqP 5ovA== X-Forwarded-Encrypted: i=1; AFNElJ8ud8O2eNyUTd8qXecbb6GlY5fPQE6fjsVAQuujbxNcWLWsDYJK4o+edHkVameMV72lN816cPonrPY=@passt.top X-Gm-Message-State: AOJu0YyfIywpNjRzXdIK4bbHZfZzRN2cKdS3pdvMuCTBTO2jMlmjDyoS kvbuK5pw01rnXTEWPfd2bGL4IusihDq8+nU8SfkDHs1CtH/Xn8EJYLpKnrBWRNFSmTdCW/GXty+ WIApPJ/qypVVamUthUyCEw2lfd3TkDlCeu0ZXugLnP4SnlP3PPtsH/g== X-Gm-Gg: AeBDievF+cmaQp0OmqKKSoLSHRkFCKj9CjEdOoKqgDOqDvQL5MaN7HUEtF6YgRKFTtQ ed8ZOBQ6WKPm/e66nvHmNIa++xOGligA7lFa1dEhJa3yskTA/ks9zIX3qa8yfL2gecS/WM8t37n 1Hsz5Y7h9Bz9rc56Lr2i3fej09Y8iUfoKLETI397FZGbkeSc3bZgRaZ234yaBECrdFmR7OMxso4 9EyH1p2sOI+OAumhq0p+dGgdfkjLggf4qI8ipLBIRhto2BYxixCbIvF/eBetmGp/dsDMAmJvQoC /Q/DaL9n33CrWZaohoBTCF592j2UFhdEFgVr6FomIuYjf7yUSAseI/+LHsUIq8Pl3Y2ZSWcKUpk CIWSZYtrXHmSllzwdhfe9Fy7FlgEaby3b X-Received: by 2002:a05:600c:a408:b0:488:8b99:54a1 with SMTP id 5b1f17b1804b1-488d68865f6mr247324265e9.28.1776281902040; Wed, 15 Apr 2026 12:38:22 -0700 (PDT) X-Received: by 2002:a05:600c:a408:b0:488:8b99:54a1 with SMTP id 5b1f17b1804b1-488d68865f6mr247324085e9.28.1776281901521; Wed, 15 Apr 2026 12:38:21 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0e9ad71sm26246115e9.17.2026.04.15.12.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 12:38:21 -0700 (PDT) From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v2] conf: use a single buffer for print formatting in conf_print() Message-ID: <20260415213819.28869768@elisabeth> In-Reply-To: <20260327195551.271076-1-jmaloy@redhat.com> References: <20260327195551.271076-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 15 Apr 2026 21:38:20 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4GTOZIPBw7WVyjlzzWAavuO7_LDFyIKJdHIVDlp9H_s_1776281902 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: JCS67FZF4FIQJFCHQZOARLKI2PLGA6MA X-Message-ID-Hash: JCS67FZF4FIQJFCHQZOARLKI2PLGA6MA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: dgibson@redhat.com, david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 27 Mar 2026 15:55:51 -0400 Jon Maloy wrote: > The function conf_print() uses three different buffers as target > for address print formatting. This is unnecessary, as a single > buffer of length INANY_ADDRSTRLEN has sufficient space for all > address types, IPv4, IPv6 and MAC. There is no risk for conflicts, > since all formatting is followed by an immediate info() printout. > > To make our life easier in the following commits, we do this > simplification here. > > Signed-off-by: Jon Maloy > > --- > v2: - Changed buffer length to INANY_ADDSTRLEN > - Eliminated use of same buffer in same info() printout. Applied, sorry for the delay. -- Stefano