From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Wx+JpUuq; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 61FF25A0265 for ; Wed, 15 Apr 2026 21:38:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776281922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7APFCFWti8QloF0ecObyjsrO0u4KpcSpU0AHPHszn9Q=; b=Wx+JpUuqb7JQW0fUZY+3oC2veVGefb4RRBmwDKQmposQzW2xrQr2K1KE/nI4DGcoZCA+GJ ZqXF4XkAJEqnQlfM4d+XRNS1EtCcj/hzFBdCv9Twfaz8iivfTe+w8xUZvUBJ3vm+5qmOlg wqJ5mZkJR+sOnAGU2/08UVxQ0PcitWg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-9WOSkC3VOt6PUfl5ZYsQEw-1; Wed, 15 Apr 2026 15:38:40 -0400 X-MC-Unique: 9WOSkC3VOt6PUfl5ZYsQEw-1 X-Mimecast-MFC-AGG-ID: 9WOSkC3VOt6PUfl5ZYsQEw_1776281920 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d177fb157so6990390f8f.0 for ; Wed, 15 Apr 2026 12:38:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776281918; x=1776886718; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7APFCFWti8QloF0ecObyjsrO0u4KpcSpU0AHPHszn9Q=; b=MqKPTw1C+KI+88y10+5gEB61qQA+5gDekEd9zvIhg5jxPdD1qIRXjXQ8ZC2tGTTElX kBG1GlqbUe49B9SEtjhOvTPC6QLuLIcU7Ez9FJCqjUHpxj1GT2wt0ZQbpQ8+BQf1ndrZ HA3lQmMg6FiBpuXTLBG+5rnIy4kjJyDAlWS4dTQN4p+zke/NSWALE097LHbl1mTMbqyC MR8rWY0ELcxBor+z9K3EQDUogFJoxufqQnTJuwaWZoS0GJH5poSMlEs6+JLRhXjyzGCj lcfZS2t4WYmxWRbRJzKsh8Y4JILiDH2BHWu02Uabs+rIfxIfQNr2FTs4brJcRkbYDLbZ /KEA== X-Forwarded-Encrypted: i=1; AFNElJ9RFi3V71slCITt1GpvvICdiZ2gzVo/BUuRqtJh9pATy8jQe8dplaPacA2Q0NTsB/cJvf/et7ijHUM=@passt.top X-Gm-Message-State: AOJu0YyQKpVC2+TfM6kx3WYsZJV/xz6e5W2aSBawfIDdFa5/BwJaTq7U pw9QWeWMdbBhwzfJVHnfiyYhOtkutmL7BKNrZUPI39S5do2x8yyma3kVpDMDxJfKI4LepH6pOE4 I75/NMIc3/19T6Xx5h34A7l1n3AQnK/kKVVf+jsDuZic24lv2NEOphwTBQsmE4g== X-Gm-Gg: AeBDietaaceNwNFXzRqWGWHfrxDwknQcMIkpZhDXNUG1mW2N3w2Dbp5ULfWW35zVceC 59p5cYHNHnohh0QtkqyDixrFS1jTF4zarTxj1WT5H8PN1xCJTr/Ye9Zmv5DZMx6wE3+ewvZ9vmS YeZpIIJ/W0gKX/HZSx1PhDf7iI8Qo1GC+XxLCSZsdCCpR7EoXj8r8TraO53HXw4i45eFCuiHVVW pfK1tdEsKoriAWQl5ySulwS4yWIDN117YwONyDIQqz0iffwsS2TGF8s4kwHljCdKV5dpKNKAp1r zIhuipVtzIXVJi0A/qavQH2ObAUQTIrY+aNSj1EKLz9Da8+bMXIXsBSsyl5CLwYrIN4MLzbHmb4 bRjcI+bsGfv7SWTCh+82xCYTznI+34VnM X-Received: by 2002:a5d:5d10:0:b0:43d:7ea8:a622 with SMTP id ffacd0b85a97d-43d7ea8a772mr14960569f8f.30.1776281918095; Wed, 15 Apr 2026 12:38:38 -0700 (PDT) X-Received: by 2002:a5d:5d10:0:b0:43d:7ea8:a622 with SMTP id ffacd0b85a97d-43d7ea8a772mr14960534f8f.30.1776281917657; Wed, 15 Apr 2026 12:38:37 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead33d665sm7566084f8f.7.2026.04.15.12.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 12:38:37 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3] tap, tcp, udp: Use rate-limited logging Message-ID: <20260415213836.418df481@elisabeth> In-Reply-To: References: <20260410103737.1642986-1-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 15 Apr 2026 21:38:36 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dW_0RgdQIoq7kT2cVe9rL1eLzEQhRoVceI7pIfPPgYM_1776281920 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GHT3H7QKYUZTTJ46HWJBOO2S5DIQIJXI X-Message-ID-Hash: GHT3H7QKYUZTTJ46HWJBOO2S5DIQIJXI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Anshu Kumari , passt-dev@passt.top, v@njh.eu, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 13 Apr 2026 16:25:52 +1000 David Gibson wrote: > On Fri, Apr 10, 2026 at 04:07:37PM +0530, Anshu Kumari wrote: > > Now that rate-limited logging macros are available, promote several > > debug messages to higher severity levels. These messages were > > previously kept at debug to prevent guests from flooding host > > logs, but with rate limiting they can safely be made visible in > > normal operation. > > > > In tap.c, refactor tap4_is_fragment() to use warn_ratelimit() instead > > of its ad-hoc rate limiting, and promote the guest MAC address change > > message to info level. > > > > In tcp.c, promote the invalid TCP SYN endpoint message to warn level. > > > > In udp.c, promote dropped datagram messages to warn level, and > > rate-limit the unrecoverable socket error message. > > > > In udp_flow.c, promote flow allocation failures to err_ratelimit. > > > > Link: https://bugs.passt.top/show_bug.cgi?id=134 > > Signed-off-by: Anshu Kumari > > Reviewed-by: David Gibson > > > --- > > v3: > > - Promote flow allocation failures to err_ratelimit from > > warn_ratelimit. > > Nit: doesn't affect the validity of the patch itself, but I'd consider > "promotion" in this context as going from a less severe to more severe > error level. So going from 'err' to 'warn' is a demotion, not a > promotion. Wait but this is now going _from_ 'warn' _to_ 'err', so it's indeed a promotion, isn't it? -- Stefano