From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ldvv6TAb; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id A8E605A0265 for ; Wed, 15 Apr 2026 21:38:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776281929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QXrvFpu2KKT2RjKbsmYi71pzVjmUu4St2Lb8vEAYJ3w=; b=Ldvv6TAbIZyaLDAI2/WZ+ahApNDMUlrNx+JW+4SrxWHRRRTPfTmumgkEuQa+HtQ3de3QaW 1nIUFjqi+GZV7jocNbFW/DmixhAxmc+hsQH9rzX67du1DbVK/FCsvCZZLU2SYDg4OWc0nW e5+nUwM3DA+/VmN70j7iiaSNHutwTpQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-hv494kQsOZSDWwYCHpGOIg-1; Wed, 15 Apr 2026 15:38:45 -0400 X-MC-Unique: hv494kQsOZSDWwYCHpGOIg-1 X-Mimecast-MFC-AGG-ID: hv494kQsOZSDWwYCHpGOIg_1776281924 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d7c6d58c8so3991854f8f.3 for ; Wed, 15 Apr 2026 12:38:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776281924; x=1776886724; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QXrvFpu2KKT2RjKbsmYi71pzVjmUu4St2Lb8vEAYJ3w=; b=ZNiO0p7sfj2UlfLp4+IADwCYNBKk1ijpoSJG9jI9JEZtUXyfyfpXwJP+g9KcAbfzr3 sTVbWET51BuWKsUF0fjsyBmGrwmXYpK6ZJxuS5GAqcTF6cuk69Xaes9h6f/PpXl3LmD7 UJ8r3AegGZEbdsoT0fCtaRJLjX4L2aEI5pcBfLpR6AtaLIja7c6gtgaDaM7pURg86tIP vFQ9fiYJbMbmpq+4WTbjYs5OSLdU1zHkIplybfGGp81L/kKF1Hb6gJmz3PCfekza2EPY QscF9Z5V/VbZgKwA5MI/8o3COpQcreukndcpXnEDq751plmlVVyfM1VqND9caYGTc3e6 4omA== X-Gm-Message-State: AOJu0Yz13co1jOecF3h4rjGEp3kzNNpTBeVEElhVo+fyYQXQE1EStlJa t+ynUWhW27XOP2Fam2wrabFPygALCujuz5seTFszNHfxemTMMRaFDoL7OJqu7Zo/iXGXVAKekGy 2pug8DlwE5HPejxEJ/+7TQfc6cZkGMySvJeDfS2wSddqzn8PWWa86fw== X-Gm-Gg: AeBDieuc9WBuRbIORm7YQ6D7WoPBocfPXxhi0Dpj6umnDOFJzF+k2olJBuIggZwPSll YdxSw2H8keIThuRRkWPZMTiBP8WNDJMDvt0xY4Xrm4hVpOKzLpK2jy68saqtiEA2LlbQR5Skg0X z1NrI2QqK0+sbyqjtNVpbsdpzwW66wnldqdxvuMpgF3pfbHUl5wMBS1aue9m9LbtdTkIGeUzKC/ ubmkn6KYctp7cWj500eDKZxsWocHEEuOwPuPXYp5xCCad7ARcAQt9O3nQ/kqxSxkGHdAQh8Hlmf D/KRGAyb9KrzCtk59vUYkJkeDn4+l+q+C1cWbWsij6MV1ujhgPltRuT+ZFczIq8b/9K9OHbPWcn 9iHX1junf14X8Zn4ziqXiLgIlH56KFFHs X-Received: by 2002:a05:600c:30d2:b0:488:e192:6fb5 with SMTP id 5b1f17b1804b1-488e19270cbmr173428965e9.24.1776281924272; Wed, 15 Apr 2026 12:38:44 -0700 (PDT) X-Received: by 2002:a05:600c:30d2:b0:488:e192:6fb5 with SMTP id 5b1f17b1804b1-488e19270cbmr173428785e9.24.1776281923826; Wed, 15 Apr 2026 12:38:43 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ede24eb0sm170553685e9.8.2026.04.15.12.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 12:38:43 -0700 (PDT) From: Stefano Brivio To: Anshu Kumari Subject: Re: [PATCH v3] tap, tcp, udp: Use rate-limited logging Message-ID: <20260415213842.7142e5d4@elisabeth> In-Reply-To: <20260410103737.1642986-1-anskuma@redhat.com> References: <20260410103737.1642986-1-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 15 Apr 2026 21:38:43 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OFK9HLrv0p5HL4-_UzGPkMVSrpAHdV6QR_BRY-A7vJc_1776281924 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: B76UAQLMASBE3TJKO4JC2KMZUHXAGGN7 X-Message-ID-Hash: B76UAQLMASBE3TJKO4JC2KMZUHXAGGN7 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au, v@njh.eu, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 10 Apr 2026 16:07:37 +0530 Anshu Kumari wrote: > Now that rate-limited logging macros are available, promote several > debug messages to higher severity levels. These messages were > previously kept at debug to prevent guests from flooding host > logs, but with rate limiting they can safely be made visible in > normal operation. > > In tap.c, refactor tap4_is_fragment() to use warn_ratelimit() instead > of its ad-hoc rate limiting, and promote the guest MAC address change > message to info level. > > In tcp.c, promote the invalid TCP SYN endpoint message to warn level. > > In udp.c, promote dropped datagram messages to warn level, and > rate-limit the unrecoverable socket error message. > > In udp_flow.c, promote flow allocation failures to err_ratelimit. > > Link: https://bugs.passt.top/show_bug.cgi?id=134 > Signed-off-by: Anshu Kumari > --- > v3: > - Promote flow allocation failures to err_ratelimit from > warn_ratelimit. > - Fix remaining alignment issues. > - Cc Volker Applied. -- Stefano