From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 00/23] Rework forwarding option parsing
Date: Thu, 16 Apr 2026 00:05:05 +0200 (CEST) [thread overview]
Message-ID: <20260416000505.10ce0177@elisabeth> (raw)
In-Reply-To: <20260410010309.736855-1-david@gibson.dropbear.id.au>
On Fri, 10 Apr 2026 11:02:46 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> This series makes a number of significant reworks to how we process
> forwarding options (-t, -u, -T and -U) in passt & pasta. This is
> largely motivated by moving towards being able to share this code with
> a configuration update tool. However, along the way it also enables
> some forwarding configurations that were technically possible with the
> forwarding table but couldn't be specified on the command line, in
> particular bug 180.
>
> There is still a bunch of work needed to make the parsing code truly
> shareable with pesto, but this is a solid start.
>
> v2:
> * Assorted minor changes based on Stefano's review, including
> * Explicitly state "guest or namespace" in the manpage
> * Clearer description of @rulesocks field
> * Worked around a gcc < 15 bug causing a false positive warning
> * Update man page and usage() for new capabilities
> * Additional patches moving rule parsing out of conf.c
I applied up to 14/23 as I had comments on patches after that one.
I also have pending comments on 10/23 and 11/23 but I'm fairly sure they
would need to be addressed in subsequent patches anyway (if at all).
--
Stefano
prev parent reply other threads:[~2026-04-15 22:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 1:02 David Gibson
2026-04-10 1:02 ` [PATCH v2 01/23] conf: Split parsing of port specifiers from the rest of -[tuTU] parsing David Gibson
2026-04-10 1:02 ` [PATCH v2 02/23] conf: Simplify handling of default forwarding mode David Gibson
2026-04-10 1:02 ` [PATCH v2 03/23] conf: Move first pass handling of -[TU] next to handling of -[tu] David Gibson
2026-04-10 1:02 ` [PATCH v2 04/23] doc: Consolidate -[tu] option descriptions for passt and pasta David Gibson
2026-04-10 1:02 ` [PATCH v2 05/23] conf: Permit -[tTuU] all in pasta mode David Gibson
2026-04-10 1:02 ` [PATCH v2 06/23] fwd: Better split forwarding rule specification from associated sockets David Gibson
2026-04-10 1:02 ` [PATCH v2 07/23] fwd_rule: Move forwarding rule formatting David Gibson
2026-04-10 1:02 ` [PATCH v2 08/23] conf: Pass protocol explicitly to conf_ports_range_except() David Gibson
2026-04-10 1:02 ` [PATCH v2 09/23] fwd: Split rule building from rule adding David Gibson
2026-04-10 1:02 ` [PATCH v2 10/23] fwd_rule: Move rule conflict checking from fwd_rule_add() to caller David Gibson
2026-04-15 22:04 ` Stefano Brivio
2026-04-16 1:19 ` David Gibson
2026-04-10 1:02 ` [PATCH v2 11/23] fwd: Improve error handling in fwd_rule_add() David Gibson
2026-04-15 22:04 ` Stefano Brivio
2026-04-16 1:21 ` David Gibson
2026-04-10 1:02 ` [PATCH v2 12/23] conf: Don't be strict about exclusivity of forwarding mode David Gibson
2026-04-10 1:02 ` [PATCH v2 13/23] conf: Rework stepping through chunks of port specifiers David Gibson
2026-04-10 1:03 ` [PATCH v2 14/23] conf: Rework checking for garbage after a range David Gibson
2026-04-10 1:03 ` [PATCH v2 15/23] doc: Rework man page description of port specifiers David Gibson
2026-04-15 22:04 ` Stefano Brivio
2026-04-16 1:34 ` David Gibson
2026-04-10 1:03 ` [PATCH v2 16/23] conf: Move "all" handling to port specifier David Gibson
2026-04-15 22:04 ` Stefano Brivio
2026-04-16 1:37 ` David Gibson
2026-04-10 1:03 ` [PATCH v2 17/23] conf: Allow user-specified auto-scanned port forwarding ranges David Gibson
2026-04-15 22:04 ` Stefano Brivio
2026-04-16 1:44 ` David Gibson
2026-04-10 1:03 ` [PATCH v2 18/23] conf: Move SO_BINDTODEVICE workaround to conf_ports() David Gibson
2026-04-10 1:03 ` [PATCH v2 19/23] conf: Don't pass raw commandline argument to conf_ports_spec() David Gibson
2026-04-10 1:03 ` [PATCH v2 20/23] fwd, conf: Add capabilities bits to each forwarding table David Gibson
2026-04-10 1:03 ` [PATCH v2 21/23] conf, fwd: Stricter rule checking in fwd_rule_add() David Gibson
2026-04-15 22:04 ` Stefano Brivio
2026-04-16 1:46 ` David Gibson
2026-04-10 1:03 ` [PATCH v2 22/23] fwd_rule: Move ephemeral port probing to fwd_rule.c David Gibson
2026-04-10 1:03 ` [PATCH v2 23/23] fwd, conf: Move rule parsing code to fwd_rule.[ch] David Gibson
2026-04-15 22:05 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416000505.10ce0177@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).