From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i7RRnutI; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id AEBA15A0265 for ; Tue, 21 Apr 2026 00:33:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776724411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kNBkXqhrdY4iP0EDdDTHt+0vQvstRlCnnFWWaU+aBFg=; b=i7RRnutIywzuQxukgW0n6o8bKUfIPo3rphiv8qU3cZ6a9yhqIOFpnC+2Th+rnQI68CkBRX 4mPu028/4oVk6xGTK2ZaRYIStLZhBCRgEWvVOMMxG6REnf/TQ82nRuK9Bmm/BnpMdcCcc2 jRh4sxuWaJljZaNKTFT1L8uL8jeCTJg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-FAMDZGJSPnKzDDbstxxfcA-1; Mon, 20 Apr 2026 18:33:30 -0400 X-MC-Unique: FAMDZGJSPnKzDDbstxxfcA-1 X-Mimecast-MFC-AGG-ID: FAMDZGJSPnKzDDbstxxfcA_1776724409 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4411a529bc0so958278f8f.0 for ; Mon, 20 Apr 2026 15:33:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776724408; x=1777329208; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kNBkXqhrdY4iP0EDdDTHt+0vQvstRlCnnFWWaU+aBFg=; b=HzeViWElPrbzE87guXhTk1usFElSh7Sxk+zdaGRcYyCCPk6DMTMtHmoygqJntxHhsm F6iERcWBWlfiDygZWlwAhI+bjog4pN8qi8IOKehtgPyoplD61Aon/jWc8c71vXclCAME HdxlN+xpMZZ4TwI/b14bNKfe4Dlxq09T48+MCadnkTytKFp6gpVQfK83D4xp54eztV6S CCJRHdPJ5C3cDlyWwniP62E2NtCpKlfR/PrrKPbvA49jXLY91Xf1W1MtIwI/jYEj0jK2 6ZvQWQOjxTOergK340797OeqJji28rWcnhWbnuXFZwNbClg9JjxDGGgBP6rZMcUKJ47V V4vw== X-Gm-Message-State: AOJu0YyO2z+gMvJNSgsP03jAE6UcoYcTKRrrgeCaOxfQl/EDJP3ydgea ODMOCLwQnounJzB1agIMgh9tAnHtMtPmACB6usPmc3jsJ+W52YIQJ5vCGRvXc6C16ChAh0m5K9f NFzsfKok8qLPaujy4HIPkdPQLdF4Z/KUikM58FrSRj3ZYrSBs+xVlNQ== X-Gm-Gg: AeBDieswvtP/AoUUCl0P2pdd7LnYEkdRj1xuKXkRwD72e0ZIpr4Oc6NFcIp63B3L+m9 W/oXHKAOgwc7CEZb5Dbc8LLkFrs3In8Kjb9jOAHilbwuerLOpWRaOvwIu8cQ1XYI9IVWRWem9z5 837N1/TorDG36sHDt+RtAZG3tbkZYsERfYmxMwmTiu2ahs12X0bm3AbFlQ6kEGewEiJkoGLElrX +WHSpcLOPdp5f78gfrWHqeyWJKvs0VBQrFpK1Afv/sjQ07uJzYZv4FfIL3hAJgWKWVAVhbrWoz7 CmhhiodYSQ0clJRjbchDT4WDgVXBCfGE0DlCAmYv4oPkvRTO1CrtSD0GyplaYyN0LYjqLZxF3em D8wL96icCf+XaPVp3bJyu0oUGoYfpzXSEkBv8LaEzgHg= X-Received: by 2002:a05:6000:2888:b0:43d:762e:76ba with SMTP id ffacd0b85a97d-43fe3dc2eb1mr23529606f8f.17.1776724408583; Mon, 20 Apr 2026 15:33:28 -0700 (PDT) X-Received: by 2002:a05:6000:2888:b0:43d:762e:76ba with SMTP id ffacd0b85a97d-43fe3dc2eb1mr23529590f8f.17.1776724408135; Mon, 20 Apr 2026 15:33:28 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d112sm36323654f8f.29.2026.04.20.15.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 15:33:27 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 00/11] Rework forwarding option parsing Message-ID: <20260421003326.64a03015@elisabeth> In-Reply-To: <20260417050520.102247-1-david@gibson.dropbear.id.au> References: <20260417050520.102247-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 21 Apr 2026 00:33:27 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0Jv8oyQaZWi2iNESVdZxBQTT4Kj7rx2wL1kMMGcaFnQ_1776724409 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: DFCOE3NWEBVMSY4EHQVSYGLFQGFWEJRH X-Message-ID-Hash: DFCOE3NWEBVMSY4EHQVSYGLFQGFWEJRH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 17 Apr 2026 15:05:09 +1000 David Gibson wrote: > This series makes a number of significant reworks to how we process > forwarding options (-t, -u, -T and -U) in passt & pasta. This is > largely motivated by moving towards being able to share this code with > a configuration update tool. However, along the way it also enables > some forwarding configurations that were technically possible with the > forwarding table but couldn't be specified on the command line, in > particular bug 180. > > There is still a bunch of work needed to make the parsing code truly > shareable with pesto, but this is a solid start. > > v3: > * Removed already merged patches > * Further revisions based on Stefano's review, including > * Improved example text in manpage and usage > * More flexible rule dumping > * Re-integrated conflict checking in fwd_rule_add() Applied up to 6/11, with the nit in 3/11 reported by Laurent ("double space between ) and {") fixed. The rest looks good to me, minus pending comments (all from Laurent). -- Stefano