From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 05/13] Makefile: Make conditional definition of $(BIN) clearer
Date: Tue, 21 Apr 2026 12:43:36 +1000 [thread overview]
Message-ID: <20260421024344.1379633-6-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260421024344.1379633-1-david@gibson.dropbear.id.au>
The list of binaries is dependent on the target architecture, because
x86_64 addes the passt.avx2 and pasta.avx2 binaries. Make this more clear
by defining BIN in common, then augmenting it in the x86_64 case.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 1e5f0282..a2576771 100644
--- a/Makefile
+++ b/Makefile
@@ -77,10 +77,9 @@ docdir ?= $(datarootdir)/doc/passt
mandir ?= $(datarootdir)/man
man1dir ?= $(mandir)/man1
+BIN = passt pasta qrap passt-repair
ifeq ($(TARGET_ARCH),x86_64)
-BIN := passt passt.avx2 pasta pasta.avx2 qrap passt-repair
-else
-BIN := passt pasta qrap passt-repair
+BIN += passt.avx2 pasta.avx2
endif
all: $(BIN) $(MANPAGES) docs
--
2.53.0
next prev parent reply other threads:[~2026-04-21 2:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 2:43 [PATCH 00/13] Improvements to static checker invocation David Gibson
2026-04-21 2:43 ` [PATCH 01/13] Makefile: Use make variables for static checker configuration David Gibson
2026-04-21 2:43 ` [PATCH 02/13] cppcheck: Split out essential defines into a BASE_CPPFLAGS variable David Gibson
2026-04-21 2:43 ` [PATCH 03/13] Makefile: Remove preprocessor flags from $(FLAGS) David Gibson
2026-04-21 2:43 ` [PATCH 04/13] Makefile: Remove non-standard $(FLAGS) variable David Gibson
2026-04-21 2:43 ` David Gibson [this message]
2026-04-21 2:43 ` [PATCH 06/13] Makefile: Use common binary compilation rule David Gibson
2026-04-21 2:43 ` [PATCH 07/13] Makefile: Remove unhelpful $(HEADERS) variable David Gibson
2026-04-21 2:43 ` [PATCH 08/13] Makefile: Add header dependencies for secondary binaries David Gibson
2026-04-21 2:43 ` [PATCH 09/13] Makefile: Split static checker targets David Gibson
2026-04-21 2:43 ` [PATCH 10/13] passt-repair: Split out inotify handling to its own function David Gibson
2026-04-21 2:43 ` [PATCH 11/13] passt-repair: Simplify construction of Unix path from inotify David Gibson
2026-04-21 2:43 ` [PATCH 12/13] passt-repair: Run static checkers David Gibson
2026-04-21 2:43 ` [PATCH 13/13] qrap: " David Gibson
2026-04-21 3:03 ` [PATCH 00/13] Improvements to static checker invocation David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421024344.1379633-6-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).