From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=N7JsTw3u; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 0D5B05A0623 for ; Tue, 21 Apr 2026 05:23:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1776741822; bh=cdlpTszflbNtWflyvwRrwfMFyTwHSkdw/uDc0jNu9J4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N7JsTw3uK02eyytQRkz/1V/kn2JMceLzUnsxut0COK9EmRpKwgbMHRduvb6Su+ufN /8CwOs/x9MunnAmy/8khIQ0RqPEDFn+LntSeK1pZGNXE+y29mfPbPO8kRxwx8qozNj Olh8icsbb3CvMXG2fgUQgWHGs9n7q9zvtFQBuR/x9itmMcal97ODlMF2/zDADv/KVt vRVUOPk4PJ4GeM9f2GTYWpi3RyPXbn30wtscjIAvr7RgQ/H3VT7scK7N1wn3uY2OfH qM5wOg3W54S7gPJOoapngqEDy6dUfZSlZRa8Y30U2PFqFyUWphhObkeM9aVzRAFYXO RQCQQHBO6rlVg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4g073y5GJ0z4wCp; Tue, 21 Apr 2026 13:23:42 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 07/13] Makefile: Remove unhelpful $(HEADERS) variable Date: Tue, 21 Apr 2026 13:23:32 +1000 Message-ID: <20260421032338.1909084-8-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260421032338.1909084-1-david@gibson.dropbear.id.au> References: <20260421032338.1909084-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: QLIAOYBRZNMLPP2ID3HVIPWHLLP676RZ X-Message-ID-Hash: QLIAOYBRZNMLPP2ID3HVIPWHLLP676RZ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Confusingly HEADERS is not headers that are shared between our various binaries. Rather it's just the (non generated) headers for passt, plus seccomp.h. This isn't particularly useful, just open code it in the handful of places we need it. Signed-off-by: David Gibson --- Makefile | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 18343491..03113803 100644 --- a/Makefile +++ b/Makefile @@ -58,7 +58,6 @@ PASST_HEADERS = arch.h arp.h bitmap.h checksum.h conf.h dhcp.h dhcpv6.h \ siphash.h tap.h tcp.h tcp_buf.h tcp_conn.h tcp_internal.h tcp_splice.h \ tcp_vu.h udp.h udp_flow.h udp_internal.h udp_vu.h util.h vhost_user.h \ virtio.h vu_common.h -HEADERS = $(PASST_HEADERS) seccomp.h C := \#include \nint main(){int a=getrandom(0, 0, 0);} ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) @@ -102,10 +101,10 @@ seccomp_repair.h: seccomp.sh $(PASST_REPAIR_SRCS) $(BASEBIN): %: $(CC) $(BASE_CPPFLAGS) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) $(filter %.c,$^) -o $@ -passt: $(PASST_SRCS) $(HEADERS) +passt: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h passt.avx2: CFLAGS += -Ofast -mavx2 -ftree-vectorize -funroll-loops -passt.avx2: $(PASST_SRCS) $(HEADERS) +passt.avx2: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h pasta.avx2 pasta.1 pasta: pasta%: passt% ln -sf $< $@ @@ -198,5 +197,5 @@ CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ --suppress=unusedStructMember \ -D CPPCHECK_6936 -cppcheck: $(PASST_SRCS) $(HEADERS) +cppcheck: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^ -- 2.53.0