public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v4 07/17] fwd_rule: Fix some format specifiers
Date: Tue, 21 Apr 2026 14:42:07 +1000	[thread overview]
Message-ID: <20260421044217.2500314-8-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260421044217.2500314-1-david@gibson.dropbear.id.au>

The new warnings in fwd_rule_add() have some not quite technically correct
format specifiers.  For some weird reason these don't trip warnings on
passt itself, but do when we re-use this code in the upcoming configuration
client.  Fix them.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 fwd_rule.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fwd_rule.c b/fwd_rule.c
index 777282da..7fd20dda 100644
--- a/fwd_rule.c
+++ b/fwd_rule.c
@@ -208,7 +208,7 @@ static int fwd_rule_add(struct fwd_table *fwd, const struct fwd_rule *new)
 		return -EINVAL;
 	}
 	if (new->flags & ~allowed_flags) {
-		warn("Rule has invalid flags 0x%hhx",
+		warn("Rule has invalid flags 0x%x",
 		     new->flags & ~allowed_flags);
 		return -EINVAL;
 	}
@@ -267,11 +267,11 @@ static int fwd_rule_add(struct fwd_table *fwd, const struct fwd_rule *new)
 	}
 
 	if (fwd->count >= ARRAY_SIZE(fwd->rules)) {
-		warn("Too many rules (maximum %u)", ARRAY_SIZE(fwd->rules));
+		warn("Too many rules (maximum %d)", ARRAY_SIZE(fwd->rules));
 		return -ENOSPC;
 	}
 	if ((fwd->sock_count + num) > ARRAY_SIZE(fwd->socks)) {
-		warn("Rules require too many listening sockets (maximum %u)",
+		warn("Rules require too many listening sockets (maximum %d)",
 		     ARRAY_SIZE(fwd->socks));
 		return -ENOSPC;
 	}
-- 
2.53.0


  parent reply	other threads:[~2026-04-21  4:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21  4:42 [PATCH v4 00/17] RFC: Dynamic configuration update implementation David Gibson
2026-04-21  4:42 ` [PATCH v4 01/17] conf, fwd: Stricter rule checking in fwd_rule_add() David Gibson
2026-04-21  4:42 ` [PATCH v4 02/17] fwd_rule: Move ephemeral port probing to fwd_rule.c David Gibson
2026-04-21  4:42 ` [PATCH v4 03/17] fwd, conf: Move rule parsing code to fwd_rule.[ch] David Gibson
2026-04-21  4:42 ` [PATCH v4 04/17] fwd_rule: Move conflict checking back within fwd_rule_add() David Gibson
2026-04-21  4:42 ` [PATCH v4 05/17] fwd: Generalise fwd_rules_info() David Gibson
2026-04-21  4:42 ` [PATCH v4 06/17] pif: Limit pif names to 128 bytes David Gibson
2026-04-21  4:42 ` David Gibson [this message]
2026-04-21  4:42 ` [PATCH v4 08/17] pesto: Introduce stub configuration tool David Gibson
2026-04-21  4:42 ` [PATCH v4 09/17] pesto, log: Share log.h (but not log.c) with pesto tool David Gibson
2026-04-21  4:42 ` [PATCH v4 10/17] pesto, conf: Have pesto connect to passt and check versions David Gibson
2026-04-21  4:42 ` [PATCH v4 11/17] pesto: Expose list of pifs to pesto and optionally display David Gibson
2026-04-21  4:42 ` [PATCH v4 12/17] ip: Prepare ip.[ch] for sharing with pesto tool David Gibson
2026-04-21  4:42 ` [PATCH v4 13/17] inany: Prepare inany.[ch] " David Gibson
2026-04-21  4:42 ` [PATCH v4 14/17] pesto: Read current ruleset from passt/pasta and optionally display it David Gibson
2026-04-21  4:42 ` [PATCH v4 15/17] pesto: Parse and add new rules from command line David Gibson
2026-04-21  4:42 ` [PATCH v4 16/17] pesto, conf: Send updated rules from pesto back to passt/pasta David Gibson
2026-04-21  4:42 ` [PATCH v4 17/17] conf, fwd: Allow switching to new rules received from pesto David Gibson
2026-04-21  6:26 ` [PATCH v4 00/17] IGNORE RFC: Dynamic configuration update implementation David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260421044217.2500314-8-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).