From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A4xUElCo; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 5CD985A026E for ; Sat, 25 Apr 2026 11:36:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777109764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AdRdWEbPegFoxG80vM3VRTgN57VAB4gnLVhJew1kdbI=; b=A4xUElCo7V6LLbMa64SkxESKaEK85iGIwDJncULoOqtdULPYvfy5As1UzSNj4fTi4X5TKL pVsGDVfpMpSEPl8EMVzM10iadvq5bJk9oaMVqrAswxLD9ZHYvDMl7gLHgObTzut//RpHlj jzXoyQ+e2E23abZ/+X3kS+Xn9TJnDHU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-0brdaeVXNWuljkX1IuEY_A-1; Sat, 25 Apr 2026 05:36:02 -0400 X-MC-Unique: 0brdaeVXNWuljkX1IuEY_A-1 X-Mimecast-MFC-AGG-ID: 0brdaeVXNWuljkX1IuEY_A_1777109761 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-488c2aa6becso78199895e9.2 for ; Sat, 25 Apr 2026 02:36:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777109761; x=1777714561; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AdRdWEbPegFoxG80vM3VRTgN57VAB4gnLVhJew1kdbI=; b=ZZWvnfur+YwXWHZXdEw2K//C1k/jgtRrdys8wDjX+OUUM2lylPY29vqpkjVLED1baQ rvMlimvOf+/05jQyhsdKjI5Bp6tsX4lRI8a2bvB2G4Of5JX+kL7lqod0i+n4fTcnl0vI nt8IdFUVD5pwzgpli4EkMKATUs/ScDuW4sUd3nI3H2FXURLRXjV91DSDFKbZOCkcxHo4 Ka+WTJIKPvHO+jKxB/3AM2qDwWQlP1ukN/c7KEv3bB4xuvPwVhGlJYhZzEUq/iHUgD5n CKnDrqSbOtFBIumcsuGEjFbmmO8OBTVRA0Aou6RAkIMVcmvlRMguqEye9TXwqd4rMUUf 69uA== X-Forwarded-Encrypted: i=1; AFNElJ9Oi6XuLLEsTmb1gtXNCHODj5awh9SnLPvdnU8O0+ef1qc/P6EI5SDfkkkEI2RJW0WnHFBqh1zoLVo=@passt.top X-Gm-Message-State: AOJu0YybIXVgY5KkSsxiKSbuKf6ac0Wt094KZQHG7Tp9+K9uBsVvtggf mpY/PAQXG4J46z8eNSjveJIxYGwIYGMRUbGodNJ6nSgdPwyF84M7Jjuntx1dgIRNZ/bIhgt4yZD AOqlSbONqcJYJPUHOhUYaGRECkxLgyHLtHnafsfDADWUVG4mCADWqlvU+vhksCQ== X-Gm-Gg: AeBDiethn0l+1KhfYGn0haPl0ybK0+YcssMRG7M9IX5eZDOopEu/OvI3UMHHL+A77mC 5RwFdN5mH2/XsgGIlcQycPZRDMTK1gRQSHi+vsjxDARe6VpOpnFtfiB2QtpWCA/nMVLHIwHb01A zg31GD9a3FiAu9ilrJZF3zFl4gV5UK2oiL/1mwKAjDvVC9me8mAG2D4vtAq+pQyx6xW6W3pE1A/ BSop8FeP9SoOto+Qi+ccDd+Olrev+oe/GqiSajGxm6bTXVwfreNgLa0ZGfWkC2G8NwM36Qumz7s L5/P4JyjloGD3KSIrelI4Uz+BfrnJGw6S1gRe4gum9PqtMKp5H0xl4n5NmpVZEwcn/YWMXQcM0j SRCNXTJgloPhzdhzjW2kOf04KlJ3XolX/Pw6EXsIkdlUPiKhThFsdtDDj3n0H X-Received: by 2002:a05:600c:a408:b0:48a:592c:e632 with SMTP id 5b1f17b1804b1-48a592ce943mr177634625e9.16.1777109760897; Sat, 25 Apr 2026 02:36:00 -0700 (PDT) X-Received: by 2002:a05:600c:a408:b0:48a:592c:e632 with SMTP id 5b1f17b1804b1-48a592ce943mr177634395e9.16.1777109760270; Sat, 25 Apr 2026 02:36:00 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a79esm68331398f8f.17.2026.04.25.02.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 02:35:59 -0700 (PDT) From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v5 15/18] pesto: Read current ruleset from passt/pasta and optionally display it Message-ID: <20260425113558.2dbc419e@elisabeth> In-Reply-To: References: <20260421062516.2601204-1-david@gibson.dropbear.id.au> <20260421062516.2601204-16-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eDHMgGZBIS_hMKtuQcwirs7EOrWQgfcLIzh0AjRVgp0_1777109761 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Hits: emergency X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved Message-ID-Hash: QRAWIIAKDIE4SRNRDO6VCRHRHALVJFCW X-Message-ID-Hash: QRAWIIAKDIE4SRNRDO6VCRHRHALVJFCW X-Mailman-Approved-At: Mon, 27 Apr 2026 09:47:04 +0200 CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Date: Sat, 25 Apr 2026 09:36:05 X-Original-Date: Sat, 25 Apr 2026 11:35:59 +0200 (CEST) On Fri, 24 Apr 2026 18:37:58 -0400 Jon Maloy wrote: > On 2026-04-21 02:25, David Gibson wrote: > > Implement serialisation of our current forwarding rules in conf.c, > > deserialising it to display in the pesto client. Doing this requires > > adding ip.c, inany.c, bitmap.c, lineread.c and fwd_rule.c to the pesto > > build. With previous preparations that now requires only a trivial change > [...] > > > + > > + > > +/** > > + * fwd_rule_read() - Read serialised rule from an fd > > + * @fd: fd to serialise to > > + * @rule: Buffer to store rule into > > + * > > + * Return: 0 on success, -1 on error (with errno set) > > + */ > > +int fwd_rule_read(int fd, struct fwd_rule *rule) > > +{ > > + if (read_all_buf(fd, rule, sizeof(*rule))) > > + return -1; > > + > > + /* Byteswap for host */ > > + rule->first = ntohs(rule->first); > > + rule->last = ntohs(rule->last); > > + rule->to = htons(rule->to); > Or ntohs() ? Thanks, nice catch, I'll fix this (I'm adopting this series and trying to complete it while David is off). -- Stefano