From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eY/jjYqt; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 4877B5A0265 for ; Tue, 28 Apr 2026 09:17:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777360656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k5vGtpZ6iOY9WVsbyHSHabLf2wtH3+nr9DrtxA/06wI=; b=eY/jjYqtWdOxaYkMcgbyzt5I+W0h+4CDNdOh0DNyPkcNfPcgguRgsyU1LUXRDU6FFnafQR XEU+1LhBnKSOtgQN5VMtm52NI9N6dqAatjt2kSbQ2/7jc4CSgmsjRHaKVgqzva28r9k17j LIiEsT+OapWaDoZrrLvl/HdOzzxpWzY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-ByTDyDwGP7mcd73CdY3BCA-1; Tue, 28 Apr 2026 03:17:34 -0400 X-MC-Unique: ByTDyDwGP7mcd73CdY3BCA-1 X-Mimecast-MFC-AGG-ID: ByTDyDwGP7mcd73CdY3BCA_1777360653 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d03065782so7153807f8f.0 for ; Tue, 28 Apr 2026 00:17:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777360653; x=1777965453; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k5vGtpZ6iOY9WVsbyHSHabLf2wtH3+nr9DrtxA/06wI=; b=PNYb8e5RpsJPXxvJsSwH0ozg79/1ETsmit0KRTPSI0UEgAs6TVasDoyS0rD0cuxRMN 0hC3W5oVMYtd8tnk7teQy9iRk8bLVqZzlAdbhD9nb7SpV2ihF5CxVeYXnHKfDSGizSC0 F90NgLy1Oh6jibjiDtyXzQ9NBXX8TOdeA7degt/Q42I6Jd+GBGstq+RDqkYUc1hREijf Ubeh6HYrKj9QVS6qE4aC8fVvHRehdw3RUUiIdsrF4M+L1YVorXc7XSqRyYWJzTdL+K9v 40dvppapDKEfSULQ96gC37btgisjq7CNeycz2r+HlEFXo4sTwlWlgoBGLZhZ2QoBSbld kBVg== X-Gm-Message-State: AOJu0YypK2kGUcmCUgy/oZFAULpehGPUmlMKdJmDEdPh8sH6iuDhUROc 9ZTqWW7GPDUyJcIHKVMW1JLsZinrHWz2fXrAoLQAHxJ6OsBpjsGrgR5HPQKNOHTYJqfWUsS6fwV 4EhVatCHcT4jdukHqI3w+6HeXFeeOSt/H7VKMMY1GZtCjTCn1jdlPDA== X-Gm-Gg: AeBDieuVtuFPJu7CR0DbvZjeyWIk3sGLbeH1tf6UrrnCV8a1jveoaXSw0Bo3XGZhRaw 7UarqS23ny9VaeBxwq5VDTqOCExlqAbsj+8LlFNTScFqEqpq8AhpEuMIBYX2Q5FFy9KsaQxCMDK NAO1qj8MOlTKFM2MmMzswvx+nkDIWlVhbqZJiLy04087sZbmCAoPEzY7liRRyVMMSzTkjKuR2qA w2frSQLANbm/K0icQhWtks8kqGRTI2p9YGmiDepL83IdBriaWSILNpR+fIf2E1z26J5DbTMeJHs 84Ygdm6D2ushhKo4Bv1PsmJwrW5ZS8XUtcPIMUfymWWNjWTr11RWKhYgv+4fO69nnfMcnzNt5HA +AJDYi9hbU+Sl7HjA4P4GQkDH0ZMF7TAsK1JO+aD9N9caK5pGU0nf9Wdfq3Gt X-Received: by 2002:a5d:5f54:0:b0:43f:dd91:b022 with SMTP id ffacd0b85a97d-44649c996f4mr3108605f8f.35.1777360653038; Tue, 28 Apr 2026 00:17:33 -0700 (PDT) X-Received: by 2002:a5d:5f54:0:b0:43f:dd91:b022 with SMTP id ffacd0b85a97d-44649c996f4mr3108522f8f.35.1777360652391; Tue, 28 Apr 2026 00:17:32 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463d5ee9ecsm4308498f8f.16.2026.04.28.00.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 00:17:31 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 04/13] Makefile: Remove non-standard $(FLAGS) variable Message-ID: <20260428091728.3b00b5be@elisabeth> In-Reply-To: <20260421032338.1909084-5-david@gibson.dropbear.id.au> References: <20260421032338.1909084-1-david@gibson.dropbear.id.au> <20260421032338.1909084-5-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 28 Apr 2026 09:17:31 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eaHmZkRnn47k-u8qr4bb6dKhSnNXXhhZM9IDYSKypBs_1777360653 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KJ2N6VOMM5XIUNKP5K76KLQ35CO6MC44 X-Message-ID-Hash: KJ2N6VOMM5XIUNKP5K76KLQ35CO6MC44 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 21 Apr 2026 13:23:29 +1000 David Gibson wrote: > FLAGS was introduced over the more standard CFLAGS, because there are some > options we can't compile without, so overriding CFLAGS from the command > line wasn't practical. We've now better dealt with that using > BASE_CPPFLAGS, so there's no real need for FLAGS any more. Replace it > with the more conventional CFLAGS, which now *can* be reasonable overridden > from the command line. > > Signed-off-by: David Gibson > --- > Makefile | 21 ++++++++++----------- > test/build/build.py | 4 ++-- > 2 files changed, 12 insertions(+), 13 deletions(-) > > diff --git a/Makefile b/Makefile > index e89e5556..1e5f0282 100644 > --- a/Makefile > +++ b/Makefile > @@ -36,8 +36,8 @@ BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE \ > -DVERSION=\"$(VERSION)\" > CPPFLAGS := $(FORTIFY_FLAG) -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS) > > -FLAGS := -Wall -Wextra -Wno-format-zero-length -Wformat-security > -FLAGS += -pedantic -std=c11 -O2 -pie -fPIE > +WARNINGS = -Wall -Wextra -Wno-format-zero-length -Wformat-security > +CFLAGS = -pedantic -std=c11 -O2 -pie -fPIE $(WARNINGS) > > PASST_SRCS = arch.c arp.c bitmap.c checksum.c conf.c dhcp.c dhcpv6.c \ > epoll_ctl.c flow.c fwd.c fwd_rule.c icmp.c igmp.c inany.c iov.c ip.c \ > @@ -66,7 +66,7 @@ ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) > endif > > ifeq ($(shell :|$(CC) -fstack-protector-strong -S -xc - -o - >/dev/null 2>&1; echo $$?),0) > - FLAGS += -fstack-protector-strong > + CFLAGS += -fstack-protector-strong > endif > > prefix ?= /usr/local > @@ -85,7 +85,7 @@ endif > > all: $(BIN) $(MANPAGES) docs > > -static: FLAGS += -static > +static: CFLAGS += -static > static: CPPFLAGS += -DGLIBC_NO_STATIC_NSS > static: clean all > > @@ -96,12 +96,11 @@ seccomp_repair.h: seccomp.sh $(PASST_REPAIR_SRCS) > @ ARCH="$(TARGET_ARCH)" CC="$(CC)" ./seccomp.sh seccomp_repair.h $(PASST_REPAIR_SRCS) > > passt: $(PASST_SRCS) $(HEADERS) > - $(CC) $(FLAGS) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) $(PASST_SRCS) -o passt $(LDFLAGS) > + $(CC) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) $(PASST_SRCS) -o passt $(LDFLAGS) > > -passt.avx2: FLAGS += -Ofast -mavx2 -ftree-vectorize -funroll-loops > +passt.avx2: CFLAGS += -Ofast -mavx2 -ftree-vectorize -funroll-loops > passt.avx2: $(PASST_SRCS) $(HEADERS) > - $(CC) $(filter-out -O2,$(FLAGS)) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) \ > - $(PASST_SRCS) -o passt.avx2 $(LDFLAGS) > + $(CC) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) $(PASST_SRCS) -o passt.avx2 $(LDFLAGS) > > passt.avx2: passt > > @@ -109,16 +108,16 @@ pasta.avx2 pasta.1 pasta: pasta%: passt% > ln -sf $< $@ > > qrap: $(QRAP_SRCS) passt.h > - $(CC) $(FLAGS) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) -DARCH=\"$(TARGET_ARCH)\" $(QRAP_SRCS) -o qrap $(LDFLAGS) > + $(CC) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) -DARCH=\"$(TARGET_ARCH)\" $(QRAP_SRCS) -o qrap $(LDFLAGS) > > passt-repair: $(PASST_REPAIR_SRCS) seccomp_repair.h > - $(CC) $(FLAGS) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) $(PASST_REPAIR_SRCS) -o passt-repair $(LDFLAGS) > + $(CC) $(CFLAGS) $(BASE_CPPFLAGS) $(CPPFLAGS) $(PASST_REPAIR_SRCS) -o passt-repair $(LDFLAGS) > > valgrind: EXTRA_SYSCALLS += rt_sigprocmask rt_sigtimedwait rt_sigaction \ > rt_sigreturn getpid gettid kill clock_gettime \ > mmap|mmap2 munmap open unlink gettimeofday futex \ > statx readlink > -valgrind: FLAGS += -g > +valgrind: CFLAGS += -g > valgrind: CPPFLAGS += -DVALGRIND > valgrind: all > > diff --git a/test/build/build.py b/test/build/build.py > index e3de8305..7c9cbb44 100755 > --- a/test/build/build.py > +++ b/test/build/build.py > @@ -60,7 +60,7 @@ def test_make(target: str, expected_files: list[str]) -> None: > with clone_sources(): > for p in ex_paths: > assert not p.exists(), f"{p} existed before make" > - sh(f'make {target} CFLAGS="-Werror"') > + sh(f'make {target}') > for p in ex_paths: > assert p.exists(), f"{p} wasn't made" > sh('make clean') > @@ -90,7 +90,7 @@ def test_install_uninstall() -> None: > progs = ['passt', 'pasta', 'qrap'] > > # Install > - sh(f'make install CFLAGS="-Werror" prefix={prefix}') > + sh(f'make install prefix={prefix}') Here, and above: I don't understand what (if anything) implies -Werror now. -- Stefano