From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Sk5Hi5rd; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id BFD905A0265 for ; Tue, 28 Apr 2026 09:17:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777360662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0I3Bq0Uksf+bmECInryUe7plqgPaGkclmRUsKDfLq8=; b=Sk5Hi5rdzmjKRec57211gQqZ93FqzTS8C21pY9wBtG7Yzsvdb42yoZFq7aLmwubHOu7AdP 9dwDIfheZrO92wGaqAYiqV3+Ozc9o8fRXgySpQzQ5SNFKp/JMuUfKJOvas1n887MqBcLKN 3XrnLB0wbfebc6LHWEgG66KIvF0AavQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-j0UVPxK0Ndy3WoeKZ80UiQ-1; Tue, 28 Apr 2026 03:17:41 -0400 X-MC-Unique: j0UVPxK0Ndy3WoeKZ80UiQ-1 X-Mimecast-MFC-AGG-ID: j0UVPxK0Ndy3WoeKZ80UiQ_1777360660 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4837b6f6b93so117040215e9.3 for ; Tue, 28 Apr 2026 00:17:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777360659; x=1777965459; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b0I3Bq0Uksf+bmECInryUe7plqgPaGkclmRUsKDfLq8=; b=hhNxtXY+q335Z//4C+ibIRldZLVC6YOY0r3ssm9kGSWD/pD2pXkkdM058EHNTp5krw xl+6ZMIY1ZSx1WYxg926zyQmk8jPm9N6/Myd4pEVzLdJN5Z4agze97LCibR8vck48vyK 0s0W5Po8fnon7LgN4XhiUp74uQVA58+NfXHlMl84qJMjiBG4ICO9/1I/IKl86ZTGOa7O a4EX16I+Lr5UPLCWCQ3jM+ew5Fx1OZA3PP75QNlvsC4eL+WVDfrifZNfLXCMll+bZupc AUI4/LJ6rd6tQYw5nY9VtY368GoS/m+zfYRu+T9tkFcqc+3pZpN9Am+IqA1++K0Uq9cK NYTQ== X-Gm-Message-State: AOJu0YxBulLpfEcd2JAqJhiERr8CXD7HBcRlOOEx4KSok7N6QkGkQose JGl0Fq25nV/IT7EzIwio7vlrwzvesBmDfbHuK18LHkwy7HOCUcgbzf0TdnoOTzrILwwK46KXZGh 9ReH2PtxZYej557nmUwE2vdJdCylTJvlpO99a8AV8fu7AeRcD4harTr0p+VpGGQ== X-Gm-Gg: AeBDieuOaPiqmO34/QXnAHbcVQFy8pzj+MtI0oCGt9o3anIZJJ6TbTwhPKTH6R9QLaI RqsPxYFIBQGkZohI3Lm4bg/K9vCboYJWf5VVzf+DozlSwxlAyk3T3b6yTYjZrfWpnFQC4Hv85xZ ow93DMLnTw/hzV4jMCwd7xAbIcVp63BY0uyAtp/PkuARJhbjQ7NIKaBQTOGl7BE5excB+Z+zyqS WjYUROXchdV/G97gzyYM2m0CtYhgu702YYeZGSZyMJOFeK6Hz/cLGz/UTDvHZmbU+VSYgtxcwiP ff5xz0CLWOqaqMqgATg+ZcwnVf5cG1+/Y4jHT3GptH+fOWnMhbFxk5yrZuyp2KilYclAGJLR5Sx nxIcwQ3J1jwv87aVEfeIVi3cyPlcDKKPMeStSvN1U2gqU6NTrpZhssGG4GGb9 X-Received: by 2002:a05:600c:8b2f:b0:488:8bdd:cfcc with SMTP id 5b1f17b1804b1-48a779ab7c9mr31631325e9.0.1777360659609; Tue, 28 Apr 2026 00:17:39 -0700 (PDT) X-Received: by 2002:a05:600c:8b2f:b0:488:8bdd:cfcc with SMTP id 5b1f17b1804b1-48a779ab7c9mr31630875e9.0.1777360659132; Tue, 28 Apr 2026 00:17:39 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a773af544sm38333015e9.6.2026.04.28.00.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 00:17:38 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 13/13] qrap: Run static checkers Message-ID: <20260428091736.5239794b@elisabeth> In-Reply-To: <20260421032338.1909084-14-david@gibson.dropbear.id.au> References: <20260421032338.1909084-1-david@gibson.dropbear.id.au> <20260421032338.1909084-14-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 28 Apr 2026 09:17:38 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AKFpb9e_Z3dAK43rs-q7UYLyGvgwEzDLkE6eBQnObD4_1777360660 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: K22H5CRZE4LUG2WMJYYXGWLRPL7L7APP X-Message-ID-Hash: K22H5CRZE4LUG2WMJYYXGWLRPL7L7APP X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 21 Apr 2026 13:23:38 +1000 David Gibson wrote: > Run the static checkers on qrap as well as on passt-repair and passt. This > shows a number of minor warnings, which we fix. This is actually for qrap only, so I would drop it. See also 8346216c9adf ("Makefile: Simplify exclusion of qrap from static checks") and 988a4d75f894 ("Makefile: Exclude qrap.c from clang-tidy checks") It's not really something we maintain and the next commit touching qrap should really remove the whole thing instead. The "soon" in 988a4d75f894 was almost two years ago. My worry is that if we enable static checkers here we risk having to waste time on warnings in the near future. Other than this and the comment to 4/13 the series looks good to me, and I'm basing v6 of "RFC: Dynamic configuration update implementation" on it. -- Stefano