From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Yra+Ki4x; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 393BB5A0265 for ; Wed, 06 May 2026 13:58:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778068712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpIoHgYjIUsbhSZ6APpM2f6JsnQq8NAvi6v+Uo8Uuh0=; b=Yra+Ki4xEQvMpM2FqayUrmPoMQtbJ6now21wrNgSst42XYSgB93R3GL8qc6ARzGHXAZYLH 140QXeqgHujrXu22KYpH7xSC9EC8F12zUgB76YqoJq59V/wWRp7Pu4offDzP4Xgtyptn+7 CvmzyK73khAee4JoDzodmv7I986qzpw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-r5P7_R49PqiRkQeQzFW88g-1; Wed, 06 May 2026 07:58:31 -0400 X-MC-Unique: r5P7_R49PqiRkQeQzFW88g-1 X-Mimecast-MFC-AGG-ID: r5P7_R49PqiRkQeQzFW88g_1778068709 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d7730e9e3so3986903f8f.2 for ; Wed, 06 May 2026 04:58:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778068709; x=1778673509; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cpIoHgYjIUsbhSZ6APpM2f6JsnQq8NAvi6v+Uo8Uuh0=; b=NaGxbYsWuvTXeqyuFsY6R/+UZgrt1kpNhavnkmCXFn9MvWbbpTgrLOvBI9N64ZXZgZ CXeK8etehEqENKzx/zJ/XxRiunseHsr/zkAzHd0UDo9rrms0c1DuhnJooiegKes8pRD7 nqiKQFK/xGTVx1DJpFCPAT/PIiOfDmBY9KPjxs4I47o4Xs4tj7+mHhYTg6ZZYgWsqWA8 eZ84SS1bOdxmZFJ+ukSQBsmHKPgHoWl2H/XVPliFtKg3SbpTKqePPI78OCODIKy9Uc4C yJdr2YDHcIoa25MpssuQmdiLgEJ0IpK4v/iu8y3C99uSCq36PL8QS/s9ljh5fh8zoypg ZNgQ== X-Gm-Message-State: AOJu0YyXnfantEB1L5NgRsXcEQHPm2vHSTdrZgr8WVVGVJUJzww/5fLc BLheg9xI7qYp2HFyhyWsz7XJIoNxGq/+CjK9DJcdvt4TI5oGbW+K2gSwosrXLXF8imi8sppd3nV z91KXna2IPbxNMW/NNSiwHenAJm+FGen6xqwBmLNqrxM0Ge4qLrkJcg== X-Gm-Gg: AeBDietGPDszu1CJvT+uBvbdCJOyzGuHt/nEhma9Ol2J+S0k/JJ9lBVxlnMrIwKFGvt 4Z5l7pG3Q1NmEX5q3g46vfQse/m7HTiWLXy0iD8Y3Qn7ar0YJM/Maw/H1VC9mtilj3IhDGTWw7Q dW54gDQYGHb5ax7sREUrjr1q7VpongH1MM9BLjH9ga/3YZufnJr3znTnLr0e8JN5tfLdSbciBvQ 7+4Dai4B/Bj+ienP8Sc2T4OZ4qDlIRfl+y74tkxEGCLQqyF61Ie/3MxH9FJ5BVDooubLWI5jHj0 hajupCnf+yI5LfOZ25WHVVdqQqHoqX7ZWDDnjbuUd0fFiWeCMR/Cp3JFxbp6E/gvZJh+EUKGk2u xdSDfHo5r38FOKftcgcfCMG9QXwUu6N6nwxIzVPFd4GU1WPZ1735mkvWXe1Yp X-Received: by 2002:a05:6000:2403:b0:441:2381:b630 with SMTP id ffacd0b85a97d-4515c575330mr5439288f8f.24.1778068708829; Wed, 06 May 2026 04:58:28 -0700 (PDT) X-Received: by 2002:a05:6000:2403:b0:441:2381:b630 with SMTP id ffacd0b85a97d-4515c575330mr5439238f8f.24.1778068708279; Wed, 06 May 2026 04:58:28 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055d36dacsm11940605f8f.32.2026.05.06.04.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 04:58:27 -0700 (PDT) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v9 10/23] pesto, conf: Have pesto connect to passt and check versions Message-ID: <20260506135826.2cea29b5@elisabeth> In-Reply-To: <968e8019-e98c-48bb-927b-7f7b2f37deff@redhat.com> References: <20260506092241.1607480-1-sbrivio@redhat.com> <20260506092241.1607480-11-sbrivio@redhat.com> <968e8019-e98c-48bb-927b-7f7b2f37deff@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 06 May 2026 13:58:27 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lQUVwEcU2MK67OIn80pgEb61BoQHbl3ivHldG3ImKGo_1778068709 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VDI3QP4NY4UELJJS73XHT636E2BNCALJ X-Message-ID-Hash: VDI3QP4NY4UELJJS73XHT636E2BNCALJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 6 May 2026 12:57:21 +0200 Laurent Vivier wrote: > On 5/6/26 11:22, Stefano Brivio wrote: > > From: David Gibson > >=20 > > Start implementing pesto in earnest. Create a control/configuration > > socket in passt. Have pesto connect to it and retrieve a server greeti= ng > > Perform some basic version checking. > >=20 > > Signed-off-by: David Gibson > > [sbrivio: Avoid potential recursive calling between conf_accept() and > > conf_close(), reported by clang-tidy] > > [sbrivio: In conf(), check we're not exceeding sizeof(c->control_path) > > instead of sizeof(c->socket_path), and, in pesto's main(), print > > argv[optind] instead of argv[1] to indicate an invalid socket path, > > both reported by Jon Maloy] > > [sbrivio: In pesto's main(), drop unnecessary newline from error > > message, reported by Laurent] > > [sbrivio: Don't use SOCK_NONBLOCK on accept4(), as that only applies > > to the *new* file descriptor, which we don't want -- set O_NONBLOCK > > on the listening file descriptor using fcntl()] > > [sbrivio: Switch to protocol version 1, and reflect the true magic > > behind pesto, i.e. basil, into the magic string] =20 >=20 > But the real value is in pine nuts (110 =E2=82=AC/kg here). Wow, I hadn't realised. They seem to be half that price here, but still: > (I make mine with bear's garlic and almonds) ...yeah, we should definitely aim at compatibility. --=20 Stefano