From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=QavBRAdd; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 6DC225A026E for ; Mon, 11 May 2026 12:03:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1778493804; bh=LoGt9Y1snjD07xS14LOTgd3a5jn1LRzPhCkdvHUr7uU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QavBRAdd/eRLTDnYRpKmWZBfXxrqmSSCXPkMxr22M6cgPONs4AG0zRYo3RGoF7y1y EuJ/m5H2lekok2u0PiilqYGmtwGqWzF8CJHv785A+6HMrdKvO5X/knFN7smAsrHBP4 geA5TqvDMxTPdkjh4TJ59PtBVklLMmHbw3G8QIb2uo1KGi1B7/JFp54mUPuEg+cAor dq03AQ3UYJz2L+kmOwmK3Ii9IT9WjrqlXZ5LF/cO9eXAwYCYoDf6kxWA1mAHvb2rfE AUDdAR7fe4gDpLkDY7k1N5D8767r6r9GG00PfehrS0EvcG8TH4J+dnK1H1giuBFwnQ tKzbtpjCVy/7g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gDZzw20Bmz4wJr; Mon, 11 May 2026 20:03:24 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 8/8] clang-tidy: Suppress some new unhelpful new warnings Date: Mon, 11 May 2026 20:03:22 +1000 Message-ID: <20260511100322.1016757-9-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260511100322.1016757-1-david@gibson.dropbear.id.au> References: <20260511100322.1016757-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: MM2MLADKMYCZHVC5INYHWODG6SFAFF2D X-Message-ID-Hash: MM2MLADKMYCZHVC5INYHWODG6SFAFF2D X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: clang-tidy 22.1.4 (or thereabouts) introduced some new warning categories that while theoretically useful, trip in too many silly occasions to be useful. Suppress them. Signed-off-by: David Gibson --- .clang-tidy | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index 773121f5..9ba43bf0 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -86,6 +86,17 @@ Checks: # #if directives. Don't insist on #ifdef instead. - "-readability-use-concise-preprocessor-directives" + # clang-tidy, at least version 22.1.4 seems to generate a heap of + # false positives for this warning, asking us to make things + # static that are already used in other modules. + - "-misc-use-internal-linkage" + + # Warning about bool/int conversions could sometimes be useful. + # Unfortunately (as of clang-tidy 22.1.4) it warns in some really + # dumb situations, like not allowing !, && etc. on bool inputs to + # be treated directly as a bool. + - "-readability-implicit-bool-conversion" + WarningsAsErrors: "*" HeaderFileExtensions: - h -- 2.54.0