From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v3 00/12] Improvements to static checker invocation
Date: Tue, 12 May 2026 15:52:44 +1000 [thread overview]
Message-ID: <20260512055256.1800449-1-david@gibson.dropbear.id.au> (raw)
While working on pesto, I ran into a number of awkward errors with the
static checkers. This series reworks the invocation of the checkers
in a way that will let us deal with that. As a bonus, it also gives
us static checking for passt-repair. It also a number of other
cleanups to the Makefile that seemed natural along the way.
v3:
- Rework changes to $(FLAGS) so they're much less likely to have
side effects we're not ready for.
v2:
- Fixed nasty test failure in test/build/build.py
David Gibson (12):
Makefile: Use make variables for static checker configuration
Makefile: Make conditional definition of $(BIN) clearer
Makefile: Use common binary compilation rule
Makefile: Remove unhelpful $(HEADERS) variable
Makefile: Add header dependencies for secondary binaries
Makefile: Split $(FLAGS) into cpp and cc components
cppcheck, clang-tidy: Static checkers don't need non-preprocessor
flags
Makefile: Split static checker targets
passt-repair: Split out inotify handling to its own function
passt-repair: Simplify construction of Unix path from inotify
passt-repair: Run static checkers
pesto: Run static checkers on pesto sources
Makefile | 135 ++++++++++++++++++++++++--------------
linux_dep.h | 2 +-
passt-repair.c | 171 +++++++++++++++++++++++++++----------------------
pesto.c | 1 -
4 files changed, 182 insertions(+), 127 deletions(-)
--
2.54.0
next reply other threads:[~2026-05-12 5:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 5:52 David Gibson [this message]
2026-05-12 5:52 ` [PATCH v3 01/12] Makefile: Use make variables for static checker configuration David Gibson
2026-05-12 5:52 ` [PATCH v3 02/12] Makefile: Make conditional definition of $(BIN) clearer David Gibson
2026-05-12 5:52 ` [PATCH v3 03/12] Makefile: Use common binary compilation rule David Gibson
2026-05-12 5:52 ` [PATCH v3 04/12] Makefile: Remove unhelpful $(HEADERS) variable David Gibson
2026-05-12 5:52 ` [PATCH v3 05/12] Makefile: Add header dependencies for secondary binaries David Gibson
2026-05-12 5:52 ` [PATCH v3 06/12] Makefile: Split $(FLAGS) into cpp and cc components David Gibson
2026-05-12 5:52 ` [PATCH v3 07/12] cppcheck, clang-tidy: Static checkers don't need non-preprocessor flags David Gibson
2026-05-12 5:52 ` [PATCH v3 08/12] Makefile: Split static checker targets David Gibson
2026-05-12 5:52 ` [PATCH v3 09/12] passt-repair: Split out inotify handling to its own function David Gibson
2026-05-12 5:52 ` [PATCH v3 10/12] passt-repair: Simplify construction of Unix path from inotify David Gibson
2026-05-12 5:52 ` [PATCH v3 11/12] passt-repair: Run static checkers David Gibson
2026-05-12 5:52 ` [PATCH v3 12/12] pesto: Run static checkers on pesto sources David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512055256.1800449-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).