From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Tgxl/Qll; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id AB0F15A0262 for ; Sat, 16 May 2026 17:46:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778946408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6MbAglIpq2YRue2xAWDR6dbO2LDxkIzGyI8XcAoHHgA=; b=Tgxl/Qll01iioPN1nyGq+vQK9p3B0qh2FpymRPwzXH2kxATc+VcqJzBtJgF8dUJhuYissK ps2AjU2x/LEeb12nHt/FMF4QeuFyJaPZA9j8Ob71BbbcfoaS0n/bO1BGdJOfIRLXHgeei9 tEFHkPQdK0abEfxoFbVKoWWM4eabbrY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-ShL7CPeNODG_ZfaETVBO0g-1; Sat, 16 May 2026 11:46:47 -0400 X-MC-Unique: ShL7CPeNODG_ZfaETVBO0g-1 X-Mimecast-MFC-AGG-ID: ShL7CPeNODG_ZfaETVBO0g_1778946406 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-44a122a5128so680231f8f.0 for ; Sat, 16 May 2026 08:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778946406; x=1779551206; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6MbAglIpq2YRue2xAWDR6dbO2LDxkIzGyI8XcAoHHgA=; b=kavQvWKAVEC+Vh1YDXN1kRZmo8PSG5WW7Hm//0nit3j7Spj2mzkRYrsXh5r3xWsfQa Ym1L6ohkG7qBVU8N7HRqJMpBuUuqKSTUaaAe09ueoKJZBbgcI9mdYEjtS7kGlXKCckHs EiMwYnq6LEpAoRqwD48HB6tuq/My70mpEgHYwGyrpSh/nDwhaF8MfZs2JpNk7Tqmd9wJ pnCiy5xydtZmyd+unMyKrDNIDskCg1rp9DyFdJKa8mZ4trxncEeXUOl1/UNNWUAyioP7 gPRL5TraPVMmZJytI7VLfAmRYL2fFop62yCx3Nms8WZYoVJ+w+p4E9HEBzb9ovtQZFxW LtFA== X-Gm-Message-State: AOJu0Yx1wqXkdBWIes24o5c/0XYNsD+bhjULwg+v1Q9GaicRTOW8pj5u 9RAvI/WKulD48yU6M3/8JGuwdnweCdIQQjb30+QmhGVEyR2hZYT6pNuIhigrm7TF4ye+RiDZRyU xrR0kH8swYy9+kij9POfRJoeVQpEj2MRDfwoAwGhLlaZWfezTHLf8dw== X-Gm-Gg: Acq92OFj9sS8PfGpRAjyVHZxY1h2/O20QR9PRMRtmjVnuVOFNTjrYwYYt+zBHPRAZUd mi83TfInDrjmSkkFNNxZVRaTHzhXQk3+NeskNHzon1PBEx1D6Q7PJqILVzUIcGdZG1ah25DclnF fMHnserZ1bcf4bTg9+iT5SuaxON2K3veC2sNxdNn56vpSKYkRUaFpvTzn7rhKl01p1vuq6OA9rl t6O0wWAQv0S9cfnL6vYw8iaHIbeymPmJ6LuxrMIZowmlgOp91JMVQvJxV+EPTFPGuyt22DMTPPr a0/Uwe/aqvIhPSp0Cf34pKDC6zjp2gLUtUXzl8ecp+gil+YnVzH9/Yntr5Ko6buCl+7BwFLapEe yt0ypI5a8UAPbU/PDfWqwTgka6RrsfGlfXfmA/JwTpGGd/OQs+g== X-Received: by 2002:a05:600c:8901:b0:48e:526e:1040 with SMTP id 5b1f17b1804b1-48fe63021f9mr102674845e9.23.1778946405888; Sat, 16 May 2026 08:46:45 -0700 (PDT) X-Received: by 2002:a05:600c:8901:b0:48e:526e:1040 with SMTP id 5b1f17b1804b1-48fe63021f9mr102674575e9.23.1778946405433; Sat, 16 May 2026 08:46:45 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4c90b27sm141947075e9.8.2026.05.16.08.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 08:46:44 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/3] Fix broken build with -DNDEBUG Message-ID: <20260516174643.6c0c5e24@elisabeth> In-Reply-To: <20260515041312.317644-1-david@gibson.dropbear.id.au> References: <20260515041312.317644-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Sat, 16 May 2026 17:46:44 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TPaZ3cdz7s3ZB-RTuDBDvQVKPBx1uNo06C66heysb4Q_1778946406 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NQZ2IBZS4V3T2K6RUBXSEGB2XLKWGNZI X-Message-ID-Hash: NQZ2IBZS4V3T2K6RUBXSEGB2XLKWGNZI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jan Palus X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 15 May 2026 14:13:09 +1000 David Gibson wrote: > Fix the trivial but nasty with -DNDEBUG builds recently reported by > Jan Palus. While we're there, add a couple of extra build tests. > These wouldn't actually catch this problem, but they're better than > nothing and do catch the #include problem I also spotted. > > David Gibson (3): > test: Extend exeter build tests to cover more recent binaries > Fix build with -DNDEBUG > test: Add test for builds with -DNDEBUG Applied, with 2/3 amended as suggested by Jan. Jan, I'll let you know once I tag a new release so that you can drop your no-assert.patch. I'm trying to figure out, first, a couple of potential regressions (https://bugs.passt.top/show_bug.cgi?id=202, https://bugs.passt.top/show_bug.cgi?id=203) so that those can be fixed in the new release as well, but it might be a while before I even get to look into them, and I won't wait more than a few days with a new release in any case. -- Stefano