From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 2/3] tap: Report accept() errors
Date: Mon, 18 May 2026 13:22:42 +1000 [thread overview]
Message-ID: <20260518032243.823768-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260518032243.823768-1-david@gibson.dropbear.id.au>
Currently, if accept4() fails in tap_listen_handler(), we carry on as if
it succeeded. Something will probably fail shortly down the line, but
that's needlessly confusing. Report an error instead.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
tap.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tap.c b/tap.c
index e7cac9df..660f1cb6 100644
--- a/tap.c
+++ b/tap.c
@@ -1491,6 +1491,10 @@ void tap_listen_handler(struct ctx *c, uint32_t events)
}
c->fd_tap = accept4(c->fd_tap_listen, NULL, NULL, SOCK_CLOEXEC);
+ if (c->fd_tap < 0) {
+ warn_perror("Error accepting tap client");
+ return;
+ }
if (!getsockopt(c->fd_tap, SOL_SOCKET, SO_PEERCRED, &ucred, &len))
info("accepted connection from PID %i", ucred.pid);
--
2.54.0
next prev parent reply other threads:[~2026-05-18 3:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 3:22 [PATCH v2 0/3] More caution with NONBLOCK flag on Unix sockets David Gibson
2026-05-18 3:22 ` [PATCH v2 1/3] treewide: Add SOCK_CLOEXEC to accept() calls that are missing it David Gibson
2026-05-18 3:22 ` David Gibson [this message]
2026-05-18 3:22 ` [PATCH v2 3/3] conf, repair, tap: Document reasons for blocking Unix sockets David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518032243.823768-3-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).