From: Anshu Kumari <anskuma@redhat.com>
To: anskuma@redhat.com, sbrivio@redhat.com, passt-dev@passt.top
Cc: lvivier@redhat.com, jmaloy@redhat.com, david@gibson.dropbear.id.au
Subject: [PATCH 2/6] conf: Add --dhcp-boot command-line option
Date: Mon, 18 May 2026 18:49:58 +0530 [thread overview]
Message-ID: <20260518132002.418296-3-anskuma@redhat.com> (raw)
In-Reply-To: <20260518132002.418296-2-anskuma@redhat.com>
Introduce the --dhcp-boot flag that sets the boot file URL for
network boot specially for ipxe. This patch adds the option
storage and CLI parsing.
Link: https://bugs.passt.top/show_bug.cgi?id=192
Signed-off-by: Anshu Kumari <anskuma@redhat.com>
---
conf.c | 9 +++++++++
passt.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/conf.c b/conf.c
index 2624e58..61a393f 100644
--- a/conf.c
+++ b/conf.c
@@ -618,6 +618,7 @@ static void usage(const char *name, FILE *f, int status)
" a single, empty option disables the DNS search list\n"
" -H, --hostname NAME Hostname to configure client with\n"
" --fqdn NAME FQDN to configure client with\n"
+ " --dhcp-boot URL Boot file URL for network boot\n"
" --dhcp-opt CODE,VAL Set DHCP option by code\n");
if (strstr(name, "pasta"))
FPRINTF(f, " default: don't use any search list\n");
@@ -846,6 +847,8 @@ static void conf_print(const struct ctx *c)
info(" router: %s",
inet_ntop(AF_INET, &c->ip4.guest_gw,
buf, sizeof(buf)));
+ if (c->dhcp_boot[0])
+ info(" boot file: %s", c->dhcp_boot);
for (i = 0; i < c->custom_opts_count; i++)
info(" option %u: %s",
c->custom_opts[i].code,
@@ -1239,6 +1242,7 @@ void conf(struct ctx *c, int argc, char **argv)
{"migrate-no-linger", no_argument, NULL, 30 },
{"stats", required_argument, NULL, 31 },
{"conf-path", required_argument, NULL, 'c' },
+ {"dhcp-boot", required_argument, NULL, 32 },
{"dhcp-opt", required_argument, NULL, 33 },
{ 0 },
};
@@ -1472,6 +1476,11 @@ void conf(struct ctx *c, int argc, char **argv)
die("Can't display statistics if not running in foreground");
c->stats = strtol(optarg, NULL, 0);
break;
+ case 32:
+ if (snprintf_check(c->dhcp_boot, sizeof(c->dhcp_boot),
+ "%s", optarg))
+ die("Boot file name too long: %s", optarg);
+ break;
case 33: {
unsigned long code;
const char *comma;
diff --git a/passt.h b/passt.h
index acb57dd..2354a0f 100644
--- a/passt.h
+++ b/passt.h
@@ -262,6 +262,7 @@ struct ctx {
char hostname[PASST_MAXDNAME];
char fqdn[PASST_MAXDNAME];
+ char dhcp_boot[PATH_MAX];
#define MAX_CUSTOM_DHCP_OPTS 32
--
2.54.0
next prev parent reply other threads:[~2026-05-18 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 13:19 [PATCH 0/6] Add --dhcp-boot and --dhcp-opt options Anshu Kumari
2026-05-18 13:19 ` [PATCH 1/6] conf: Add --dhcp-opt command-line option Anshu Kumari
2026-05-18 13:19 ` Anshu Kumari [this message]
2026-05-18 13:19 ` [PATCH 3/6] dhcp: Add option type table and value parser Anshu Kumari
2026-05-18 13:20 ` [PATCH 4/6] dhcp: Refactor fill_one() to operate on a generic buffer Anshu Kumari
2026-05-18 13:20 ` [PATCH 5/6] dhcp: Add option overload Anshu Kumari
2026-05-18 13:20 ` [PATCH 6/6] doc: Add --dhcp-boot and --dhcp-opt to man page Anshu Kumari
2026-05-19 6:11 ` [PATCH 5/6] dhcp: Add option overload David Gibson
2026-05-19 6:02 ` [PATCH 4/6] dhcp: Refactor fill_one() to operate on a generic buffer David Gibson
2026-05-19 5:59 ` [PATCH 3/6] dhcp: Add option type table and value parser David Gibson
2026-05-19 5:35 ` [PATCH 2/6] conf: Add --dhcp-boot command-line option David Gibson
2026-05-19 5:33 ` [PATCH 1/6] conf: Add --dhcp-opt " David Gibson
2026-05-19 5:30 ` [PATCH 0/6] Add --dhcp-boot and --dhcp-opt options David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518132002.418296-3-anskuma@redhat.com \
--to=anskuma@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).