From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=fmRPF7ot; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 71A9D5A026E for ; Wed, 20 May 2026 04:01:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1779242457; bh=h/98OrfCh4OVYJa+Njg6DhubySGV9LdicyNmblViXTM=; h=From:To:Cc:Subject:Date:From; b=fmRPF7otBH0mXiqxOkfFaB3FB3ncBzzpaOkIuPQrs9SGV32KprXLOkzVje6VCSPcX WX1iqxzF8hdhJOSm4K483f7/niKJ/Khz7PBEEn+ZFi/HyKU200W+pBAVhABuiKtohj gAnykoRAy8JwD9+ZkiR8NMS5pDwXO2cRvxY8toUrX7sajQHnmg74XWwKwgeEnvEuWE hymolDLY8ctZjC1RS9bQErttGi/gpxY7ioMf4+ti8G5B12U2OBIQE/UC6FhFywII3S wrloNomf+gXKKIkg6+0SF+JqYp+U3HPpnnhvV1sfETiB+7boPU76PNbKVBnY6Rehk4 wN6GhhAk8nlxg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gKvs52RYxz58bD; Wed, 20 May 2026 12:00:57 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH] Makefile: Remove misleading comments on BASE_*FLAGS Date: Wed, 20 May 2026 12:00:55 +1000 Message-ID: <20260520020055.13905-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: OIQJXTOE2CCFFUQ6KNXMR5ESXQBYSTFK X-Message-ID-Hash: OIQJXTOE2CCFFUQ6KNXMR5ESXQBYSTFK X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I added these comments attempting to describe the difference between BASE_CFLAGS and CFLAGS. However, the description given isn't really accurate, and I'm not even sure the concept I'm trying to describe is coherent. Just remove it. Suggested-by: Stefano Brivio Signed-off-by: David Gibson --- Makefile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Makefile b/Makefile index c4af57b4..0a0a60b0 100644 --- a/Makefile +++ b/Makefile @@ -30,15 +30,11 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > / FORTIFY_FLAG := -D_FORTIFY_SOURCE=2 endif -# Mandatory preprocessor flags that won't be overridden with $(CPPFLAGS) -# FIXME: Could some of these be default, rather than required? BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE $(FORTIFY_FLAG) BASE_CPPFLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE) BASE_CPPFLAGS += -DVERSION=\"$(VERSION)\" BASE_CPPFLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS) -# Mandatory compiler flags that won't be overridden with $(CFLAGS) -# FIXME: Could some of these be default, rather than required? BASE_CFLAGS := -std=c11 -pie -fPIE -O2 BASE_CFLAGS += -pedantic -Wall -Wextra -Wno-format-zero-length -Wformat-security -- 2.54.0