From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=epFYc2qT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id CF1755A0262 for ; Wed, 20 May 2026 02:38:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779237488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQ54Ujaej840LHIfzIQThDSy3XKIObOKEnEIHujqDc0=; b=epFYc2qTDaZnoaVWxCN1RqFK2gx4IKGndRjr7RpBquwHw9S7kK47+kGJpq7OzLC1VitVGY WDeQzFcdxR+R+0Z0q7I3vTsd0OVxwpcYA0b0MByCKmvbRuCb/n9FM1wMjSUCRxG4k85SH3 rRs0h3xqIU03Ge8xfaCrmz82Ela5R9M= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-uBReuGyWOG2Hf11Z58PT7g-1; Tue, 19 May 2026 20:38:07 -0400 X-MC-Unique: uBReuGyWOG2Hf11Z58PT7g-1 X-Mimecast-MFC-AGG-ID: uBReuGyWOG2Hf11Z58PT7g_1779237487 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43ff19e54beso2796167f8f.2 for ; Tue, 19 May 2026 17:38:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779237486; x=1779842286; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hQ54Ujaej840LHIfzIQThDSy3XKIObOKEnEIHujqDc0=; b=b4QazQYD62qQatLEEi3hvQtI5dmsncA0/e/yewd07OOWNgBwreYBZlFYS++nyFLUAw zPlavctgG2Bfcq0L9vKS01ysjfxgyR/WRz5uf0y1ZIVXYMJpduU+dKTqQHQdjXRBGZPK 4FWCO+4hjl4V8oB99jpF0LMUf15vKKanF3DdC2vq9+Wb9ioKosFOvOrnsIKJNTPBwAV2 Xt1m7Rov1OpxBbTG1ipgJ7JgEsmVltFDeq3ITEbE1fRazwhFfY98+ACeB5OGXt5sBuIF JSIDK2Zj+dW2l1/IaiQ3XUPV+suu3m4D1k8dR135ddxkCnse4jsnwu33L+dgLktNg3aG zy+A== X-Gm-Message-State: AOJu0YxzJ/Dm23k1ow16jfNaIeP4wcDDXfSb/9TvOJNQZxpjnZeS1NSj 0HoO8GC1eN7lzZsf4UYoy1c/bdDOX7x3cH9qVEIaLM5zKw3+iNNojWX7A26nxngb+VQwwkvHi6o 2vuSQDy8LzPUvjDpuTWJaNcy9KJublvTdGKWwC8XcURV20u00JRE/x097zdQFzA== X-Gm-Gg: Acq92OH9uFLFIgsjaqHl+X4Y8kSSLV5K+NBZXYVDzkLz0G7JeTm4Jyx6H/hHakrEscQ cvCAP0C6/6dMIm034CasImms8HoU8HtAk58dDTZniqhJKvzU1a9p4A30lJK/p8ne0NyT3Xedc6c QMxv+9wgVKHmRNilkZWAt/IVzwQp35JuTbQIYvrisJvudnzcx4s/rG13tFx0qXxxlqtjDCUvXXA IZcUD0bA/GCgOet9UohK+5c1nhJ8HAvYlr90/VMFu4dCqCV0U/45DcecSa6TB6RL7umlY8mwl5n 4SZ5oTuZepGGPEfQulQ97wkxZou487gj5I2+fb7kOtoAEQ6WMUaw3aHEYaLESB3i8im7sz9XwIZ wDe770pzwrRt45lcSFvSsV1jjA8W2X0r9bnYbOpqwy45urdqevQ== X-Received: by 2002:a05:6000:25c4:b0:43d:184:8aa2 with SMTP id ffacd0b85a97d-45e5c589d93mr37553881f8f.16.1779237486172; Tue, 19 May 2026 17:38:06 -0700 (PDT) X-Received: by 2002:a05:6000:25c4:b0:43d:184:8aa2 with SMTP id ffacd0b85a97d-45e5c589d93mr37553853f8f.16.1779237485766; Tue, 19 May 2026 17:38:05 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe1a41sm53568658f8f.31.2026.05.19.17.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 17:38:05 -0700 (PDT) From: Stefano Brivio To: David Gibson , Anshu Kumari Subject: Re: [PATCH 0/6] Add --dhcp-boot and --dhcp-opt options Message-ID: <20260520023804.131ef7ad@elisabeth> In-Reply-To: References: <20260518132002.418296-1-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 20 May 2026 02:38:04 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8jpqxZH3jevsj-wHlucz6eXygDuffwYOiufpPakbWu0_1779237487 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: EOVICTSI7ISPBCXZNIKSMDX3RTRC22G2 X-Message-ID-Hash: EOVICTSI7ISPBCXZNIKSMDX3RTRC22G2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, jmaloy@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 19 May 2026 15:30:41 +1000 David Gibson wrote: > On Mon, May 18, 2026 at 06:49:56PM +0530, Anshu Kumari wrote: > > This series adds support for custom DHCP options in passt, enabling > > network boot (PXE/UEFI HTTP Boot) and arbitrary DHCP option injection. > > > > Two new command-line flags are introduced: > > > > --dhcp-boot URL Sets the boot file URL (DHCP option 67 and the > > legacy boot file field) > > > > --dhcp-opt CODE,VALUE > > Sets any DHCP option by numeric code, with > > type-aware parsing per RFC 2132 > > > > The DHCP reply path is extended with option overload support (RFC 2132 > > option 52), allowing options to overflow into the file and sname fields > > when the standard options area is full. > > > > *** BLURB HERE *** > > Nit: remember to remove this boilerplate that git-publish inserts :) No, no, that's from git format-patch, I swear (as somebody who doesn't use git-publish). Another detail, while at it: for some reason git send-email picked the "chain-reply" style, that is, if you look at this in a threaded email client, patch #1 is a reply to the cover letter (fine, expected) but patch #2 is a reply to patch #1 (not expected), and so on. That's the --chain-reply-to option for git send-email. You should disable that (for example in gitconfig in case you have it on there) and just use --cover-letter. -- Stefano