From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=I/SHWvRh; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 9792A5A0262 for ; Wed, 20 May 2026 18:07:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779293263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/m5TR7wj206z95PjsH9CLafIT0zEwER8RL9h6My6hA=; b=I/SHWvRh/UJK7gTJhtsoyeeK3bTsJtnDvC8rCdXTm5N14aHOUImAcasUjP3p1SoKkXmnwI JGW0xhwxnLc8vqFtdxUAIE9JSN99LXkX1GRyvo2vbkYwVTzb0GSUUa4zq7cJR8H2phzIo6 vxyBxZsO3nx+nCbkvmZxYZAfPaS6CUw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-jK7_wO39N66S6_8t-czVJA-1; Wed, 20 May 2026 12:07:40 -0400 X-MC-Unique: jK7_wO39N66S6_8t-czVJA-1 X-Mimecast-MFC-AGG-ID: jK7_wO39N66S6_8t-czVJA_1779293260 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d7730e9e3so2917181f8f.2 for ; Wed, 20 May 2026 09:07:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779293259; x=1779898059; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e/m5TR7wj206z95PjsH9CLafIT0zEwER8RL9h6My6hA=; b=X21Rq52xe2oFJLmT/B1t+8X1N4D1jHYzNUlWTYhA+yICtxRh2r2iKWRZn+5bBRUbpz pygNz3CKeGb+3imMLvdDydvTOY0dUZIXi5dzMlqJaf382jrSRxPJN4zyIZBxKT1ktAzl rr7yBCmO5H7eLy4pvaPWJZ5mEiE8DCXA4huDKxPGb2UQrvEDrFwFwAsm661X66dKS+Ui SinnJlYn6Fi2RlmyInRs8kY176LUZYDlbdOBn0hfflqlQAw9DIN5Ye/VPRBqq4W5M0k0 qfry1Xf0YRo4Oreh3KOKzhmW9U1Ch7Tb/dPhasgwMk4OEvkggpPnMk6MLvRIn2FK70k1 ykDA== X-Gm-Message-State: AOJu0YwQIGVndHZoQ+8Rwd+heDIZX79y8ucpDRfGmrSSHWCtsXxuuQ/H ScHJ1gNpju/JnFcyRqUWKXigsPoB1V/7dM0CweXigwvfgkncVwmFWKPykZXbGZ+yslRAt1lTU72 PwGYbsqibhj9foL835yXDumtAb2kCml0jZTIz7hdT6kIBFd4HIX2jhA== X-Gm-Gg: Acq92OHshhiEJc80Lo/UkP6wM7NPHl+xLZwUs/42sR1YRjdt18jVfIBua0k4Gh3D7xL 3pKEFRE4obmISf+hHCw8Nmdpigb1cKmbAAsilQy1K4tdpc6ZIoQwZ7EXmLCIF6u8PQOCnxcpTAa lKEB+Sc2sZq7p9jfSkFzTSxRIWO4Ag/hTAw2JBe9lN2eIeUGOQi3krts0VddKg0kg4PThObzw/Z mYDCSkNwW241df6HQ3tRL+Ien9KcYpGATpRcVmTw21rtlOs+cF7mbfapQFmLaAFRNx7+sIeEAIE RGZjhhlMd2lQbCH2QyLNIXF9J2qEpYHF4cpIXUvRLep9gCXIMkKe2theJumhpscKJpcb2vUqCEE lT31xvDoOKCvaWGdEEDJJ7ZXeh8ZF4ASXyt6jwq6p8J/n5/ZUVA== X-Received: by 2002:a05:6000:288c:b0:43d:761d:5423 with SMTP id ffacd0b85a97d-45e5c5af599mr39565039f8f.16.1779293259439; Wed, 20 May 2026 09:07:39 -0700 (PDT) X-Received: by 2002:a05:6000:288c:b0:43d:761d:5423 with SMTP id ffacd0b85a97d-45e5c5af599mr39564966f8f.16.1779293258876; Wed, 20 May 2026 09:07:38 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a19c2dsm55960093f8f.21.2026.05.20.09.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 09:07:38 -0700 (PDT) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v4 00/10] vhost-user: Preparatory series for multiple iovec entries per virtqueue element Message-ID: <20260520180708.275ec4de@elisabeth> In-Reply-To: <20260520173445.0658dfef@elisabeth> References: <20260513115218.1662850-1-lvivier@redhat.com> <20260520173445.0658dfef@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 20 May 2026 18:07:38 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CJ-RRC0nPK-E6vpw93X5DbqdSWf2HWZgCQX4zrIRlys_1779293260 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 6BBQGQHALNVFKEF4COINARICE7QTDESH X-Message-ID-Hash: 6BBQGQHALNVFKEF4COINARICE7QTDESH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy , David GIbson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 20 May 2026 17:34:45 +0200 Stefano Brivio wrote: > On Wed, 13 May 2026 13:52:08 +0200 > Laurent Vivier wrote: > > > Currently, the vhost-user path assumes each virtqueue element contains > > exactly one iovec entry covering the entire frame. This assumption > > breaks as some virtio-net drivers (notably iPXE) provide descriptors where the > > vnet header and the frame payload are in separate buffers, resulting in > > two iovec entries per virtqueue element. > > > > This series refactors the vhost-user data path so that frame lengths, > > header sizes, and padding are tracked and passed explicitly rather than > > being derived from iovec sizes. This decoupling is a prerequisite for > > correctly handling padding of multi-buffer frames. > > Sorry to bring (likely) bad news, but this series seems to introduce a > regression: I got the migration/rampstream_in tests fail twice in a > row, which I've never saw happening (I think I saw a single failure a > long time ago when the machine had a high CPU load, but nothing else). > > I'm currently bisecting and the bisect seems to point towards the end > of the series (probably 10/10), but I haven't finished yet. I'll keep > you posted. I haven't spotted anything that might cause issues there. Yeah, that's the one :( $ git bisect bad db798fc60f4c5869cb53168354e068fb4dabd91a is the first bad commit commit db798fc60f4c5869cb53168354e068fb4dabd91a Author: Laurent Vivier Date: Wed May 13 13:52:18 2026 +0200 vhost-user: Centralise Ethernet frame padding in vu_collect() and vu_pad() The "TCP/IPv4: sequence check, ramps, inbound" test in rampstream_in gets stuck, once the source is done with the migration, and passt on the destination just printed: Accepted TCP_REPAIR helper, PID 13 accepted connection from PID 16 I'll get captures and logs next. It seems to fail most of the times, I had two failures in a row again. -- Stefano