From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Oef+cSZb; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id D17E75A0262 for ; Wed, 20 May 2026 23:23:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779312237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AF95cO1A8zIrPHHCAdCV4D3T7H4iuXaelIOnR6gHTXk=; b=Oef+cSZbSSc6idBkQCq4g/OZ9+8rUT1XPjzVegMEs3gPF0G70yGp04n6yP6NF9Vq1oMCZg G/Gq0jslrgoj+qCMXJo8oIGECawtbmCYUSLMk7n/Nd+FtV7BwEyoF0FUxXxdArBV7icz04 gjC9NdsMF7HCg40kJsQAwHDeJzuMdLM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-FPGDIalPP8WSSo0LFi2q1A-1; Wed, 20 May 2026 17:23:54 -0400 X-MC-Unique: FPGDIalPP8WSSo0LFi2q1A-1 X-Mimecast-MFC-AGG-ID: FPGDIalPP8WSSo0LFi2q1A_1779312233 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-44bf1ac8893so4157810f8f.0 for ; Wed, 20 May 2026 14:23:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779312233; x=1779917033; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AF95cO1A8zIrPHHCAdCV4D3T7H4iuXaelIOnR6gHTXk=; b=cJZaj3VtP1ob23qIrFeo1dgt25Q5u0W8yF345zDCvpJf6x8Dy1BIsR0VbfdSmPvGLV Kqfne1Dwviz2clKYEPltfwL7aeQGtwzesU8ykK1pjWhOOOPIcia/eQD7/eH+RSnQcsZd 4CdfWniJpAGOgjizWfEbssJnoG8GO994duxyjswEC9mcNkufR3R+0QAHSzPdjCNCM5Zv fXzMuI/QKRMrXEDICCikRVjyKEpqecSPmhoHfPrOLmKILkRkcYRLFgiqhbgtBG7e9Kgz Yd9x5nwEXxE04v+xbsZERuZjwR59xu+wHMBUNPC3nJ9gVX7xPt3z4p3tmfJt+efY9W/l Yx3w== X-Gm-Message-State: AOJu0Yz2oo9WMSfrnmKHs7ogbkxKRiR3ugSyYD/y2Lk0HsO2uTvpNPWd SZKfapJwRTx944MVcqquRF6GaKRJsaZHdCs4Uznuo7lnos9D2c+6mYLC2FBoKGQ8NDtSymf1Wm/ N2BU3qbQHwJn3ytBYyoXsNwj9Ht6nLqyKIymvry7yDeWyHSGbPF2Asw== X-Gm-Gg: Acq92OElVUDIr9xHdCbbHJ/azTADV5aLDtMBoJuXz5xCIvda9y/mBpxjHXS+RHpbCv0 G9X7nNGKFLYvH7dqYYeForeq0frXfQE8EesObNK7S6kqktLRUOHAh1cajQa0t7bygBj+LJ2AkQC IV4xA+231xEe8M4P5zhySghMQAv3wywqBjIU6mnUxlIkIIZGmI1AwaP1pgu0g6ALtZlcaoGy3Wi tm2UegFK9Djic2gq885Mkav7le5Mrq6NDZm/geLupRDJV7aCQMOS3ylzFPXVe7MBKRz/44JNfQV g583xBWMZ9Dnv2ESQS6oRXSmkQWpFdX8qdXamZUsqtsxxtFthY9BNFYlC8QTHiZ3kUGkAoMaY3F CQOcuu1jrkDKP9afU3K9xTUjbgaMJDV6F X-Received: by 2002:a05:600c:5286:b0:487:5c0:671f with SMTP id 5b1f17b1804b1-49036036772mr1348665e9.9.1779312233017; Wed, 20 May 2026 14:23:53 -0700 (PDT) X-Received: by 2002:a05:600c:5286:b0:487:5c0:671f with SMTP id 5b1f17b1804b1-49036036772mr1348375e9.9.1779312232488; Wed, 20 May 2026 14:23:52 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033cdcc01sm21159935e9.0.2026.05.20.14.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 14:23:51 -0700 (PDT) From: Stefano Brivio To: Anshu Kumari Subject: Re: [PATCH 6/6] doc: Add --dhcp-boot and --dhcp-opt to man page Message-ID: <20260520232346.33d02e42@elisabeth> In-Reply-To: <20260518132002.418296-7-anskuma@redhat.com> References: <20260518132002.418296-1-anskuma@redhat.com> <20260518132002.418296-2-anskuma@redhat.com> <20260518132002.418296-3-anskuma@redhat.com> <20260518132002.418296-4-anskuma@redhat.com> <20260518132002.418296-5-anskuma@redhat.com> <20260518132002.418296-6-anskuma@redhat.com> <20260518132002.418296-7-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 20 May 2026 23:23:51 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nmu_f249wIV6DJZRU73Qcdm7QXoyolHDhPO2QF61xO4_1779312233 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: Y2WDFVPXZCSHUDD5QM6IFISV5FCH22DM X-Message-ID-Hash: Y2WDFVPXZCSHUDD5QM6IFISV5FCH22DM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, jmaloy@redhat.com, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 18 May 2026 18:50:02 +0530 Anshu Kumari wrote: > Document the new --dhcp-boot and --dhcp-opt command-line options in > the passt(1) man page, including supported option codes grouped by > value type and usage examples. > > Link: https://bugs.passt.top/show_bug.cgi?id=192 > Signed-off-by: Anshu Kumari > --- > passt.1 | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/passt.1 b/passt.1 > index 908fd4a..c39e5ec 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -430,6 +430,50 @@ Send \fIname\fR as DHCP option 12 (hostname). > FQDN to configure the client with. > Send \fIname\fR as Client FQDN: DHCP option 81 and DHCPv6 option 39. > > +.TP > +.BR \-\-dhcp-boot " " \fIurl > +Boot file URL for network boot. > +Populates the boot file field in DHCP replies. For UEFI HTTP boot, > +also set the vendor class identifier using \-\-dhcp-opt 60,HTTPClient. > + > +.TP > +.BR \-\-dhcp-opt " " \fICODE\fR,\fIVALUE\fR > +Set a DHCP option by numeric code. The value format is determined automatically > +from the option code. Multiple IP addresses are space-separated within quotes. > +This option can be specified multiple times. Options set with \-\-dhcp-opt > +override built-in values and \-\-dhcp-boot settings. When we refer to other options, we highlight them, say: \fB--dhcp-boot\fR For further examples, look for "See option" or "Implies" in this file. > +Only the following option codes are supported (unsupported codes cause an error): > +.RS > +.TP > +.B IPv4 address options > +1 (Subnet Mask), 16 (Swap Server), 28 (Broadcast Address), 50 (Requested IP), > +54 (Server Identifier) > +.TP > +.B IPv4 address list options > +3 (Router), 4 (Time Server), 5 (Name Server), 6 (DNS), 7 (Log Server), > +8 (Cookie Server), 9 (LPR Server), 10 (Impress Server), > +11 (Resource Location Server), 33 (Static Routes), 41 (NIS Servers), > +42 (NTP Servers), 44 (NetBIOS Name Server) > +.TP > +.B Integer options > +2 (Time Offset, 32-bit), 13 (Boot File Size, 16-bit), 19 (IP Forwarding, 8-bit), > +23 (Default IP TTL, 8-bit), 26 (Interface MTU, 16-bit), > +37 (TCP Default TTL, 8-bit), 38 (TCP Keepalive Interval, 32-bit), > +51 (IP Address Lease Time, 32-bit), > +53 (DHCP Message Type, 8-bit), 57 (Max DHCP Message Size, 16-bit), > +58 (Renewal Time, 32-bit), 59 (Rebinding Time, 32-bit) > +.TP > +.B String options > +12 (Host Name), 15 (Domain Name), 17 (Root Path), 40 (NIS Domain Name), > +60 (Vendor Class Identifier), 61 (Client Identifier), 66 (TFTP Server Name), > +67 (Bootfile Name), 119 (Domain Search List), 252 (WPAD URL) > +.TP > +.B Classless static route options (RFC 3442 encoding) > +121 (Classless Static Routes). > +Format: "CIDR/mask,gateway" entries, space-separated. > +Example: \-\-dhcp-opt 121,"10.0.1.0/24,10.0.0.1 0.0.0.0/0,10.0.0.1" > +.RE > + > .TP > .BR \-t ", " \-\-tcp-ports " " \fIspec > Configure TCP port forwarding to guest or namespace. \fIspec\fR can be one of: Except for pending comments from David and myself, the whole series looks good to me! I suppose that addressing those comments especially around 2/6 and 3/6 might take a few iterations, though. -- Stefano