public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: Paul Holzinger <pholzing@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/4] Fix race condition while closing spliced connections
Date: Thu, 21 May 2026 16:37:41 +1000	[thread overview]
Message-ID: <20260521063745.1211215-1-david@gibson.dropbear.id.au> (raw)

Fix bug 202, where a race condition could cause connections to be
incorrectly reset in certain circumstances.

Patch 2/4 is the bug fix proper.  1/4 improves error reporting and
debugging messages in the vicinity.  Patches 3..4/4 are some small
cleanups I noticed in the area while working on the fix.

Link: https://bugs.passt.top/show_bug.cgi?id=202

v2:
 * Formatting and comment fixes, per Stefano's review
 * Dropped patches 5 & 6 for now.  I still think they're worthwhile,
   but are closely related to other oddities that need some work.  I
   didn't want to delay the bugfix itself.

David Gibson (4):
  tcp_splice: Improve error reporting
  tcp_splice: Avoid missing EOF recognition while forwarding
  tcp_splice: Clean up flow control path for splice forwarding
  tcp_splice: Simplify tracking of read/written bytes

 flow.h       |   7 ++
 log.h        |  19 +++---
 passt.c      |   2 +-
 tcp_conn.h   |   6 +-
 tcp_splice.c | 185 ++++++++++++++++++++++++++++++---------------------
 tcp_splice.h |   2 +-
 6 files changed, 129 insertions(+), 92 deletions(-)

-- 
2.54.0


             reply	other threads:[~2026-05-21  6:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  6:37 David Gibson [this message]
2026-05-21  6:37 ` [PATCH v2 1/4] tcp_splice: Improve error reporting David Gibson
2026-05-21  6:37 ` [PATCH v2 2/4] tcp_splice: Avoid missing EOF recognition while forwarding David Gibson
2026-05-21  6:37 ` [PATCH v2 3/4] tcp_splice: Clean up flow control path for splice forwarding David Gibson
2026-05-21  6:37 ` [PATCH v2 4/4] tcp_splice: Simplify tracking of read/written bytes David Gibson
2026-05-21 18:05 ` [PATCH v2 0/4] Fix race condition while closing spliced connections Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260521063745.1211215-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).